Re: [7u-dev] Request for approval: 8013485 - javac can't handle annotations with a from a previous compilation unit

2014-11-19 Thread Naoto Sato
Approved. Naoto On 11/19/14, 2:55 PM, Rob McKenna wrote: Hi folks, Requesting approval for this straightforward backport to 7: https://bugs.openjdk.java.net/browse/JDK-8013485 http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/780014a234fa -Rob

Re: [7u-dev] Request for approval: JDK8060169: Update the Crash Reporting URL in the Java crash log

2014-10-31 Thread Naoto Sato
Approved. Naoto On 10/31/14, 12:08 PM, david buck wrote: Hi! Please approve my backport from JDK8 to JDK7 of this trivial change: Bug Report: https://bugs.openjdk.java.net/browse/JDK-8060169 JDK8 change: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/9f35f614847d JDK8 fix applies cl

Re: [7u-dev] Request for approval for 8041984: CompilerThread seems to occupy all CPU in a very rare situation

2014-10-31 Thread Naoto Sato
Approved. Naoto On 10/31/14, 11:39 AM, Vladimir Kozlov wrote: Backport to 7u request. Changes were pushed into jdk9 last week and 8u this week. Nightly testing is fine. Changes are applied cleanly to 7u sources. https://bugs.openjdk.java.net/browse/JDK-8041984 http://cr.openjdk.java.net/~kvn/

Re: [7u-dev] Request for approval: 8025917: JDK demo applets not running with >=7u40 or (JDK 8 and JDK 9)

2014-09-23 Thread Naoto Sato
Approved. Naoto On 9/23/14, 6:22 AM, Andrew Brygin wrote: Hello, please approve an identical backport of the fix to jdk7u-dev. The bug: https://bugs.openjdk.java.net/browse/JDK-8025917 jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/f497d36d25f8 jdk8 changeset: http://hg.openjd

Re: [7u-dev] Request for approval : 8057813: Alterations to jdk_security3 test target

2014-09-19 Thread Naoto Sato
Approved. Naoto On 9/19/14, 9:34 AM, Seán Coffey wrote: Looking to push this test clean up to jdk7u-dev. webrev : http://cr.openjdk.java.net/~coffeys/webrev.7u.8057813/webrev/ bug report : https://bugs.openjdk.java.net/browse/JDK-8057813 review thread : http://mail.openjdk.java.net/pipermail/s

hg: jdk7u/jdk7u-dev/jdk: 8041791: String.toLowerCase regression - violates Unicode standard

2014-08-15 Thread naoto . sato
Changeset: b25397be1e6a Author:naoto Date: 2014-08-15 12:46 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/b25397be1e6a 8041791: String.toLowerCase regression - violates Unicode standard Reviewed-by: peytoia Contributed-by: jeremyman...@google.com ! src/share/classes

Re: [RFR] JDK-8043910 String.toLowerCase regression - violates Unicode standard

2014-08-15 Thread Naoto Sato
Jeremy, I can push it for you. Naoto On 8/14/14, 4:58 PM, Jeremy Manson wrote: Thanks, Naoto. I assure you, my motives are entirely selfish. :) Can someone push this into 7u? I'm not a committer. Jeremy On Thu, Aug 14, 2014 at 4:57 PM, Naoto Sato mailto:naoto.s...@oracle.com>

Re: [RFR] JDK-8043910 String.toLowerCase regression - violates Unicode standard

2014-08-14 Thread Naoto Sato
Looks good to me. Thank you for the backporting! Naoto On 8/14/14, 4:01 PM, Jeremy Manson wrote: Hello, Can someone please review / sponsor the following change for the subject bug (https://bugs.openjdk.java.net/browse/JDK-8043910) to the 7u repository: http://cr.openjdk.java.net/~jmanson/80

Re: [7u-dev] Request for approval: 8050165 and 8050167: two stack walking fixes for sparc-linux

2014-07-22 Thread Naoto Sato
Approved. Naoto On 7/22/14, 6:15 AM, Zhengyu Gu wrote: Hi, Please approve the direct backport from 8u40 to 7udev repo. The two fixes are sparc-linux specific. Bug: https://bugs.openjdk.java.net/browse/JDK-8050165 8u40 changeset:

Re: [7u-dev] Request for approval : 7095856: OutputStreamHook doesn't handle null values

2014-07-17 Thread Naoto Sato
Approved. Naoto On 7/17/14, 12:32 PM, Seán Coffey wrote: Looking to backport this to 7u-dev from JDK 9. It applies cleanly. bug report : https://bugs.openjdk.java.net/browse/JDK-7095856 changesets : - http://hg.openjdk.java.net/jdk9/jdk9/corba/rev/0060505fb71a - http://hg.openjdk.java.net/

Re: [7u-dev] Request for approval : 8037945: Paths.get("").normalize() throws ArrayIndexOutOfBoundsException

2014-05-28 Thread Naoto Sato
Approved. Naoto On 5/28/14, 5:47 AM, Seán Coffey wrote: I'd like to backport this fix to the jdk7u-dev code line. Applies cleanly. Already fixed in 8u20. Builds & tests are green. bug : https://bugs.openjdk.java.net/browse/JDK-8037945 8u20 changeset : http://hg.openjdk.java.net/jdk8u/jdk8u/jdk

Re: [7u-communication] New jdk7u maintainer : Naoto Sato

2014-05-14 Thread Naoto Sato
maintainer authority for jdk7u to Naoto Sato. Naoto will be helping Jeff, Sean, Rob and myself with jdk7u maintainer duties in the future. Welcome, Naoto! I will update the project web page to reflect the changes. cheers, dalibor topic [0] http://mail.openjdk.java.net/pipermail/jdk7u-dev/2013-Novem

Re: [7u60] Review request for 8035988 7u60 l10n resource file translation update 1

2014-03-04 Thread Naoto Sato
Looks good to me. Naoto On 3/4/14, 4:06 PM, Michael Fang wrote: Hi all, Please help to code review the changes for the following CR: 8035988 : 7u60 l10n resource file translation update 1 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019541 The webrev is located at: http://cr.openjdk.j

Re: [7u] Review request for 8019541

2013-07-03 Thread Naoto Sato
igestalg <算法>]摘要算法的名称"}, 76c76 < "[-sigalg <算法>] 签名算法的名称"}, --- > "[-sigalg <算法>] 签名算法的名称"}, thanks, -michael On 07/03/13 11:25, Naoto Sato wrote: Hi Michael, Looks like the following f

Re: [7u] Review request for 8019541

2013-07-03 Thread Naoto Sato
Hi Michael, Looks like the following file does not contain any meaningful change: (jdk)/src/share/classes/sun/security/tools/JarSignerResources_zh_CN.java Other changes look good to me (haven't looked at the translation itself). Naoto On 7/2/13 8:42 PM, Michael Fang wrote: Hi all, Please he

Re: [7u] Review request for 8008764

2013-02-27 Thread Naoto Sato
ed as key: toggle value: expand = toggle expand. I will file a new bug for dev team who created this file. thanks, -michael On 13年02月27日 10:10 上午, Naoto Sato wrote: I think that a key in .properties simply cannot have a plain blank character. It has to be escaped with a single backquote like, &q

Re: [7u] Review request for 8008764

2013-02-27 Thread Naoto Sato
es/com/sun/accessibility/internal/resources/accessibility_sv.properties:toggle ut\u00F6ka=v\u00E4xla ut\u00F6ka thanks, -michael On 13年02月26日 07:24 下午, Michael Fang wrote: Thanks Naoto. I will check with translation team about what happened. thanks, -michael On 13年02月26日 06:58 下午, Naoto Sato

Re: [7u] Review request for 8008764

2013-02-26 Thread Naoto Sato
Hi Michael, Since I am a Japanese, I just skimmed "ja" translations. The first file seems to contain an incorrect entry. src/share/classes/com/sun/accessibility/internal/resources/accessibility_ja.properties (sdiff): --- 105 toggle expand=トグル展開105 toggle トグル展開 --- Looks like the new fi

Re: CFV: New JDK 7 Updates Project Committer: Edvard Wendelin

2013-02-23 Thread Naoto Sato
Vote: yes Naoto On 2/22/13 6:35 AM, Dalibor Topic wrote: I hereby nominate Edvard Wendelin to JDK 7 Updates Project Committer. As one of this Project's Maintainers, Edvard has been active in this Project since its creation. He has gradually accumulated the necessary commits by contributing acr

Re: Fwd: Re: [7u10] Request for approval: 7174233: Openjdk is missing some key maps on the Japanese keyboards

2013-01-30 Thread Naoto Sato
Please also provide a regression test along with the fix. Thanks. Naoto On 1/30/13 6:08 PM, Frank Ding wrote: Hi Naoto, Thank you. To Sean, Could you please shed your light or anything I can do? Best regards, Frank On 1/31/2013 3:15 AM, Naoto Sato wrote: OK, I am fine with

Re: Fwd: Re: [7u10] Request for approval: 7174233: Openjdk is missing some key maps on the Japanese keyboards

2013-01-30 Thread Naoto Sato
OK, I am fine with backporting the fix. Please go ahead. Naoto On 1/29/13 9:34 PM, Frank Ding wrote: Hi Naoto and Sean I think we can verify it in Japanese environment. The reason for backporting is that it's quite safe to do and also would be better if the defect is fixed in JDK 7 also.

Re: [7u10] Request for approval: 7174233: Openjdk is missing some key maps on the Japanese keyboards

2012-09-18 Thread Naoto Sato
While I think fix looks good (that's why I approved the change in jdk8), I don't find any reason for backporting this change into 7u line. Is there any strong reason for backport? Naoto On 9/18/12 10:37 AM, Seán Coffey wrote: cc'ing i18n-dev alias here also. i18n fixes can be difficult to tes

hg: jdk7u/jdk7u-dev/jdk: 2 new changesets

2012-01-11 Thread naoto . sato
Changeset: 9a2c591758d8 Author:naoto Date: 2012-01-11 10:18 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/9a2c591758d8 7027061: Testcase failure: java/util/Locale/Bug6989440.java - java.util.ConcurrentModificationException Reviewed-by: naoto Contributed-by: edvard.w

hg: jdk7u/jdk7u-dev/jdk: 7022407: Spinning CPU in LocaleObjectCache.get()

2011-11-22 Thread naoto . sato
Changeset: 0890350cf539 Author:naoto Date: 2011-11-22 11:29 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/0890350cf539 7022407: Spinning CPU in LocaleObjectCache.get() Reviewed-by: okutsu ! src/share/classes/sun/util/locale/LocaleObjectCache.java

[7u4] Request for approval for CR 7022407 - Spinning CPU in LocaleObjectCache.get()

2011-11-22 Thread Naoto Sato
Hello, Can you please approve the fix for the following bug? http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7022407 It's a simple back port from the JDK8 repo: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/42fe05e54e69 Naoto

hg: jdk7u/jdk7u-dev/jdk: 7073906: Locale.getDefault() returns wrong Locale for Java SE 7

2011-11-11 Thread naoto . sato
Changeset: 8cfb1c6d62f3 Author:naoto Date: 2011-11-11 14:22 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/8cfb1c6d62f3 7073906: Locale.getDefault() returns wrong Locale for Java SE 7 Reviewed-by: okutsu ! src/windows/native/java/lang/java_props_md.c

Request for approval for CR 7073906 - Locale.getDefault() returns wrong Locale for Java SE 7

2011-11-10 Thread Naoto Sato
Hello, Can you please approve back porting the fix for the following bug? http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7073906 The changeset for the fix in JDK8 is this: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/c3a8d5feee94 The same changeset can be applied to 7u4 without any modifi