Re: Fwd: [7u-dev] Request for approval for 8066103: C2's range check smearing allows out of bound array accesses

2015-01-05 Thread Vladimir Kozlov
Looks good. Thanks, Vladimir On 1/5/15 8:57 AM, Roland Westrelin wrote: Vladimir, Can you review this one as well? Thanks, Roland. Begin forwarded message: Date: December 22, 2014 at 4:56:40 PM GMT+1 From: Seán Coffey To: Roland Westrelin , jdk7u-dev@openjdk.java.net Subject: Re: [7u-dev]

Re: Fwd: [7u-dev] Request for approval for 8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed

2015-01-05 Thread Vladimir Kozlov
Changes looks good. They match changes in 9 and 8u. Thanks, Vladimir On 1/5/15 8:57 AM, Roland Westrelin wrote: Hi Vladimir, Can you review this? Thanks, Roland. Begin forwarded message: Date: December 22, 2014 at 4:55:50 PM GMT+1 From: Seán Coffey To: Roland Westrelin , jdk7u-dev@openjdk

hg: jdk7u/jdk7u-dev/hotspot: 3 new changesets

2014-12-05 Thread vladimir . kozlov
Changeset: 1ec29fc66504 Author:kvn Date: 2014-12-02 12:08 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/1ec29fc66504 8065618: C2 RA incorrectly removes kill projections Summary: Don't remove KILL projections if their "defining" nodes have SCMemProj projection (m

Re: [7u-dev] Request for approval for 8065618: C2 RA incorrectly removes kill projections

2014-12-04 Thread Vladimir Kozlov
Thank you, Rob On 12/4/14 11:03 AM, Rob McKenna wrote: Please add suitable noreg keywords to the bugs. Done. Approved. Thanks, Vladimir -Rob On 04/12/14 18:38, Vladimir Kozlov wrote: 7u backport request. Changes were pushed into jdk9 more then week ago, no problems were found

[7u-dev] Request for approval for 8065618: C2 RA incorrectly removes kill projections

2014-12-04 Thread Vladimir Kozlov
7u backport request. Changes were pushed into jdk9 more then week ago, no problems were found since then. Jdk9 changes were NOT applied to 8u cleanly because of RA code refactoring in jdk9. I did mistake during 8065618 backport into 8u and additional changes have to be pushed into 8u: 8066649.

hg: jdk7u/jdk7u-dev/hotspot: 8046289: compiler/6340864/TestLongVect.java timeout with

2014-11-06 Thread vladimir . kozlov
Changeset: 3ae4d3bcedb8 Author:rbackman Date: 2014-06-23 13:33 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/3ae4d3bcedb8 8046289: compiler/6340864/TestLongVect.java timeout with Reviewed-by: iveresov, vlivanov ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/p

Re: Resend: [7u-dev] Request for approval for 8046289: compiler/6340864/TestLongVect.java timeout with

2014-11-06 Thread Vladimir Kozlov
. On 06/11/2014 01:48, Vladimir Kozlov wrote: Please, ignore previous mail. I messed up links. Backport to 7u request. Changes were pushed into jdk9 few months ago and 8u 2 months ago. Nightly testing is fine. Changes are applied cleanly to 7u sources. The problem in 7u80 is caused by recent

Resend: [7u-dev] Request for approval for 8046289: compiler/6340864/TestLongVect.java timeout with

2014-11-05 Thread Vladimir Kozlov
Please, ignore previous mail. I messed up links. Backport to 7u request. Changes were pushed into jdk9 few months ago and 8u 2 months ago. Nightly testing is fine. Changes are applied cleanly to 7u sources. The problem in 7u80 is caused by recent backport of JDK-8030976 changes [1]. https://

[7u-dev] Request for approval for 8046289: compiler/6340864/TestLongVect.java timeout with

2014-11-05 Thread Vladimir Kozlov
Backport to 7u request. Changes were pushed into jdk9 few months ago and 8u 2 months ago. Nightly testing is fine. Changes are applied cleanly to 7u sources. The problem in 7u80 is caused by recent backport of JDK-8030976 changes [1]. https://bugs.openjdk.java.net/browse/JDK-8058107 http://cr

hg: jdk7u/jdk7u-dev/hotspot: 8041984: CompilerThread seems to occupy all CPU in a very rare situation

2014-10-31 Thread vladimir . kozlov
Changeset: 861532140bbd Author:kvn Date: 2014-10-24 10:28 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/861532140bbd 8041984: CompilerThread seems to occupy all CPU in a very rare situation Summary: Add new timeout checks to EA. Reviewed-by: iveresov, drchase !

Re: [7u-dev] Request for approval for 8041984: CompilerThread seems to occupy all CPU in a very rare situation

2014-10-31 Thread Vladimir Kozlov
Thank you, Naoto Vladimir On 10/31/14 12:18 PM, Naoto Sato wrote: Approved. Naoto On 10/31/14, 11:39 AM, Vladimir Kozlov wrote: Backport to 7u request. Changes were pushed into jdk9 last week and 8u this week. Nightly testing is fine. Changes are applied cleanly to 7u sources. https

[7u-dev] Request for approval for 8041984: CompilerThread seems to occupy all CPU in a very rare situation

2014-10-31 Thread Vladimir Kozlov
Backport to 7u request. Changes were pushed into jdk9 last week and 8u this week. Nightly testing is fine. Changes are applied cleanly to 7u sources. https://bugs.openjdk.java.net/browse/JDK-8041984 http://cr.openjdk.java.net/~kvn/8041984/webrev.01/ Review thread: http://mail.openjdk.java.net

Re: [7u-dev] Request for approval 8030976: Untaken paths should be more vigorously pruned at highest optimization level

2014-10-22 Thread Vladimir Kozlov
Changes looks correct. Thanks, Vladimir On 10/21/14 11:52 PM, Sergey Gabdurakhmanov wrote: Vladimir, I need a review on this backport. May be you can help? BR, Sergey On 17.10.2014 13:30, Sergey Gabdurakhmanov wrote: Hello, Could somebody please review the backport? BR, Sergey On 15.10.2

hg: jdk7u/jdk7u-dev/hotspot: 8059299: assert(adr_type != NULL) failed: expecting TypeKlassPtr

2014-10-20 Thread vladimir . kozlov
Changeset: 21a476d3a51c Author:kvn Date: 2014-10-02 11:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/21a476d3a51c 8059299: assert(adr_type != NULL) failed: expecting TypeKlassPtr Summary: Use top() for dead paths when initializing Phi node of exceptions klass

Re: [7u-dev] RFR(S) 8059299: assert(adr_type != NULL) failed: expecting TypeKlassPtr

2014-10-20 Thread Vladimir Kozlov
Thank you, Rob Vladimir On 10/20/14 3:02 PM, Rob McKenna wrote: Approved. -Rob On 20/10/14 22:28, Vladimir Kozlov wrote: Backport request. Changes was pushed into jdk9 2 weeks ago and to 8u40 last week. Nighties are fine. jdk8u changes are applied cleanly to 7u sources. jdk9 changes

[7u-dev] RFR(S) 8059299: assert(adr_type != NULL) failed: expecting TypeKlassPtr

2014-10-20 Thread Vladimir Kozlov
Backport request. Changes was pushed into jdk9 2 weeks ago and to 8u40 last week. Nighties are fine. jdk8u changes are applied cleanly to 7u sources. jdk9 changes in test/TEST.groups were removed from 8u and 7u patches since we don't have JPRT jtreg testing for 8u and 7u. https://bugs.openjdk

Re: [7u-dev] Request for approval 8008328: [partfait] Null pointer defererence in hotspot/src/cpu/x86/vm/frame_x86.inline.hpp

2014-10-02 Thread Vladimir Kozlov
Changes look good. Thanks, Vladimir On 10/2/14 1:18 AM, Sergey Gabdurakhmanov wrote: Hello, Could you please approve the back-port of the fix for 8008328 to jdk7u-dev? The bug: https://bugs.openjdk.java.net/browse/JDK-8008328 The webrev: http://cr.openjdk.java.net/~sgabdura/8008328/webrev.00/

hg: jdk7u/jdk7u-dev/hotspot: 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

2014-09-25 Thread vladimir . kozlov
Changeset: c7f740ad8991 Author:morris Date: 2014-09-18 11:46 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/c7f740ad8991 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check Summary: Provide promoted stack slots for floating-poin

Re: [7u-dev] Request for approval for 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

2014-09-25 Thread Vladimir Kozlov
Thank you, Sean. Vladimir On 9/25/14 12:14 PM, Seán Coffey wrote: On 25/09/2014 20:06, Vladimir Kozlov wrote: On 9/25/14 11:49 AM, Seán Coffey wrote: Vladimir, this needs to be pushed to the jdk8u code line first. http://openjdk.java.net/projects/jdk7u/groundrules.html : Rule 1 Yes, I

Re: [7u-dev] Request for approval for 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

2014-09-25 Thread Vladimir Kozlov
push into 8u without an other 7u request? Thanks, Vladimir regards, Sean. On 25/09/2014 19:42, Vladimir Kozlov wrote: Backport request. Changes was pushed into jdk9 week ago. Nighties are fine. Changes are applied cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8050022 jdk9 webrev

[7u-dev] Request for approval for 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

2014-09-25 Thread Vladimir Kozlov
Backport request. Changes was pushed into jdk9 week ago. Nighties are fine. Changes are applied cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8050022 jdk9 webrev: http://cr.openjdk.java.net/~morris/JDK-8050022.05 Review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev

Re: [7u-dev] Request for approval 8046516: Segmentation fault in JVM (easily reproducible)

2014-08-18 Thread Vladimir Kozlov
Looks good. Thanks, Vladimir On 8/17/14 11:55 PM, Sergey Gabdurakhmanov wrote: Hello, Could you please approve the straight back-port of the fix for 8046516 to jdk7u-dev? The bug: https://bugs.openjdk.java.net/browse/JDK-8046516 The webrev: http://cr.openjdk.java.net/~sgabdura/8046516/webrev

hg: jdk7u/jdk7u-dev/hotspot: 8054530: C2: assert(res == old_res) failed: Inconsistency between old and new

2014-08-13 Thread vladimir . kozlov
Changeset: 612e0c2ebea4 Author:morris Date: 2014-08-13 13:00 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/612e0c2ebea4 8054530: C2: assert(res == old_res) failed: Inconsistency between old and new Summary: Fixed signedness problem with assertion. Reviewed-by: kv

hg: jdk7u/jdk7u-dev/hotspot: 8049542: C2: assert(size_in_words <= (julong)max_jint) failed: no overflow

2014-08-05 Thread vladimir . kozlov
Changeset: 16f41a7c5c28 Author:kvn Date: 2014-08-05 14:44 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/16f41a7c5c28 8049542: C2: assert(size_in_words <= (julong)max_jint) failed: no overflow Summary: Added juint cast to avoid gcc problem we have on one of our pl

Re: [7u-dev] Request for approval for 8049542: C2: assert(size_in_words <= (julong)max_jint) failed: no overflow

2014-08-05 Thread Vladimir Kozlov
Thank you, Seán Vladimir On 8/5/14 12:32 PM, Seán Coffey wrote: Approved. regards, Sean. On 05/08/2014 19:28, Vladimir Kozlov wrote: Sorry about webrev. Here is correct one: http://cr.openjdk.java.net/~kvn/8049252_7u/webrev It fixes the problem we have with the version of gcc compiler on

Re: [7u-dev] Request for approval for 8049542: C2: assert(size_in_words <= (julong)max_jint) failed: no overflow

2014-08-05 Thread Vladimir Kozlov
jdk7u/groundrules.html The webrev link doesn't work also. regards, Sean. On 05/08/2014 01:07, Vladimir Kozlov wrote: Requesting push approval for JDK-8049542. It is only needed in 7u. Changes were reviewed and tested. https://bugs.openjdk.java.net/browse/JDK-8049542 http://cr.openjdk.jav

[7u-dev] Request for approval for 8049542: C2: assert(size_in_words <= (julong)max_jint) failed: no overflow

2014-08-04 Thread Vladimir Kozlov
Requesting push approval for JDK-8049542. It is only needed in 7u. Changes were reviewed and tested. https://bugs.openjdk.java.net/browse/JDK-8049542 http://cr.openjdk.java.net/~kvn/webrevs/8049252_7u/webrev Thanks, Vladimir

Re: [7u-dev] Request for approval 8043354: OptimizePtrCompare too aggressive when allocations are present

2014-06-04 Thread Vladimir Kozlov
Looks good. Thanks, Vladimir On 6/4/14 1:33 AM, Sergey Gabdurakhmanov wrote: Hello, Could you please approve the straight back-port of the fix for 8043354 to jdk7u-dev? The bug: https://bugs.openjdk.java.net/browse/JDK-8043354 The webrev: http://cr.openjdk.java.net/~sgabdura/8043354/webrev.0

Re: [7u-dev] Request for approval 8041351: Crash in src/share/vm/opto/loopnode.cpp:3215 - assert(!had_error) failed: bad dominance

2014-04-25 Thread Vladimir Kozlov
Sergey, Indention of closing "}" is incorrect. Please, fix it before the push. No need for second review. Thanks, Vladimir On 4/25/14 1:10 AM, Sergey Gabdurakhmanov wrote: Hello, Could you please approve the straight back-port of the fix for 8041351 to jdk7u-dev? The bug: https://bugs.open

Re: hg: jdk7u/jdk7u-dev/jdk: 8009222: java.lang.IllegalArgumentException: not invocable, no method type when attempting to get getter method handle for a static field

2014-01-17 Thread Vladimir Kozlov
Sean, It is different Vladimir :) Ivanov. The bug has 7u60-critical-approved label, I assume it was approved. Regards, Vladimir K On 1/17/14 9:00 AM, Seán Coffey wrote: Vladimir, I didn't see an approval request for this push. To keep in line with JDK 7u process and to help records, can you

hg: jdk7u/jdk7u-dev/jdk: 8009222: java.lang.IllegalArgumentException: not invocable, no method type when attempting to get getter method handle for a static field

2014-01-16 Thread vladimir . kozlov
Changeset: 628c6d46263b Author:vlivanov Date: 2014-01-17 01:54 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/628c6d46263b 8009222: java.lang.IllegalArgumentException: not invocable, no method type when attempting to get getter method handle for a static field Review

Re: HotSpot Changes in 7u (8000780: make Zero build run with JDK8)

2013-01-12 Thread Vladimir Kozlov
Andrew, The patch needs to be redone for 7u. Current will not apply because it is affected by PermGen removal changes. Would be nice to change bug's Synopsis also since it will be not for jdk8. Vladimir On 1/12/13 4:53 AM, Alejandro E Murillo wrote: On 1/11/2013 4:17 PM, Christian Thalinge