Re: [7u-dev] Request for approval for 8042235: redefining method used by multiple MethodHandles crashes VM

Thanks!

Re: [7u-dev] Request for approval for 8042235: redefining method used by multiple MethodHandles crashes VM

Approved. regards, Sean. On 14/01/2015 22:32, Kevin Walls wrote: Hi, This is a backport approval request for 8042235 into 7u. The 7u change is a little different from 8 onwards, some discussion below that led to the final webrev. bug https://bugs.openjdk.java.net/browse/JDK-8042235 webre

[7u-dev] Request for approval for 8042235: redefining method used by multiple MethodHandles crashes VM

Hi, This is a backport approval request for 8042235 into 7u. The 7u change is a little different from 8 onwards, some discussion below that led to the final webrev. bug https://bugs.openjdk.java.net/browse/JDK-8042235 webrev http://cr.openjdk.java.net/~kevinw/8042235/webrev.01/ Thanks Kevi

Re: [7u-dev] Request for approval for 8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed

gt; Can you review this? >> >> Thanks, >> Roland. >> >>> Begin forwarded message: >>> >>> Date: December 22, 2014 at 4:55:50 PM GMT+1 >>> From: Seán Coffey >>> To: Roland Westrelin , >>> jdk7u-dev@openjdk.java.ne

Re: [7u-dev] Request for approval for 8066103: C2's range check smearing allows out of bound array accesses

>> Thanks, >> Roland. >> >>> Begin forwarded message: >>> >>> Date: December 22, 2014 at 4:56:40 PM GMT+1 >>> From: Seán Coffey >>> To: Roland Westrelin , >>> jdk7u-dev@openjdk.java.net >>> Subject: Re: [7u-dev] Request

Re: Fwd: [7u-dev] Request for approval for 8066103: C2's range check smearing allows out of bound array accesses

] Request for approval for 8066103: C2's range check smearing allows out of bound array accesses As per the 8048170 request, please get a peer review before pushing to jdk7u-dev. Approved. regards, Sean. On 22/12/14 14:51, Roland Westrelin wrote: Backport to 7u request. Changes were push

Re: Fwd: [7u-dev] Request for approval for 8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed

@openjdk.java.net Subject: Re: [7u-dev] Request for approval for 8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed Roland, Please get a peer review before pushing the jdk7u changes. Approved. regards, Sean. On 22/12/14 14:46, Roland Westrelin wrote: Backport to 7u request

Re: [7u-dev] Request for approval for 8066103: C2's range check smearing allows out of bound array accesses

As per the 8048170 request, please get a peer review before pushing to jdk7u-dev. Approved. regards, Sean. On 22/12/14 14:51, Roland Westrelin wrote: Backport to 7u request. Changes were pushed to jdk9 2 weeks ago and to 8u a bit less than 2 weeks ago. Nightly testing is fine. Changes apply

Re: [7u-dev] Request for approval for 8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed

Roland, Please get a peer review before pushing the jdk7u changes. Approved. regards, Sean. On 22/12/14 14:46, Roland Westrelin wrote: Backport to 7u request. Changes were pushed to jdk9 a bit more than 2 weeks ago and to 8u a bit less than 2 weeks ago. Nightly testing is fine. The change d

[7u-dev] Request for approval for 8066103: C2's range check smearing allows out of bound array accesses

Backport to 7u request. Changes were pushed to jdk9 2 weeks ago and to 8u a bit less than 2 weeks ago. Nightly testing is fine. Changes apply cleanly to 7u sources but the test case cannot be run and I had to remove its use of the whitebox API. https://bugs.openjdk.java.net/browse/JDK-8066103

[7u-dev] Request for approval for 8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed

Backport to 7u request. Changes were pushed to jdk9 a bit more than 2 weeks ago and to 8u a bit less than 2 weeks ago. Nightly testing is fine. The change doesn’t apply cleanly to 7u sources but the conflict is straightforward to solve. https://bugs.openjdk.java.net/browse/JDK-8048170 http://c

Re: [7u-dev] Request for approval for 8058935: CPU detection gives 0 cores per cpu, 2 threads per core in Amazon EC2 environment

Approved. On 19.12.2014 16:36, Vladimir Kempik wrote: Hello, Could you please approve the following direct backport of the fix to jdk7u-dev? fix applies cleanly to jdk7 JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8058935 JDK9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/e

[7u-dev] Request for approval for 8058935: CPU detection gives 0 cores per cpu, 2 threads per core in Amazon EC2 environment

Hello, Could you please approve the following direct backport of the fix to jdk7u-dev? fix applies cleanly to jdk7 JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8058935 JDK9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/e2c93c0a76df Review thread: http://mail.openjdk.java.net

Re: [7u-dev] Request for approval for 8054478, 8066045, 8066775

Approved. Please add appropriate noreg keywords to the bugs. -Rob On 15/12/14 14:41, Vladimir Kempik wrote: Hello I would like to get an approval to push backports for 8054478, 8066045 and 8066775 to 7u-dev. The first one didn't apply cleanly, so it was reviewed. The other two apply cl

[7u-dev] Request for approval for 8054478, 8066045, 8066775

Hello I would like to get an approval to push backports for 8054478, 8066045 and 8066775 to 7u-dev. The first one didn't apply cleanly, so it was reviewed. The other two apply cleanly: 8054478: Bug - https://bugs.openjdk.java.net/browse/JDK-8054478 review thread (for 7u) - http://mail.open

Re: [7u-dev] Request for Approval for Backport: JDK-8013849: Awt assert on Hashtable.cpp:124

Thanks you, yes, it's completely straight backport. On 12/15/2014 12:15 PM, Seán Coffey wrote: Approved. I'm assuming it's a straight backport. If it's not, please get a peer review before pushing. regards, Sean. On 15/12/2014 07:49, mikhail cherkasov wrote: Hi there, Please approve the ba

Re: [7u-dev] Request for Approval for Backport: JDK-8013849: Awt assert on Hashtable.cpp:124

Approved. I'm assuming it's a straight backport. If it's not, please get a peer review before pushing. regards, Sean. On 15/12/2014 07:49, mikhail cherkasov wrote: Hi there, Please approve the backport of JDK-8013849 from 8 repo to 7. webrev: http://cr.openjdk.java.net/~mcherkas/8013849/webr

[7u-dev] Request for Approval for Backport: JDK-8013849: Awt assert on Hashtable.cpp:124

Hi there, Please approve the backport of JDK-8013849 from 8 repo to 7. webrev: http://cr.openjdk.java.net/~mcherkas/8013849/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8013849 changeset in jdk8: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/7706a622d35f Review: http://mail.openjdk.j

Re: [7u-dev] Request for Approval for Backport: JDK-6695379: Copy method annotations and parameter annotations to synthetic bridge methods

Hi Vicente, Approved. I can help push this change to jdk7u-dev for you. regards, Sean. On 10/12/2014 21:45, Vicente-Arturo Romero-Zaldivar wrote: Hi, Please approve the backport of JDK-6695379 from 9 repo to JDK7u-dev. Public webrev: http://cr.openjdk.java.net/~vromero/work/6695379/webrev.0

[7u-dev] Request for Approval for Backport: JDK-6695379: Copy method annotations and parameter annotations to synthetic bridge methods

Hi, Please approve the backport of JDK-6695379 from 9 repo to JDK7u-dev. Public webrev: http://cr.openjdk.java.net/~vromero/work/6695379/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-6695379 Review: http://mail.openjdk.java.net/pipermail/jdk7u-dev/2014-December/010081.html Thanks,

Re: [7u-dev] Request for approval for 8065098: JColorChooser no longer supports drag and drop between two JVM instances

The fix looks good. Thanks, Alexandr. On 12/8/2014 6:08 PM, Sergey Bylokhov wrote: Hi, Alexey. The fix looks good. - sean.cof...@oracle.com wrote: Approved with the condition that this gets a peer code review. regards, Sean. On 04/12/2014 13:55, Alexey Ivanov wrote: Hello, Could yo

Re: [7u-dev] Request for approval for 8065098: JColorChooser no longer supports drag and drop between two JVM instances

Hi, Alexey. The fix looks good. - sean.cof...@oracle.com wrote: > Approved with the condition that this gets a peer code review. > > regards, > Sean. > > On 04/12/2014 13:55, Alexey Ivanov wrote: > > Hello, > > > > Could you please approve the following backport of the fix to > jdk7u-dev? >

Re: [7u-dev] Request for approval for 8065618: C2 RA incorrectly removes kill projections

Thank you, Rob On 12/4/14 11:03 AM, Rob McKenna wrote: Please add suitable noreg keywords to the bugs. Done. Approved. Thanks, Vladimir -Rob On 04/12/14 18:38, Vladimir Kozlov wrote: 7u backport request. Changes were pushed into jdk9 more then week ago, no problems were found s

Re: [7u-dev] Request for approval for 8065618: C2 RA incorrectly removes kill projections

Please add suitable noreg keywords to the bugs. Approved. -Rob On 04/12/14 18:38, Vladimir Kozlov wrote: 7u backport request. Changes were pushed into jdk9 more then week ago, no problems were found since then. Jdk9 changes were NOT applied to 8u cleanly because of RA code refactoring in

[7u-dev] Request for approval for 8065618: C2 RA incorrectly removes kill projections

7u backport request. Changes were pushed into jdk9 more then week ago, no problems were found since then. Jdk9 changes were NOT applied to 8u cleanly because of RA code refactoring in jdk9. I did mistake during 8065618 backport into 8u and additional changes have to be pushed into 8u: 8066649.

Re: [7u-dev] Request for approval for 8065098: JColorChooser no longer supports drag and drop between two JVM instances

Approved with the condition that this gets a peer code review. regards, Sean. On 04/12/2014 13:55, Alexey Ivanov wrote: Hello, Could you please approve the following backport of the fix to jdk7u-dev? The patch doesn't apply cleanly automatically, code in DataTransferer.java differs. Yet the

[7u-dev] Request for approval for 8065098: JColorChooser no longer supports drag and drop between two JVM instances

Hello, Could you please approve the following backport of the fix to jdk7u-dev? The patch doesn't apply cleanly automatically, code in DataTransferer.java differs. Yet there are no local changes in the code. Swing team, Could you also review the updated patch? http://cr.openjdk.java.net/

Re: [7u-dev] Request for approval for 8031765: [TEST] Child process error stream is not empty!

Approved. regards, Sean. On 03/12/14 17:28, Alexey Ivanov wrote: Hello, Could you please approve the following direct backport of the fix to jdk7u-dev? JBS bug: https://bugs.openjdk.java.net/browse/JDK-8031765 Webrev: http://cr.openjdk.java.net/~pchelko/9/8031765/webrev/ Review: http://mai

[7u-dev] Request for approval for 8031765: [TEST] Child process error stream is not empty!

Hello, Could you please approve the following direct backport of the fix to jdk7u-dev? JBS bug: https://bugs.openjdk.java.net/browse/JDK-8031765 Webrev: http://cr.openjdk.java.net/~pchelko/9/8031765/webrev/ Review: http://mail.openjdk.java.net/pipermail/awt-dev/2014-March/007274.html JDK9 c

Re: [7u-dev] Request for approval for 6976528: PS: assert(!limit_exceeded || softrefs_clear) failed: Should have been cleared

Approved. Needs a valid noreg label. -Rob On 19/11/14 14:47, Poonam Bajaj wrote: Hello, Requesting approval for this simple backport to 7u. The code changes remove the unnecessary asserts. The patch applies cleanly to jdk7u repo. Bug:JDK-6976528

[7u-dev] Request for approval for 6976528: PS: assert(!limit_exceeded || softrefs_clear) failed: Should have been cleared

Hello, Requesting approval for this simple backport to 7u. The code changes remove the unnecessary asserts. The patch applies cleanly to jdk7u repo. Bug:JDK-6976528 : PS: assert(!limit_exceeded || softrefs_clear) failed: Should have been clear

Re: [7u-dev] Request for approval for CR 8058583: Remove CompilationRepeat

Approved. On 14.11.2014 16:03, Andreas Eriksson wrote: Hi, I'd like approval for a jdk7 backport of CR 8058583: Remove CompilationRepeat Backport reviewed by Nils Eliasson. Webrev: http://cr.openjdk.java.net/~aeriksso/8058583/webrev.00/ Review thread: http://mail.openjdk.java.net/pipermail/hot

[7u-dev] Request for approval for CR 8058583: Remove CompilationRepeat

Hi, I'd like approval for a jdk7 backport of CR 8058583: Remove CompilationRepeat Backport reviewed by Nils Eliasson. Webrev: http://cr.openjdk.java.net/~aeriksso/8058583/webrev.00/ Review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-November/016281.html Regards,

Re: [7u-dev] Request for approval for CR 8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error

Missed that. Apologies. I thought the links referred to the JDK 8 review. You're good to push then. regards, Sean. On 10/11/14 13:41, Andreas Eriksson wrote: As I mentioned in the mail, the backport has been reviewed by Calvin Cheung, is that not enough? - Andreas On 2014-11-10 14:38, Seán C

Re: [7u-dev] Request for approval for CR 8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error

As I mentioned in the mail, the backport has been reviewed by Calvin Cheung, is that not enough? - Andreas On 2014-11-10 14:38, Seán Coffey wrote: Approved. I'm assuming this patch applies cleanly. If not, please obtain a peer review before pushing. regards, Sean. On 10/11/14 13:04, Andreas

Re: [7u-dev] Request for approval for CR 8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error

Approved. I'm assuming this patch applies cleanly. If not, please obtain a peer review before pushing. regards, Sean. On 10/11/14 13:04, Andreas Eriksson wrote: Hi, I'd like approval for backporting JDK-8020675 - invalid jar file in the boo

[7u-dev] Request for approval for CR 8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error

Hi, I'd like approval for backporting JDK-8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error. Backport reviewed by Calvin Cheung. Webrev: http://cr.openjdk.java.net/~aeriksso/8020675/webrev.01/ Review thread: http:

Re: [7u-dev] Request for approval for CR 8061954: 7u76 - deployment warning dialogs do not work on Linux

Hadn't noticed the missing version. Thanks Anton. Approved. -Rob On 07/11/14 13:56, Anton Litvinov wrote: Hello, I would like to request for approval to push the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8061954 Webrev: http://cr.openjdk.java.net/~alitvinov/8061954/webr

[7u-dev] Request for approval for CR 8061954: 7u76 - deployment warning dialogs do not work on Linux

Hello, I would like to request for approval to push the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8061954 Webrev: http://cr.openjdk.java.net/~alitvinov/8061954/webrev.00 Review thread: Approval 1 - http://mail.openjdk.java.net/pipermail/awt-dev/2014-November/008662.html

Re: Resend: [7u-dev] Request for approval for 8046289: compiler/6340864/TestLongVect.java timeout with

Thank you, Sean On 11/6/14 1:15 AM, Seán Coffey wrote: You might want to add a noreg- label to the bug report. The testbug label should be removed also since this affects product code. I replaced testbug with noreg-sqe since we have the test. Approved. Thanks, Vladimir regards, Sean.

Re: Resend: [7u-dev] Request for approval for 8046289: compiler/6340864/TestLongVect.java timeout with

You might want to add a noreg- label to the bug report. The testbug label should be removed also since this affects product code. Approved. regards, Sean. On 06/11/2014 01:48, Vladimir Kozlov wrote: Please, ignore previous mail. I messed up links. Backport to 7u request. Changes were pushed

Resend: [7u-dev] Request for approval for 8046289: compiler/6340864/TestLongVect.java timeout with

Please, ignore previous mail. I messed up links. Backport to 7u request. Changes were pushed into jdk9 few months ago and 8u 2 months ago. Nightly testing is fine. Changes are applied cleanly to 7u sources. The problem in 7u80 is caused by recent backport of JDK-8030976 changes [1]. https://

[7u-dev] Request for approval for 8046289: compiler/6340864/TestLongVect.java timeout with

Backport to 7u request. Changes were pushed into jdk9 few months ago and 8u 2 months ago. Nightly testing is fine. Changes are applied cleanly to 7u sources. The problem in 7u80 is caused by recent backport of JDK-8030976 changes [1]. https://bugs.openjdk.java.net/browse/JDK-8058107 http://cr

Re: [7u-dev] Request for approval for 8041984: CompilerThread seems to occupy all CPU in a very rare situation

Thank you, Naoto Vladimir On 10/31/14 12:18 PM, Naoto Sato wrote: Approved. Naoto On 10/31/14, 11:39 AM, Vladimir Kozlov wrote: Backport to 7u request. Changes were pushed into jdk9 last week and 8u this week. Nightly testing is fine. Changes are applied cleanly to 7u sources. https://bugs.

Re: [7u-dev] Request for approval for 8041984: CompilerThread seems to occupy all CPU in a very rare situation

Approved. Naoto On 10/31/14, 11:39 AM, Vladimir Kozlov wrote: Backport to 7u request. Changes were pushed into jdk9 last week and 8u this week. Nightly testing is fine. Changes are applied cleanly to 7u sources. https://bugs.openjdk.java.net/browse/JDK-8041984 http://cr.openjdk.java.net/~kvn/

[7u-dev] Request for approval for 8041984: CompilerThread seems to occupy all CPU in a very rare situation

Backport to 7u request. Changes were pushed into jdk9 last week and 8u this week. Nightly testing is fine. Changes are applied cleanly to 7u sources. https://bugs.openjdk.java.net/browse/JDK-8041984 http://cr.openjdk.java.net/~kvn/8041984/webrev.01/ Review thread: http://mail.openjdk.java.net

Re: [7u-dev] Request for approval for CR 8041979 + 8041980 + 6461635

http://mail.openjdk.java.net/pipermail/jdk7u-dev/2014-October/009800.html I blame TB's "smart-reply" button. -Rob On 09/10/14 14:57, Andreas Eriksson wrote: Hi, Could someone please take a look at this? Regards, Andreas On 2014-10-02 17:49, Andreas Eriksson wrote: Hi, Requesting push

[7u-dev] Request for approval for CR 8041979 + 8041980 + 6461635

Hi, Could someone please take a look at this? Regards, Andreas On 2014-10-02 17:49, Andreas Eriksson wrote: Hi, Requesting push approval for backports of three fixes. These fixes add support for the jdk to get which directory the JVM is using as its temporary directory. This is needed for ex

Re: [7u-dev] Request for approval for CR 8041979 + 8041980 + 6461635

Approved. Please add suitable noreg labels to the bugs and please provide: - links to the review threads on mail.openjdk.java.net. - links to the JDK8 changesets in subsequent requests -Rob On 02/10/14 16:49, Andreas Eriksson wrote: Hi, Requesting push approval for backports of three fix

[7u-dev] Request for approval for CR 8041979 + 8041980 + 6461635

Hi, Requesting push approval for backports of three fixes. These fixes add support for the jdk to get which directory the JVM is using as its temporary directory. This is needed for example so that jvmstat and related tools can find local JVM processes. The changes were reviewed by Staffan Lar

Re: [7u-dev] Request for approval for 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

Thank you, Sean. Vladimir On 9/25/14 12:14 PM, Seán Coffey wrote: On 25/09/2014 20:06, Vladimir Kozlov wrote: On 9/25/14 11:49 AM, Seán Coffey wrote: Vladimir, this needs to be pushed to the jdk8u code line first. http://openjdk.java.net/projects/jdk7u/groundrules.html : Rule 1 Yes, I al

Re: [7u-dev] Request for approval for 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

On 25/09/2014 20:06, Vladimir Kozlov wrote: On 9/25/14 11:49 AM, Seán Coffey wrote: Vladimir, this needs to be pushed to the jdk8u code line first. http://openjdk.java.net/projects/jdk7u/groundrules.html : Rule 1 Yes, I also sent the request to hotspot-dev (since it is Hotspot changes) for

Re: [7u-dev] Request for approval for 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

On 9/25/14 11:49 AM, Seán Coffey wrote: Vladimir, this needs to be pushed to the jdk8u code line first. http://openjdk.java.net/projects/jdk7u/groundrules.html : Rule 1 Yes, I also sent the request to hotspot-dev (since it is Hotspot changes) for backport to 8u40. Can I push to 7u after I p

Re: [7u-dev] Request for approval for 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

Vladimir, this needs to be pushed to the jdk8u code line first. http://openjdk.java.net/projects/jdk7u/groundrules.html : Rule 1 regards, Sean. On 25/09/2014 19:42, Vladimir Kozlov wrote: Backport request. Changes was pushed into jdk9 week ago. Nighties are fine. Changes are applied cleanly.

[7u-dev] Request for approval for 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

Backport request. Changes was pushed into jdk9 week ago. Nighties are fine. Changes are applied cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8050022 jdk9 webrev: http://cr.openjdk.java.net/~morris/JDK-8050022.05 Review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev

Re: [7u-dev] Request for approval for 8058936 hotspot/test/Makefile should use jtreg script from $JT_HOME/bin/jreg (instead of $JT_HOME/win32/bin/jtreg)

Approved. Please add a noreg- label. regards, Sean. On 24/09/14 11:48, Staffan Larsen wrote: Please approve this backport from 9 and 8u. The fix applies cleanly. bug: https://bugs.openjdk.java.net/browse/JDK-8058936 jdk9 changeset: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/01961999c58a

[7u-dev] Request for approval for 8058936 hotspot/test/Makefile should use jtreg script from $JT_HOME/bin/jreg (instead of $JT_HOME/win32/bin/jtreg)

Please approve this backport from 9 and 8u. The fix applies cleanly. bug: https://bugs.openjdk.java.net/browse/JDK-8058936 jdk9 changeset: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/01961999c58a review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-September/015409.html T

Re: [7u-dev] Request for approval for JDK-8043610: Sorting columns in JFileChooser fails with AppContext NPE

Seán and Dalibor, thank you for approval. Anthony and Alexander, thank you for review. Regards, Alexey. On 20.08.2014 18:10, Seán Coffey wrote: Approved. regards, Sean. On 20/08/14 14:44, Anthony Petrov wrote: Looks fine. +1 -- best regards, Anthony On 8/20/2014 5:35 PM, Alexey Ivanov wrot

Re: [7u-dev] Request for approval for JDK-8043610: Sorting columns in JFileChooser fails with AppContext NPE

Approved for jdk7u-dev. cheers, dalibor topic On 20.08.2014 15:35, Alexey Ivanov wrote: Hello, Please approve the backport of the fix to jdk7u-dev. I replaced lambda expressions and method reference with anonymous classes: webrev: http://cr.openjdk.java.net/~aivanov/8043610/jdk7/webrev.

Re: [7u-dev] Request for approval for JDK-8043610: Sorting columns in JFileChooser fails with AppContext NPE

The fix looks good to me. Thanks, Alexandr. On 8/20/2014 5:35 PM, Alexey Ivanov wrote: Hello, Please approve the backport of the fix to jdk7u-dev. I replaced lambda expressions and method reference with anonymous classes: webrev: http://cr.openjdk.java.net/~aivanov/8043610/jdk7/

Re: [7u-dev] Request for approval for JDK-8043610: Sorting columns in JFileChooser fails with AppContext NPE

Approved. regards, Sean. On 20/08/14 14:44, Anthony Petrov wrote: Looks fine. +1 -- best regards, Anthony On 8/20/2014 5:35 PM, Alexey Ivanov wrote: Hello, Please approve the backport of the fix to jdk7u-dev. I replaced lambda expressions and method reference with anonymous classes:

Re: [7u-dev] Request for approval for JDK-8043610: Sorting columns in JFileChooser fails with AppContext NPE

Looks fine. +1 -- best regards, Anthony On 8/20/2014 5:35 PM, Alexey Ivanov wrote: Hello, Please approve the backport of the fix to jdk7u-dev. I replaced lambda expressions and method reference with anonymous classes: webrev: http://cr.openjdk.java.net/~aivanov/8043610/jdk7/webrev.00/

[7u-dev] Request for approval for JDK-8043610: Sorting columns in JFileChooser fails with AppContext NPE

Hello, Please approve the backport of the fix to jdk7u-dev. I replaced lambda expressions and method reference with anonymous classes: webrev: http://cr.openjdk.java.net/~aivanov/8043610/jdk7/webrev.00/ AWT and Swing teams, Could you please review the backport? JBS bug: https://bugs.ope

Re: [7u-dev] Request for approval for JDK-8044406: JVM crash with JDK8 (build 1.8.0-b132) with G1 GC

Thanks, Poonam - approved for jdk7u-dev. cheers, dalibor topic On 19.08.2014 12:40, Poonam Bajaj wrote: Hello, Could I get approval for the backport of the fix to jdk7u-dev. Bug: JDK-8044406 : JVM crash with JDK8 (build 1.8.0-b132) with G1 GC

[7u-dev] Request for approval for JDK-8044406: JVM crash with JDK8 (build 1.8.0-b132) with G1 GC

Hello, Could I get approval for the backport of the fix to jdk7u-dev. Bug: JDK-8044406 : JVM crash with JDK8 (build 1.8.0-b132) with G1 GC Webrev: http://cr.openjdk.java.net/~poonam/8044406/webrev.01/ Code review: http://mail.openjdk.java.net/

Re: [7u-dev] Request for approval for JDK-8046007: Java app receives javax.print.PrintException: Printer is not accepting

Thank you, Rob! Regards, Alexey. On 15.08.2014 16:37, Rob McKenna wrote: Approved. -Rob On 15/08/14 13:21, Alexey Ivanov wrote: Hello, Please approve the backport of the fix to jdk7u-dev. The fix is the same, only copyright header needed updating: webrev: http://cr.openjdk.ja

Re: [7u-dev] Request for approval for JDK-8046007: Java app receives javax.print.PrintException: Printer is not accepting

Approved. -Rob On 15/08/14 13:21, Alexey Ivanov wrote: Hello, Please approve the backport of the fix to jdk7u-dev. The fix is the same, only copyright header needed updating: webrev: http://cr.openjdk.java.net/~aivanov/8046007/jdk7/webrev.00/ Bug: https://bugs.openjdk.java.net

[7u-dev] Request for approval for JDK-8046007: Java app receives javax.print.PrintException: Printer is not accepting

Hello, Please approve the backport of the fix to jdk7u-dev. The fix is the same, only copyright header needed updating: webrev: http://cr.openjdk.java.net/~aivanov/8046007/jdk7/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8046007 JDK9 changeset: http://hg.openjdk.java.net/j

Re: [7u-dev] Request for approval for CR 8001472: [linux-sparc] api/java_awt/Window/indexTGF_* tests fail because expected colors aren't equal

Approved. regards, Sean. On 15/08/2014 09:04, Anton Litvinov wrote: Hello, I would like to request for approval to push a straight backport of the fix from JDK 8 to JDK 7. The original JDK 8 changeset will be imported into JDK 7. Please note that the author of the fix Sergey Bylokhov, and

[7u-dev] Request for approval for CR 8001472: [linux-sparc] api/java_awt/Window/indexTGF_* tests fail because expected colors aren't equal

Hello, I would like to request for approval to push a straight backport of the fix from JDK 8 to JDK 7. The original JDK 8 changeset will be imported into JDK 7. Please note that the author of the fix Sergey Bylokhov, and both reviewers Anthony Petrov, Alexander Zvegintsev are added to Cc: o

Re: [7u-dev] Request for approval for CR 8052159: TEST_BUG: javax/swing/JTextField/8036819/bug8036819.java fails to compile

Thanks, Vivi - approved for jdk7u-dev. cheers, dalibor topic On 07.08.2014 19:05, Vivi An wrote: Hello. This is a request for approval of push of the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8052159 Webrev: http://cr.openjdk.java.net/~dmarkov/8052159/jdk7u/webrev.00 Reviewe

[7u-dev] Request for approval for CR 8052159: TEST_BUG: javax/swing/JTextField/8036819/bug8036819.java fails to compile

Hello. This is a request for approval of push of the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8052159 Webrev: http://cr.openjdk.java.net/~dmarkov/8052159/jdk7u/webrev.00 Reviewer's approval 1: http://mail.openjdk.java.net/pipermail/jdk7u-dev/2014-July/009472.html Reviewer's a

Re: [7u-dev] Request for approval for 8049542: C2: assert(size_in_words <= (julong)max_jint) failed: no overflow

Thank you, Seán Vladimir On 8/5/14 12:32 PM, Seán Coffey wrote: Approved. regards, Sean. On 05/08/2014 19:28, Vladimir Kozlov wrote: Sorry about webrev. Here is correct one: http://cr.openjdk.java.net/~kvn/8049252_7u/webrev It fixes the problem we have with the version of gcc compiler on o

Re: [7u-dev] Request for approval for 8049542: C2: assert(size_in_words <= (julong)max_jint) failed: no overflow

Approved. regards, Sean. On 05/08/2014 19:28, Vladimir Kozlov wrote: Sorry about webrev. Here is correct one: http://cr.openjdk.java.net/~kvn/8049252_7u/webrev It fixes the problem we have with the version of gcc compiler on one of our platforms. Sign-extension instruction is not generated a

Re: [7u-dev] Request for approval for 8049542: C2: assert(size_in_words <= (julong)max_jint) failed: no overflow

Sorry about webrev. Here is correct one: http://cr.openjdk.java.net/~kvn/8049252_7u/webrev It fixes the problem we have with the version of gcc compiler on one of our platforms. Sign-extension instruction is not generated and as result the assert is triggered due to garbage in upper bits. The

Re: [7u-dev] Request for approval for 8049542: C2: assert(size_in_words <= (julong)max_jint) failed: no overflow

Vladimir, the bug report is not public. Can you give a brief overview of what's being fixed and/or point to review thread. Rule 9 : http://openjdk.java.net/projects/jdk7u/groundrules.html The webrev link doesn't work also. regards, Sean. On 05/08/2014 01:07, Vladimir Kozlov wrote: Requesting

[7u-dev] Request for approval for 8049542: C2: assert(size_in_words <= (julong)max_jint) failed: no overflow

Requesting push approval for JDK-8049542. It is only needed in 7u. Changes were reviewed and tested. https://bugs.openjdk.java.net/browse/JDK-8049542 http://cr.openjdk.java.net/~kvn/webrevs/8049252_7u/webrev Thanks, Vladimir

Re: [7u-dev] Request for approval for CR JDK-8048271 - Minor GC times doubled from JDK 6u35 to JDK 7u51

Poonam, I'm assuming this issue is not applicable for JDK8. Please add the 8-na label to bug report if so. Approved. regards, Sean. On 17/07/2014 09:51, Poonam Bajaj wrote: Bug: JDK-8048271 : Minor GC times doubled from JDK 6u35 to JDK 7u51

[7u-dev] Request for approval for CR JDK-8048271 - Minor GC times doubled from JDK 6u35 to JDK 7u51

Bug: JDK-8048271 : Minor GC times doubled from JDK 6u35 to JDK 7u51 Webrev: http://cr.openjdk.java.net/~poonam/8048271/webrev.00/ Reviewed By: Jon Masamitsu, Kevin Walls Testing: Manual Testing and JPRT Thanks, Poonam

Re: [7u-dev] Request for approval for JDK-8046559: NPE when changing Windows theme

Approved. -Rob On 15/07/14 12:44, Alexey Ivanov wrote: Hello, Please approve the backport of JDK-8046559 fix to jdk7u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8046559 JDK9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/ff2112f3ae6b JDK8 changeset: http://hg.openjdk.

[7u-dev] Request for approval for JDK-8046559: NPE when changing Windows theme

Hello, Please approve the backport of JDK-8046559 fix to jdk7u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8046559 JDK9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/ff2112f3ae6b JDK8 changeset: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/790008bce87d Backport requir

Re: [7u-dev] Request for approval for the backport of fixes of 8031290 and 8019324

Approved. regards, Sean. On 02/07/14 09:44, Poonam Bajaj wrote: Requesting approval for the backport of the following two fixes: Bugs: JDK-8031290: Adjust call to getisax() for additional words returned JDK-8019324:

[7u-dev] Request for approval for the backport of fixes of 8031290 and 8019324

Requesting approval for the backport of the following two fixes: Bugs: JDK-8031290: Adjust call to getisax() for additional words returned JDK-8019324: assert(_f2 == 0 || _f2 == f2) failed: ill

Re: [7u-dev] Request for approval for 8046769: Set T family feature bit on Niagara systems

Approved. Please add a suitable noreg- label to bug report. regards, Sean. On 01/07/14 19:31, Mikael Vidstedt wrote: Requesting push approval for JDK-8046769. This fix has already gone into both 9 and 8u40 and applies cleanly to 7u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8046769

[7u-dev] Request for approval for 8046769: Set T family feature bit on Niagara systems

Requesting push approval for JDK-8046769. This fix has already gone into both 9 and 8u40 and applies cleanly to 7u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8046769 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8046769-7u/webrev.00/webrev/ Review: http://mail.openjdk.java.net/p

Re: [7u-dev] Request for approval for 8043206: Fix signed vs. unsigned comparison warning in copy_sparc.hpp

Approved. regards, Sean. On 03/06/2014 01:40, Mikael Vidstedt wrote: Requesting push approval for JDK-8043206. This fix has already gone into both 9 and 8u20 and applies cleanly to 7u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8043206 Webrev: http://cr.openjdk.java.net/~mikael/webr

[7u-dev] Request for approval for 8043206: Fix signed vs. unsigned comparison warning in copy_sparc.hpp

Requesting push approval for JDK-8043206. This fix has already gone into both 9 and 8u20 and applies cleanly to 7u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8043206 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8043206-7u/webrev.00/webrev/ Review: http://mail.openjdk.java.net

Re: [7u-dev] Request for approval for 8043205: Incorrect system traps.h include path

Approved. regards, Sean. On 29/05/2014 20:46, Mikael Vidstedt wrote: Requesting push approval for JDK-8043205. Note that the fix does not apply to jdk8 and later. Bug: https://bugs.openjdk.java.net/browse/JDK-8043205 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8043205/webrev.00/webr

Re: [7u-dev] Request for approval for 8043207: Add const to Address argument for Assembler::swap

Approved. regards, Sean. On 29/05/2014 21:33, Mikael Vidstedt wrote: Requesting push approval for JDK-8043207. Note that the fix does not apply to jdk8 and later. Bug: https://bugs.openjdk.java.net/browse/JDK-8043207 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8043207/webrev.00/webr

[7u-dev] Request for approval for 8043207: Add const to Address argument for Assembler::swap

Requesting push approval for JDK-8043207. Note that the fix does not apply to jdk8 and later. Bug: https://bugs.openjdk.java.net/browse/JDK-8043207 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8043207/webrev.00/webrev/ Review: http://mail.openjdk.java.net/pipermail/hotspot-compiler-d

[7u-dev] Request for approval for 8043205: Incorrect system traps.h include path

Requesting push approval for JDK-8043205. Note that the fix does not apply to jdk8 and later. Bug: https://bugs.openjdk.java.net/browse/JDK-8043205 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8043205/webrev.00/webrev/ Review: http://mail.openjdk.java.net/pipermail/hotspot-runtime-de

Re: [7u-dev] Request for approval for 8042059: Various fixes to linux/sparc

Approved. Again, please add the appropriate noreg- label. (noreg-build) regards, Sean. On 27/05/2014 23:00, Mikael Vidstedt wrote: Requesting push approval for JDK-8042059. This fix has already gone into both 9 and 8u20 and applies cleanly to 7u-dev. Bug: https://bugs.openjdk.java.net/brows

Re: [7u-dev] Request for approval for 8022070: Compilation error in stubGenerator_sparc.cpp with some compilers

Approved. Please add an appropriate noreg- label. regards, Sean. On 27/05/2014 22:58, Mikael Vidstedt wrote: Requesting push approval for JDK-8022070. This fix has already gone into both 9 and 8u20 and applies cleanly to 7u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8022070 Webrev:

[7u-dev] Request for approval for 8042059: Various fixes to linux/sparc

Requesting push approval for JDK-8042059. This fix has already gone into both 9 and 8u20 and applies cleanly to 7u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8042059 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8042059-7udev/webrev.00/webrev/ Review: http://mail.openjdk.java.

[7u-dev] Request for approval for 8022070: Compilation error in stubGenerator_sparc.cpp with some compilers

Requesting push approval for JDK-8022070. This fix has already gone into both 9 and 8u20 and applies cleanly to 7u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8022070 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8022070-7udev/webrev.00/webrev/ Review: http://mail.openjdk.java.

Re: [7u-dev] Request for approval for CR 8039042 - G1: Phantom zeros in cardtable

Approved. regards, Sean. On 27/05/2014 12:20, Per Liden wrote: Hi, Requesting push approval for JDK-8039042. This fix has already gone into both 9 and 8u20 and applies cleanly to 7u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8039042 Webrev: http://cr.openjdk.java.net/~pliden/803904

[7u-dev] Request for approval for CR 8039042 - G1: Phantom zeros in cardtable

Hi, Requesting push approval for JDK-8039042. This fix has already gone into both 9 and 8u20 and applies cleanly to 7u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8039042 Webrev: http://cr.openjdk.java.net/~pliden/8039042/webrev.0/ Review: http://mail.openjdk.java.net/pipermail/hotsp

Re: [7u-dev] Request for approval for CR 8038925 - Java with G1 crashes in dump_instance_fields using jmap or jcmd without fullgc

Approved. regards, Sean. On 23/05/14 12:27, Andreas Eriksson wrote: Hi, Requesting push approval for JDK-8038925 , a jdk7 only fix. It has been reviewed by Bengt Rutisson and Mikael Gerdin. Bug: https://bugs.openjdk.java.net/browse/JDK-80389

Re: [7u-dev] Request for approval for CR 7160604: Using non-opaque windows - popups are initially not painted correctly

Hello Sean, Thank you for approval of this request to push. Alexander Scherbatiy the reviewer of the original fix has approved this backport fix at "awt-dev" alias. Reviewer approval - http://mail.openjdk.java.net/pipermail/awt-dev/2014-May/007869.html Thank you, Anton On 5/23/2014 2:23 P

[7u-dev] Request for approval for CR 8038925 - Java with G1 crashes in dump_instance_fields using jmap or jcmd without fullgc

Hi, Requesting push approval for JDK-8038925 , a jdk7 only fix. It has been reviewed by Bengt Rutisson and Mikael Gerdin. Bug: https://bugs.openjdk.java.net/browse/JDK-8038925 Webrev: http://cr.openjdk.java.net/~aeriksso/8038925/webrev.03/ Reg

  1   2   3   4   >