Re: Review request for JDK-8016767: Provide man pages generated from DARB for OpenJDK

2013-07-19 Thread Joe Darcy
On 07/19/2013 03:39 PM, Stuart Marks wrote: Hi Alexey, The new man pages are a big improvement over the previous ones. There are still a number of formatting issues that need to be corrected, but these can be postponed until later, as I understand the difficulties of trying to fix up the tool

Re: Review request for JDK-8016767: Provide man pages generated from DARB for OpenJDK

2013-07-19 Thread Stuart Marks
Hi Alexey, The new man pages are a big improvement over the previous ones. There are still a number of formatting issues that need to be corrected, but these can be postponed until later, as I understand the difficulties of trying to fix up the toolchain under a release deadline. I think I m

Re: Review request for JDK-8016767: Provide man pages generated from DARB for OpenJDK

2013-07-19 Thread alexey zhebel
Hi Dalibor! I will add the fixes to the content manually before the push without sending out another webrev. Thanks for your feedback, I will initiate a phase 2 approval request. Best regards, Alexey Zhebel On 18.07.2013 18:32, Dalibor Topic wrote: On 7/18/13 4:10 PM, alexey zhebel wrote:

Re: Review request for JDK-8016767: Provide man pages generated from DARB for OpenJDK

2013-07-19 Thread alexey zhebel
Hi Dalibor! We will not make small fixes to the 7u40 man pages. We value any feedback, but unless it's a showstopper, we defer it to a later release. Best regards, Alexey Zhebel On 18.07.2013 18:32, Dalibor Topic wrote: On 7/18/13 4:10 PM, alexey zhebel wrote: What's the reason for that cha

Re: Review request for JDK-8016767: Provide man pages generated from DARB for OpenJDK

2013-07-18 Thread Dalibor Topic
On 7/18/13 4:10 PM, alexey zhebel wrote: >> What's the reason for that change? > There was some confusion in terminology, but according to /java -version/, it > was correct in the first place. This will be fixed in the man pages for JDK > 8. So will the typo below. OK, thanks. Just to be clear -

Re: Review request for JDK-8016767: Provide man pages generated from DARB for OpenJDK

2013-07-18 Thread alexey zhebel
Hi Dalibor! See inline. Best regards, Alexey Zhebel On 18.07.2013 17:24, Dalibor Topic wrote: On 7/18/13 12:46 PM, alexey zhebel wrote: Thanks to Mikael, Joe, and Stuart for the previous reviews and feedback! We generated the fixed versions of the two man pages (java and jcmd). The copyright

Re: Review request for JDK-8016767: Provide man pages generated from DARB for OpenJDK

2013-07-18 Thread Dalibor Topic
On 7/18/13 12:46 PM, alexey zhebel wrote: > Thanks to Mikael, Joe, and Stuart for the previous reviews and feedback! > > We generated the fixed versions of the two man pages (java and jcmd). The > copyright and license text has been corrected and several formatting issues > have been fixed. Due

Review request for JDK-8016767: Provide man pages generated from DARB for OpenJDK

2013-07-18 Thread alexey zhebel
Thanks to Mikael, Joe, and Stuart for the previous reviews and feedback! We generated the fixed versions of the two man pages (java and jcmd). The copyright and license text has been corrected and several formatting issues have been fixed. Due to constraints within the tool chain and release d