[7u8] Request for approval: 7152948: DatagramDispatcher.c should memset msghdr to make it portable to other platforms

2012-08-02 Thread Shi Jun Zhang
Hi all, I'd like to request for approval to push the following change into 7u8. Changeset in jdk8 http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68efc74309f9 Webrev http://cr.openjdk.java.net/~zhangshj/jdk7u/7152948/webrev.00/ Reviewed by Alan Bateman, Chris Hegarty Review thread http://mail.open

[7u8] Request for approval: 7155300: Include pthread.h on all POSIX platforms except Solaris to improve portability

2012-08-02 Thread Shi Jun Zhang
Hi all, I'd like to request for approval to push the following change into 7u8. Changeset in jdk8 http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d418ec212ea Webrev http://cr.openjdk.java.net/~zhangshj/jdk7u/7155300/webrev.00/ Reviewed by Alan Bateman, David Holmes Review thread http://mail.openj

Re: Request for approval for 7154030 - java.awt.Component.hide() does not repaint parent component

2012-08-02 Thread Jonathan Lu
Hello Sean, From my point of view, this backport only introduces a fix for a existing bug 7154030. regards, Jonathan On 08/01/2012 12:05 AM, Seán Coffey wrote: Hi Jonathan, does this backport introduce any behavioural changes that could cause issue for an update release (as opposed to a fe

Request for approval for 7084560 Crash in net.dll

2012-08-02 Thread Jonathan Lu
Hello all, Here's a request to backport the fix of bug 7084560 for JDK7, could you please review and approve it? Bug: http://bugs.sun.com/view_bug.do?bug_id=7084560 The change set from JDK8 is also applicable to JDK7u code base http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fe205518c3a7 And he

Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c'

2012-08-02 Thread Christian Schulte
Hi, using the system property 'java.net.useSystemProxies', JDK 7 crashes on OpenBSD 5.2. $ /usr/local/jre-1.7.0/bin/java -version openjdk version "1.7.0_03" OpenJDK Runtime Environment (build 1.7.0_03-b04) OpenJDK Server VM (build 22.1-b02, mixed mode) $ /usr/local/jre-1.7.0/bin/java -cp . Cr

hg: jdk7u/jdk7u-dev/jdk: 7170996: IME composition window does not disappear when file dialog is closed : Japanese WinXP

2012-08-02 Thread neil . richards
Changeset: 446a7548357b Author:zhouyx Date: 2012-05-23 12:37 +0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/446a7548357b 7170996: IME composition window does not disappear when file dialog is closed : Japanese WinXP Reviewed-by: art, bagiras ! src/windows/native/sun

Re: Request for approval: 7170996: IME composition window does not disappear when file dialog is closed

2012-08-02 Thread Neil Richards
Now pushed to jdk7u-dev [1]. Regards, Neil [1] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/446a7548357b On Tue, 2012-07-31 at 09:07 -0700, Seán Coffey wrote: > Approved for 7u-dev. I've created a 7u8 bug record and will update when > I see your push. > > regards, > Sean. > > On 31/07/2

Re: Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c'

2012-08-02 Thread David Holmes
Hi Christian, Probably best to discuss this on the net-...@openjdk.java.net list (cc'd). Two comments from me (I'm not on net-dev): 1. CHECK_NULL does a return so you will be leaving the monitor locked if you encounter any nulls. 2. Is it simpler to add synchronization at the Java level? (I

Re: [7u8] Request for approval: 7113017: Use POSIX compliant include file headers in sun/awt/medialib/mlib_types.h

2012-08-02 Thread Phil Race
Edvard, This change to 7u8 needs to be reverted. We have a probable fix to this bad fix for JDK 8, but we can't afford to be debugging unnecessary changes in the 7ux train. -phil. On 7/31/2012 12:52 PM, Phil Race wrote: I didn't notice this request before due to being extremely busy, but it sh

Re: Request for approval for 7154030 - java.awt.Component.hide() does not repaint parent component

2012-08-02 Thread Seán Coffey
Jonathan, A bug fix can introduce behavioural changes which should not be allowed in update releases. In fact, I've just noticed that this fix caused issue in JCK verification for JDK 8. See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168144 which is linked to 7154030 I think you m

Re: [7u8] Request for approval: 7152948: DatagramDispatcher.c should memset msghdr to make it portable to other platforms

2012-08-02 Thread Seán Coffey
Approved for 7u-dev. I've created a jdk7u8 bug record and will update once I see the fix pushed. regards, Sean. On 02/08/2012 08:10, Shi Jun Zhang wrote: Hi all, I'd like to request for approval to push the following change into 7u8. Changeset in jdk8 http://hg.openjdk.java.net/jdk8/tl/jdk/r

Re: [7u8] Request for approval: 7155300: Include pthread.h on all POSIX platforms except Solaris to improve portability

2012-08-02 Thread Seán Coffey
Approved for 7u-dev. I've created a jdk7u8 bug record and will update once I see the fix pushed. regards, Sean. On 02/08/2012 08:14, Shi Jun Zhang wrote: Hi all, I'd like to request for approval to push the following change into 7u8. Changeset in jdk8 http://hg.openjdk.java.net/jdk8/tl/jdk/r

Re: Request for approval for 7084560 Crash in net.dll

2012-08-02 Thread Seán Coffey
Approved for 7u-dev. I've created a jdk7u8 bug record and will update once I see the fix pushed. regards, Sean On 02/08/2012 09:24, Jonathan Lu wrote: Hello all, Here's a request to backport the fix of bug 7084560 for JDK7, could you please review and approve it? Bug: http://bugs.sun.com/v

Re: Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c'

2012-08-02 Thread Chris Hegarty
Thanks for the cross post David. Yes, net-dev is the best place to discuss this issue ( bcc'ing off jdk7u-dev ). Thanks for reporting this issue Christian. I haven't looked at the proposed patch yet, but I agree we may want to simplify this if possible ( handling the synchronization at the Jav

Possible atomicity violations when composing concurrent collections operations

2012-08-02 Thread Yu Lin
My name is Yu Lin. I'm a Ph.D. student in the CS department at UIUC. I'm currently doing research on mining Java concurrent library misuses. I found some uses of concurrent collections in OpenJDK7u may result in potential atomicity violation bugs or harm the performance. The code below is a snapsh

Re: Possible atomicity violations when composing concurrent collections operations

2012-08-02 Thread Phil Race
On 8/2/2012 11:52 AM, Yu Lin wrote: My name is Yu Lin. I'm a Ph.D. student in the CS department at UIUC. I'm currently doing research on mining Java concurrent library misuses. I found some uses of concurrent collections in OpenJDK7u may result in potential atomicity violation bugs or harm the pe

Re: Possible atomicity violations when composing concurrent collections operations

2012-08-02 Thread Yu Lin
2012/8/2 Phil Race : > On 8/2/2012 11:52 AM, Yu Lin wrote: > > I haven't looked at the rest but I'll comment on that one. > This is deliberate. The tradeoff is all uses being synchronized versus > the small chance that two threads try to create this map at the same > time, which really doesn't matt

Re: Possible atomicity violations when composing concurrent collections operations

2012-08-02 Thread Dalibor Topic
On 8/2/12 11:35 PM, Yu Lin wrote: >> Finally jdk8-dev is probably the "main" list these days. >> > > Should I post this issue to the mailing list of jdk8-dev? Yes. -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle

hg: jdk7u/jdk7u-dev: Added tag jdk7u8-b01 for changeset 1ab3edf5061f

2012-08-02 Thread lana . steuck
Changeset: d7a94c8cbbbf Author:katleman Date: 2012-07-31 10:40 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/rev/d7a94c8cbbbf Added tag jdk7u8-b01 for changeset 1ab3edf5061f ! .hgtags

hg: jdk7u/jdk7u-dev/corba: Added tag jdk7u8-b01 for changeset 353c15c4bc37

2012-08-02 Thread lana . steuck
Changeset: d17ca8d088f7 Author:katleman Date: 2012-07-31 10:41 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/corba/rev/d17ca8d088f7 Added tag jdk7u8-b01 for changeset 353c15c4bc37 ! .hgtags

hg: jdk7u/jdk7u-dev/hotspot: Added tag jdk7u8-b01 for changeset 02a6c89432d7

2012-08-02 Thread lana . steuck
Changeset: 528502f93096 Author:katleman Date: 2012-07-31 10:41 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/528502f93096 Added tag jdk7u8-b01 for changeset 02a6c89432d7 ! .hgtags

hg: jdk7u/jdk7u-dev/jaxp: Added tag jdk7u8-b01 for changeset 1365e7472a3b

2012-08-02 Thread lana . steuck
Changeset: 0a313d430793 Author:katleman Date: 2012-07-31 10:42 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/0a313d430793 Added tag jdk7u8-b01 for changeset 1365e7472a3b ! .hgtags

hg: jdk7u/jdk7u-dev/jaxws: Added tag jdk7u8-b01 for changeset 55dcda93e8c8

2012-08-02 Thread lana . steuck
Changeset: c025e953f655 Author:katleman Date: 2012-07-31 10:43 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxws/rev/c025e953f655 Added tag jdk7u8-b01 for changeset 55dcda93e8c8 ! .hgtags

hg: jdk7u/jdk7u-dev/langtools: Added tag jdk7u8-b01 for changeset a35ca56cf8d0

2012-08-02 Thread lana . steuck
Changeset: 41bc8da868e5 Author:katleman Date: 2012-07-31 10:45 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/41bc8da868e5 Added tag jdk7u8-b01 for changeset a35ca56cf8d0 ! .hgtags

hg: jdk7u/jdk7u-dev/jdk: 2 new changesets

2012-08-02 Thread lana . steuck
Changeset: dd1e513c05b8 Author:katleman Date: 2012-07-31 10:43 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/dd1e513c05b8 Added tag jdk7u8-b01 for changeset df945ef30444 ! .hgtags Changeset: 91aef25d0bc1 Author:lana Date: 2012-08-02 16:18 -0700 URL:

Re: Request for approval: 7170996: IME composition window does not disappear when file dialog is closed

2012-08-02 Thread Sean Chou
Thanks Neil. On Thu, Aug 2, 2012 at 7:15 PM, Neil Richards wrote: > Now pushed to jdk7u-dev [1]. > > Regards, > Neil > > [1] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/446a7548357b > > On Tue, 2012-07-31 at 09:07 -0700, Seán Coffey wrote: > > Approved for 7u-dev. I've created a 7u8 bug re

hg: jdk7u/jdk7u6-dev/corba: 2 new changesets

2012-08-02 Thread lana . steuck
Changeset: 793b80c0316f Author:cl Date: 2012-07-27 16:13 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u6-dev/corba/rev/793b80c0316f Added tag jdk7u6-b21 for changeset 353c15c4bc37 ! .hgtags Changeset: 2a8376123fbb Author:katleman Date: 2012-08-01 19:32 -0700 URL:

hg: jdk7u/jdk7u6-dev: 2 new changesets

2012-08-02 Thread lana . steuck
Changeset: 31cdab09d719 Author:cl Date: 2012-07-27 16:13 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u6-dev/rev/31cdab09d719 Added tag jdk7u6-b21 for changeset 29f6fb1833eb ! .hgtags Changeset: d1c709f1196a Author:katleman Date: 2012-08-01 19:32 -0700 URL: http:

hg: jdk7u/jdk7u6-dev/jaxp: 2 new changesets

2012-08-02 Thread lana . steuck
Changeset: fcf35906d1d8 Author:cl Date: 2012-07-27 16:14 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u6-dev/jaxp/rev/fcf35906d1d8 Added tag jdk7u6-b21 for changeset 7403701aa758 ! .hgtags Changeset: 8824bcbfd7cd Author:katleman Date: 2012-08-01 19:33 -0700 URL:

hg: jdk7u/jdk7u6-dev/jaxws: 2 new changesets

2012-08-02 Thread lana . steuck
Changeset: 0fec2efe2452 Author:cl Date: 2012-07-27 16:14 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u6-dev/jaxws/rev/0fec2efe2452 Added tag jdk7u6-b21 for changeset 55dcda93e8c8 ! .hgtags Changeset: afb6d773328f Author:katleman Date: 2012-08-01 19:33 -0700 URL:

hg: jdk7u/jdk7u6-dev/hotspot: 2 new changesets

2012-08-02 Thread lana . steuck
Changeset: a79d86eef6ac Author:cl Date: 2012-07-27 16:14 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u6-dev/hotspot/rev/a79d86eef6ac Added tag jdk7u6-b21 for changeset 02a6c89432d7 ! .hgtags Changeset: df57f6208cb7 Author:katleman Date: 2012-08-01 19:32 -0700 URL:

hg: jdk7u/jdk7u6-dev/langtools: 2 new changesets

2012-08-02 Thread lana . steuck
Changeset: 4f3aafa690d1 Author:cl Date: 2012-07-27 16:15 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u6-dev/langtools/rev/4f3aafa690d1 Added tag jdk7u6-b21 for changeset a35ca56cf8d0 ! .hgtags Changeset: dd3e29d8892f Author:katleman Date: 2012-08-01 19:33 -0700 URL:

hg: jdk7u/jdk7u6-dev/jdk: 3 new changesets

2012-08-02 Thread lana . steuck
Changeset: 6173fdbaf945 Author:cl Date: 2012-07-27 16:14 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u6-dev/jdk/rev/6173fdbaf945 Added tag jdk7u6-b21 for changeset 243717d7fe95 ! .hgtags Changeset: d78f2b600d39 Author:lana Date: 2012-07-30 14:24 -0700 URL: http: