Re: CFV: New jdk8 Reviewer: Daniel Fuchs

2013-10-30 Thread Lance Andersen - Oracle
vote: yes On Oct 30, 2013, at 11:44 AM, Alan Bateman wrote: > > I hereby nominate Daniel Fuchs to jdk8 Reviewer. > > Daniel is on his second tour of duty in Oracle's JDK team. Those on jmx-dev > will remember Daniel from the early years of OpenJDK when he was contributing > changes to JMX. He

Re: RFR: 8022746: List of spelling errors in API doc

2013-10-22 Thread Lance Andersen - Oracle
pabilities such as output XML stream capabilities can implement this > * interface to provider standard XmlWriter objects to > * WebRowSet implementations. > > > Should I fix them too? > > ... to provide ... > > Regards, > SAM > > On 22.10.2013 19:39, Lance An

Re: RFR: 8022746: List of spelling errors in API doc

2013-10-22 Thread Lance Andersen - Oracle
First, thank you for doing this. I went through all of the JDBC/RowSet diffs. They all look good but I found one other error that the spell checker missed in one of the lines you changed http://cr.openjdk.java.net/~malenkov/8022746.8.0/jdk/src/share/classes/com/sun/rowset/package.html.sdiff.ht

Re: CFV: New JDK 8 Reviewer: Seán Coffey

2013-10-09 Thread Lance Andersen - Oracle
Vote: yes > > On Oct 9 2013, at 11:51 , Chris Hegarty wrote: > >> I hereby nominate Seán Coffey (coffeys) to JDK 8 Reviewer. >> >> Seán has worked in the core libraries and networking area since before the >> beginning of OpenJDK. Seán is probably best known for his role as 7u >> maintainer, b

Re: CFV: New jdk8 Reviewer: Staffan Larsen

2013-10-02 Thread Lance Andersen - Oracle
Vote: yes On 10/ 1/13 10:13 PM, Alan Bateman wrote: > I hereby nominate Staffan Larsen to jdk8 Reviewer. Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com

Re: CFV: New jdk8 Committer: Peter Levart

2013-08-07 Thread Lance Andersen - Oracle
vote: yes On Aug 4, 2013, at 10:51 PM, Alan Bateman wrote: > > I hereby nominate Peter Levart to jdk8 Committer. > > Those on core-libs-dev or lambda-dev will know Peter from his regular > contributions and review comments. Peter has contributed or co-contributed > more than 8 significant chan

Re: CFV: New JDK8 Committer: Roger Riggs

2013-07-29 Thread Lance Andersen - Oracle
Vote: yes On Jul 29, 2013, at 5:21 PM, Xueming Shen wrote: > I hereby nominate Roger Riggs to JDK8 Committer. > > Roger Riggs has contributed 8 patches to the JDK 8 repositories. Roger > is the co-spec lead of the JSR310 and one of the main code contributors > of jdk8 JSR310 project. > > http:/

Re: Review request: JDK8 b98 source with GPL header errors

2013-07-11 Thread Lance Andersen - Oracle
looks fine On Jul 11, 2013, at 3:18 PM, David Katleman wrote: > Below are corrections to GPL headers errors found in JDK8 b98 > >http://cr.openjdk.java.net/~katleman/8020414/webrev/ > > All are GPL header formatting issues, no code is involved, anyone can review. > > No simple missing c

Re: Review request: JDK8 b96 source with GPL header errors

2013-06-28 Thread Lance Andersen - Oracle
Looks fine Dave On Jun 27, 2013, at 9:20 PM, David Katleman wrote: > Below are corrections to GPL headers errrors found in JDK8 b96 > >http://cr.openjdk.java.net/~katleman/8019347/webrev/ > > Lion share are the recent jaxb update > > All are punctuation issues, no code is involved, anyone c

Re: Review request: JDK8 b91 source with GPL header errors

2013-05-29 Thread Lance Andersen - Oracle
looks fine Dave -lance On May 28, 2013, at 9:35 PM, David Katleman wrote: > Below are corrections to GPL headers found in JDK8 b91 > >http://cr.openjdk.java.net/~katleman/8015525/webrev > > All are punctuation issues, no code is involved, anyone can review. > > As a veteran of many such he

Re: CFV: New jdk8 Committer: Paul Sandoz

2013-05-08 Thread Lance Andersen - Oracle
vote: yes On May 8, 2013, at 12:11 PM, Alan Bateman wrote: > I hereby nominate Paul Sandoz to jdk8 Committer. > > Everyone following the Lambda and JSR-335 effort will recognize Paul. He has > been a key contributor to the streams API and implementation, the spliterator > API, the extensive tes

Re: CFV: New JDK8 Committer: David Buck

2013-01-11 Thread Lance Andersen - Oracle
vote: yes On Jan 11, 2013, at 8:15 AM, Alexander Potochkin wrote: > I hereby nominate David Buck to jdk8 Committer. > > Buck has been a member of the Java SE sustaining team for two years now. > He has spent most of that time working on JRockit, > but is also responsible for working on client and

Re: CFV: New jdk8 Committer: Dan Xu

2013-01-10 Thread Lance Andersen - Oracle
vote: yes On Jan 10, 2013, at 9:18 AM, Alan Bateman wrote: > I hereby nominate Dan Xu to jdk8 Committer. > > Dan joined the JDK libraries team in Oracle about 6 months ago and has > contributed several changes to jdk8 so far: > > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2be39b27e1c > http://

Re: CFV: New jdk8 Reviewer: Mike Duigou

2012-11-23 Thread Lance Andersen - Oracle
Vote: yes On 11/23/2012 06:13 AM, Alan Bateman wrote: > > I hereby nominate Mike Duigou to jdk8 Reviewer. > > Mike has Committer role on the jdk8, jdk7u, jdk7 and lambda projects. Mike is > author of over 40 changes in the jdk8 forest, has sponsored several changes > from contributors, and has

Re: Warning Fixes from LJC Hack Session

2012-02-02 Thread Lance Andersen - Oracle
On Feb 2, 2012, at 5:58 AM, Michael Barker wrote: >> Michael - I skimmed through this and see a couple of API changes and a few >> methods in java.sql.Date deprecated. I'm sure Stuart will go through >> everything in detail but just to mention that some of changes may be a bit >> out of scope. >