Re: Research of informations about java.util.Random

2014-12-18 Thread Martin Buchholz
LMGTFY: Donald Knuth, The Art of Computer Programming, Volume 3, Section 3.2.1.) On Thu, Dec 18, 2014 at 12:10 AM, Damien W wrote: > Hello, > > I found on Javadoc (java.util.Random) the linear congruential generator > formula which is: > > seed = (seed * 0x5DEECE66DL + 0xBL) & ((1L << 48) - 1) >

Re: Define JNIEXPORT as visibility default with GCC?

2013-04-15 Thread Martin Buchholz
Lana was kind enough to jprt this change for me. Now submitted to tl.

Re: Define JNIEXPORT as visibility default with GCC?

2013-04-12 Thread Martin Buchholz
One more point - IIRC, the issue with JNIEXPORT being used in typedefs only generated a GCC warning, not an error, and so everything will continue to compile unless they use -Werror.

Re: java.lang.String API suggestion : make String return read-only CharBuffer

2013-04-10 Thread Martin Buchholz
It's a reasonable suggestion, although the natural signature is public CharBuffer asReadOnlyBuffer() but where do you stop? What about public List asReadOnlyList() On Thu, Apr 4, 2013 at 7:40 PM, Eugene Chung(정의근) wrote: > Hello, Java SE 8 EG. > > > I'm a member of TmaxSoft, which is making

Re: Define JNIEXPORT as visibility default with GCC?

2013-04-10 Thread Martin Buchholz
On Wed, Apr 10, 2013 at 1:45 AM, Anthony Petrov wrote: > I totally agree that the current usage of JNIEXPORT in typedefs in AWT and > 2D code is a bug. > > My concern, however, is about other code that mistakenly adapted the same > pattern. After this fix its compilation will fail. > Yup. Any co

Re: Define JNIEXPORT as visibility default with GCC?

2013-04-09 Thread Martin Buchholz
On Tue, Apr 9, 2013 at 8:39 AM, David DeHaven wrote: > > > [ cc'ing awt-dev@ ] > > > > Probably gcc can't process typedefs with visibility attributes > specified, hence the changes to AWT. Generally they look good. > > It's not necessary for those typedefs as those types are not being used to > de

Re: RFR : JDK-8009162: "make test" target change

2013-03-05 Thread Martin Buchholz
e cost. > > Dissent? It sounds like Martin and Alan are in favour > > Mike > > On Mar 5 2013, at 13:06 , Alan Bateman wrote: > > On 05/03/2013 20:58, Martin Buchholz wrote: > > > > On Tue, Mar 5, 2013 at 5:37 AM, Alan Bateman wrote: > >> >>> >

Re: RFR : JDK-8009162: "make test" target change

2013-03-05 Thread Martin Buchholz
On Tue, Mar 5, 2013 at 5:37 AM, Alan Bateman wrote: > >> >> it make sense to default to the JDK image. This introduces a new problem, where a developer will build and test, but because the lazy developer did not build images, the wrong bits get tested. Either fully support testing with non-imag

Re: Could you sponsor another simple fix?

2013-01-08 Thread Martin Buchholz
Thanks! This change looks very good to me - why did we the maintainers of zip_util never notice it? It's worth a later backport to jdk7 as well. On Tue, Jan 8, 2013 at 10:53 AM, Xueming Shen wrote: > The correct list is core-libs-...@openjdk.java.net > > I will be the sponsor for this change. >