Request Approval: 8035584: ArrayList(c) should avoid inflation if c is empty

2014-04-28 Thread Mike Duigou
Hello, Please approve this back-port of the fix for JDK-8035584 to jdk8-dev: http://cr.openjdk.java.net/~mduigou/JDK-8035584/4.jdk8u/webrev/ JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/e8656ee2cdde The JKD8 changeset is a subse

Re: Javadoc for default methods of an interface

2014-02-05 Thread Mike Duigou
The new tags are used in JDK docs but aren't standard javadoc tags. It's necessary to use the -tag option to define them so that javadoc tool will recognize then in source outside the JDK. On 2014-02-05, at 11:42, Brian Goetz wrote: > There are some new javadoc tags to let you separate norm

Re: RFR: 8029795 : LinkedHashMap.getOrDefault() doesn't update access order. (was Why doesn't new Map methods generate entry accesses on LinkedHashMap?)

2013-12-10 Thread Mike Duigou
ke sense to rewrite get() in terms of getOrDefault() to reduce > duplication? > > Thanks > > Sent from my phone > > On Dec 9, 2013 10:40 PM, "Mike Duigou" wrote: > Hello all; > > I've posted a webrev for review which corrects the problem and adds &

RFR: 8029795 : LinkedHashMap.getOrDefault() doesn't update access order. (was Why doesn't new Map methods generate entry accesses on LinkedHashMap?)

2013-12-09 Thread Mike Duigou
Hello all; I've posted a webrev for review which corrects the problem and adds appropriate tests. http://cr.openjdk.java.net/~mduigou/JDK-8029795/0/webrev/ I also updated the documentation to mention that getOrDefault as well as the replace methods generate access events. Mike On Dec 9 2013

Re: Why doesn't new Map methods generate entry accesses on LinkedHashMap? [Copy]

2013-12-09 Thread Mike Duigou
♬ ♪ "Who am I to disagree..." ♫ This should be a P2 and fixed for Java 8. Mike On Dec 9 2013, at 02:51 , Doug Lea wrote: > On 12/09/2013 05:11 AM, Paul Sandoz wrote: >> Hi Roman, >> >> On Dec 8, 2013, at 10:29 PM, Roman Leventov wrote: >>> Especially getDefault(). Doesn't this violate princ

Re: webrev.ksh on Ubuntu 12.04

2013-11-25 Thread Mike Duigou
efore proceeding with that. Mike On Nov 21 2013, at 04:42 , Dave Pointon wrote: > Hiya Mike , > > On Wed, 2013-11-20 at 15:39 -0800, Mike Duigou wrote: >>> + hg outgoing -q --template '{rev}\n' default '=' >>> ssh://jtc-hg.hursley.ibm.com//home/hg/jtch

Re: CFV: New jdk8 Reviewer: Stuart Marks

2013-11-22 Thread Mike Duigou
Vote: YES Very much long overdue! On Nov 22 2013, at 05:47 , Alan Bateman wrote: > > I hereby nominate Stuart Marks to jdk8 Reviewer. > > Stuart has Committer role in the jdk8, jdk7u and lambda projects. He has been > contributing changes to OpenJDK for almost 3 years. He is author to more t

Re: webrev.ksh on Ubuntu 12.04

2013-11-20 Thread Mike Duigou
> + hg outgoing -q --template '{rev}\n' default '=' > ssh://jtc-hg.hursley.ibm.com//home/hg/jtchg-ibm-adm/composite/80/jcl/head > + sort -n > hg outgoing: invalid arguments This implies to me that OUTPWS is set to "default = ssh://jtc-hg.hursley.ibm.com//home/hg/jtchg-ibm-adm/composite/80/jcl/he

Re: Changes to look and feel of javadoc generated API pages in JDK 8

2013-11-06 Thread Mike Duigou
This looks like a nice refinement. Some immediate bits of feedback: - The size of and {@code } elements differs. (14.4px vs 14px). This is also a problem with the existing templates. - Why px for most but not all measurements? I would personally prefer to see em units used to tie sizing of el

Re: CFV: New JDK 8 Committer: Anthony Scarpino (ascarpino)

2013-11-06 Thread Mike Duigou
Vote: YES On Nov 6 2013, at 12:03 , Sean Mullan wrote: > I hereby nominate Anthony Scarpino to JDK 8 Committer. > > Anthony is a member of the Security Libraries Team at Oracle and has > contributed 16 changesets to JDK 8 in the security libraries area, including > 2 fixes involving API chang

Re: patch in test/Makefile for running langtools tests on a WXP/Cygwin platform

2013-11-04 Thread Mike Duigou
On Nov 1 2013, at 02:25 , Francis ANDRE wrote: > Hi > > Following is an hg diff output for making the test/Makefile running the > langtools/test on a WXP/Cygwin platform. > > > FrancisANDRE@idefix /cygdrive/z/JDK/jdk8 > $ hg diff test/Makefile > diff --git a/test/Makefile b/test/Makefile >

Re: patch in test/Makefile for running langtools tests on a WXP/Cygwin platform

2013-11-01 Thread Mike Duigou
On Nov 1 2013, at 08:50 , Jonathan Gibbons wrote: > On 11/01/2013 02:25 AM, Francis ANDRE wrote: >> Hi >> >> Following is an hg diff output for making the test/Makefile running the >> langtools/test on a WXP/Cygwin platform. I will reply to Francis directly on his points. >> >> Francis > >

Re: CFV: New jdk8 Reviewer: Daniel Fuchs

2013-10-30 Thread Mike Duigou
Vote: YES On Oct 30 2013, at 08:44 , Alan Bateman wrote: > > I hereby nominate Daniel Fuchs to jdk8 Reviewer. > > Daniel is on his second tour of duty in Oracle's JDK team. Those on jmx-dev > will remember Daniel from the early years of OpenJDK when he was contributing > changes to JMX. He l

Re: CFV: New JDK8 Committer: Johnny Chen (jchen)

2013-10-22 Thread Mike Duigou
Vote: YES On Oct 22 2013, at 12:50 , Phil Race wrote: > I hereby nominate Johnny Chen to JDK8 committer. > > Johnny has been working for the Java client team since the beginning of the > year spending working on bugs in Java 2D in JDK 8 fixing security bugs > and some OS X related issues using

Re: CFV: New JDK8 Committer: Vadim Pakhnushev (vadim)

2013-10-22 Thread Mike Duigou
Vote: YES On Oct 22 2013, at 12:24 , Phil Race wrote: > I hereby nominate Vadim Pakhnushev to JDK8 committer. > > Vadim has been working for the Java client team for over a year > with a substantial amount of that time working on bugs in Java 2D in JDK 8. > He has substantial background in grap

Result: New JDK8 Committer Brent Christian (bchristi)

2013-10-17 Thread Mike Duigou
, at 14:18 , Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year > but has tackled some significant problems including the initial re-write of > HashMap in Java 8 to replace alte

Re: RFR: 8026062 : (s) webrev.ksh: fix bug title web scraping, remove teamware, sac, "open bug" and wxfile support

2013-10-16 Thread Mike Duigou
Reminder: http://cr.openjdk.java.net/~mduigou/JDK-8026062/2 needs final review. Mike On Oct 14 2013, at 11:56 , Mike Duigou wrote: > > On Oct 11 2013, at 18:03 , Weijun Wang wrote: > >> The webrev shows """ inside the "Bug id" header entry. >

Re: RFR: 8026062 : (s) webrev.ksh: fix bug title web scraping, remove teamware, sac, "open bug" and wxfile support

2013-10-14 Thread Mike Duigou
webrev changes. > It's so cool reviewing webrev itself without looking at the actual code > changes. :) Thank you for the review! Mike > > Thanks > Max > > On 10/12/13 8:22 AM, Mike Duigou wrote: >> >> On Oct 11 2013, at 14:56 , Bradford Wetmore wrote: >&

Re: RFR: 8026062 : (s) webrev.ksh: fix bug title web scraping, remove teamware, sac, "open bug" and wxfile support

2013-10-11 Thread Mike Duigou
gt; > On 10/11/2013 11:33 AM, Mike Duigou wrote: >> I should also ask if anyone is using the -l option. I would like to delete >> it as well as it offers no particular value for mercurial (that I can tell). >> >> Mike >> >> On Oct 10 2013, at 17:20 , Weij

Re: RFR: 8026062 : (s) webrev.ksh: fix bug title web scraping, remove teamware, sac, "open bug" and wxfile support

2013-10-11 Thread Mike Duigou
I should also ask if anyone is using the -l option. I would like to delete it as well as it offers no particular value for mercurial (that I can tell). Mike On Oct 10 2013, at 17:20 , Weijun Wang wrote: > > > On 10/10/13 1:13 PM, Mike Duigou wrote: >> >> On Oct 9 20

Re: RFR: 8026062 : (s) webrev.ksh: fix bug title web scraping, remove teamware, sac, "open bug" and wxfile support

2013-10-09 Thread Mike Duigou
On Oct 9 2013, at 19:45 , John Rose wrote: > On Oct 9, 2013, at 3:54 PM, Mike Duigou wrote: > >> Hello all; >> >> This changeset revisits webrev's integration with bugs.openjdk.java.net to >> correct problems with the scraping of bug titles from jbs

Re: RFR: 8026062 : (s) webrev.ksh: fix bug title web scraping, remove teamware, sac, "open bug" and wxfile support

2013-10-09 Thread Mike Duigou
n part because it's not documented anywhere and there are alternatives. If you can confirm that the alternatives are adequate I would very much appreciate being able to go ahead with removing wxfile support. Mike > Thanks > Max > > On 10/10/13 6:54 AM, Mike Duigou wrote: &g

RFR: 8026062 : (s) webrev.ksh: fix bug title web scraping, remove teamware, sac, "open bug" and wxfile support

2013-10-09 Thread Mike Duigou
Hello all; This changeset revisits webrev's integration with bugs.openjdk.java.net to correct problems with the scraping of bug titles from jbs html. I also eliminated the now obsolete "-O" option since bugs are now all visible on the preferred bugs.openjdk.java.net system. While I was at it

Re: CFV: New JDK 8 Reviewer: Seán Coffey

2013-10-09 Thread Mike Duigou
Vote: YES On Oct 9 2013, at 11:51 , Chris Hegarty wrote: > I hereby nominate Seán Coffey (coffeys) to JDK 8 Reviewer. > > Seán has worked in the core libraries and networking area since before the > beginning of OpenJDK. Seán is probably best known for his role as 7u > maintainer, but as the

Re: CFV: New JDK 8 Reviewer: Bhavesh Patel

2013-10-07 Thread Mike Duigou
Vote: YES On Oct 4 2013, at 12:36 , Jonathan Gibbons wrote: > I hereby nominate Bhavesh Patel to JDK 8 Reviewer. > > Bhavesh has worked on javadoc and related doclets since before the beginning > of OpenJDK. He is currently the primary maintainer of the standard doclet. He > has authored 51 ch

Re: CFV: New JDK8 Committer: Magnus Ihse Bursie

2013-10-02 Thread Mike Duigou
Vote: YES On Oct 2 2013, at 02:36 , Erik Joelsson wrote: > I hereby nominate Magnus Ihse Bursie to JDK8 Committer. > > Magnus is one of the main contributers to the build-infra project, and since > recently coming back from parental leave, has provided a steady stream of > change sets in the b

Re: CFV: New jdk8 Reviewer: Staffan Larsen

2013-10-02 Thread Mike Duigou
Vote: YES On Oct 1 2013, at 22:13 , Alan Bateman wrote: > I hereby nominate Staffan Larsen to jdk8 Reviewer. > > Staffan leads the serviceability area in Oracle's JDK team and has been > contributing changes to OpenJDK since Dec 2010. He has Reviewer role on the > hsx project and is author of

Re: Shouldn't Optional be Serializable?

2013-09-27 Thread Mike Duigou
On Sep 17 2013, at 16:32 , Vitaly Davidovich wrote: > Presumably because you may want to have class fields that express > nullability via Optional rather than null. Using Optional as a field type doesn't seem to offer much. Would the Optional field be wrapped in accessors? If it's not wrapped

Re: Shouldn't Optional be Serializable?

2013-09-27 Thread Mike Duigou
On Sep 18 2013, at 06:03 , roger riggs wrote: > Hi Remi,, > > Optional has semantics beyond those of simple boxing including > throwing an exception if it has no value. The class libraries are > designed to be useful to developers as part of a whole data model > which includes serialization; o

Re: CFV: New JDK8 Committer Brent Christian (bchristi)

2013-09-26 Thread Mike Duigou
Vote: YES On Sep 26 2013, at 14:18 , Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year > but has tackled some significant problems including the initial re-write of > HashM

CFV: New JDK8 Committer Brent Christian (bchristi)

2013-09-26 Thread Mike Duigou
I hereby nominate Brent Christian to jdk8 Committer. Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code

Re: CFV: New JDK 8 Committer: Erik Gahlin

2013-09-05 Thread Mike Duigou
Vote: YES On Sep 4 2013, at 23:16 , Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has > contributed many changes especially in the area of JConsole. The following > are Erik's commits: > > 717217

Re: CFV: New JDK 8 Committer: Attila Szegedi (attila)

2013-09-04 Thread Mike Duigou
Vote: YES On Sep 4 2013, at 14:38 , Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly > reviewing other committers' work, he is actively developing Nashorn on daily > basis and has contributed man

Result: New jdk8 Committer: Brian Burkhalter (bpb)

2013-08-30 Thread Mike Duigou
Voting for Brian Burkhalter[1] is now closed. Yes: 26 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Congratulations! -Mike [1] http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-August/002973.html

Re: CFV: New jdk8 Committer: Jan Lahoda

2013-08-28 Thread Mike Duigou
Vote: YES On Aug 28 2013, at 14:54 , Jonathan Gibbons wrote: > I hereby nominate Jan Lahoda to jdk8 Committer. > > Jan is very familiar with the javac codebase as a result of his work on the > NetBeans Java editor, and since 2010, he has been making contributions back > to the OpenJDK langtool

Re: CFV: New jdk8 Reviewer: Joel Borggrén-Franck

2013-08-27 Thread Mike Duigou
Vote: YES On Aug 27 2013, at 17:45 , Jonathan Gibbons wrote: > > I hereby nominate Joel Borggrén-Franck to jdk8 Reviewer. > > Joel has been an active participant in JDK 8 since joining the LangTools team > over a year ago, as can be seen by his numerous contributions to the > langtools, jdk a

Re: CFV: New jdk8 Reviewer: Paul Sandoz

2013-08-26 Thread Mike Duigou
Vote: YES On Aug 26 2013, at 04:26 , Alan Bateman wrote: > > I hereby nominate Paul Sandoz to jdk8 Reviewer. > > Paul has been compute bound on the jdk8 project for some time. Everyone > following the Lambda and JSR-335 effort will recognize Paul. He has been a > key contributor to the stream

Result: New jdk8 Committer: Marcus Lagergren (lagergren)

2013-08-21 Thread Mike Duigou
Voting for Marcus Lagergren [1] is now closed. Yes: 25 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Congratulations! -Mike [1] http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-August/002916.html

Re: CFV: New JDK8 Committer Brian Burkhalter (bpb)

2013-08-14 Thread Mike Duigou
Vote: YES On Aug 14 2013, at 14:23 , Mike Duigou wrote: > I hereby nominate Brian Burkhalter to jdk8 Committer. > > Brian joined the Oracle OpenJDK team a couple of months ago and has quickly > become a very active contributor to the long neglected numerics area. In > addition

CFV: New JDK8 Committer Brian Burkhalter (bpb)

2013-08-14 Thread Mike Duigou
I hereby nominate Brian Burkhalter to jdk8 Committer. Brian joined the Oracle OpenJDK team a couple of months ago and has quickly become a very active contributor to the long neglected numerics area. In addition to contributing a number of important bug fixes himself Brian has acted as sponsor/

Re: CFV: New JDK8 Committer Marcus Lagergren (lagergren)

2013-08-06 Thread Mike Duigou
Vote: YES On Aug 6 2013, at 13:18 , Mike Duigou wrote: > I hereby nominate Marcus Lagergren to jdk8 Committer. > > Marcus is a Reviewer on the Nashorn project with many contributed changesets > which are now incorporated in the JDK8 repo. He has also completed many > rev

CFV: New JDK8 Committer Marcus Lagergren (lagergren)

2013-08-06 Thread Mike Duigou
I hereby nominate Marcus Lagergren to jdk8 Committer. Marcus is a Reviewer on the Nashorn project with many contributed changesets which are now incorporated in the JDK8 repo. He has also completed many reviews of Nashorn changes by other committers. Changesets (in jdk8/nashorn repo): hg log

Re: CFV: New jdk8 Committer: Peter Levart

2013-08-04 Thread Mike Duigou
Vote: YES On Aug 4 2013, at 19:51 , Alan Bateman wrote: > > I hereby nominate Peter Levart to jdk8 Committer. > > Those on core-libs-dev or lambda-dev will know Peter from his regular > contributions and review comments. Peter has contributed or co-contributed > more than 8 significant change

Re: CFV: New JDK8 Committer: Roger Riggs

2013-07-29 Thread Mike Duigou
Vote: yes On 2013-07-29, at 14:21, Xueming Shen wrote: > I hereby nominate Roger Riggs to JDK8 Committer. > > Roger Riggs has contributed 8 patches to the JDK 8 repositories. Roger > is the co-spec lead of the JSR310 and one of the main code contributors > of jdk8 JSR310 project. > > http:/

Result: New JDK8 Committer: Henry Jen

2013-07-29 Thread Mike Duigou
14:45 , Mike Duigou wrote: > I hereby nominate Henry Jen (henryjen) to JDK8 Committer. > > In addition to providing important contributions to the lambdafication and > streams effort Henry has shepherded a number of changesets for others through > the OpenJDK process and is abl

Re: CFV: New JDK8 Committer: Henry Jen

2013-07-12 Thread Mike Duigou
Vote: YES On Jul 12 2013, at 14:45 , Mike Duigou wrote: > I hereby nominate Henry Jen (henryjen) to JDK8 Committer. > > In addition to providing important contributions to the lambdafication and > streams effort Henry has shepherded a number of changesets for others through &

CFV: New JDK8 Committer: Henry Jen

2013-07-12 Thread Mike Duigou
I hereby nominate Henry Jen (henryjen) to JDK8 Committer. In addition to providing important contributions to the lambdafication and streams effort Henry has shepherded a number of changesets for others through the OpenJDK process and is ably qualified and experienced for the committer role. A

Result: New jdk8 Reviewer: Brian Goetz

2013-06-05 Thread Mike Duigou
Voting for Brian Goetz [1] is now closed. Yes:30(*) Veto:0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus, this is sufficient to approve the nomination. Mike [1] http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-May/002513.html (*) One additional yes vote was r

Reminder: CFV : New jdk8 Reviewer : Brian Goetz

2013-05-30 Thread Mike Duigou
A reminder that this vote is still ongoing and will complete on Monday night. As has been mentioned in previous followups message to the original posting; Reviewer votes require a Three Vote Consensus and only Reviewers may vote. Thank you Mike Begin forwarded message: > From: Mike Dui

Re: Review request: JDK8 b91 source with GPL header errors

2013-05-28 Thread Mike Duigou
On May 28 2013, at 18:45 , David Holmes wrote: > On 29/05/2013 11:35 AM, David Katleman wrote: >> Below are corrections to GPL headers found in JDK8 b91 >> >> http://cr.openjdk.java.net/~katleman/8015525/webrev >> >> All are punctuation issues, no code is involved, anyone can review. >> >>

Re: CFV : New jdk8 Reviewer : Brian Goetz

2013-05-20 Thread Mike Duigou
> > A Reviewer needs a Three Vote Consensus, not a Lazy Consensus, as you imply. > http://openjdk.java.net/bylaws#reviewer > > -- Jon > > > On 05/20/2013 04:41 PM, Mike Duigou wrote: >> I hereby nominate Brian Goetz to jdk8 project Reviewer. >> >> Brian

Re: CFV : New jdk8 Reviewer : Brian Goetz

2013-05-20 Thread Mike Duigou
Vote: Yes On May 20 2013, at 16:41 , Mike Duigou wrote: > I hereby nominate Brian Goetz to jdk8 project Reviewer. > > Brian is the Java Language Architect at Oracle and has been leading the > Lambda language and library efforts (JSR-335). Much of this work was recently > inte

CFV : New jdk8 Reviewer : Brian Goetz

2013-05-20 Thread Mike Duigou
I hereby nominate Brian Goetz to jdk8 project Reviewer. Brian is the Java Language Architect at Oracle and has been leading the Lambda language and library efforts (JSR-335). Much of this work was recently integrated into the JDK 8 repositories after over 2 years of development in the Lambda Pr

Re: Review request: JDK8 b89 source with GPL header errors

2013-05-09 Thread Mike Duigou
All look good. Sorry to be the contributor of three of these. Mike On May 9 2013, at 11:38 , David Katleman wrote: > Below are corrections to GPL headers found in JDK8 b89: > >http://cr.openjdk.java.net/~katleman/8014289/webrev.jdk.01/ > > Just 4 files this go around, all are simple punct

Re: CFV: New jdk8 Committer: Paul Sandoz

2013-05-08 Thread Mike Duigou
Vote: YES On May 8 2013, at 09:11 , Alan Bateman wrote: > I hereby nominate Paul Sandoz to jdk8 Committer. > > Everyone following the Lambda and JSR-335 effort will recognize Paul. He has > been a key contributor to the streams API and implementation, the spliterator > API, the extensive tests

Re: CFV: New JDK8 Committer: Jim Laskey

2013-04-24 Thread Mike Duigou
Vote: YES On Apr 24 2013, at 11:13 , Jonathan Gibbons wrote: > I hereby nominate Jim Laskey to JDK8 Committer. > > Jim Laskey is the Lead on the OpenJDK Nashorn Project [1]. Jim joined the FX > Script compiler team in January of 2009 and has been a member of the > LangTools team since fall of

Re: CFV: New JDK8 Reviewer: Athijegannathan Sundararajan (Sundar)

2013-04-24 Thread Mike Duigou
Vote: YES On Apr 24 2013, at 11:14 , Jonathan Gibbons wrote: > I hereby nominate Athijegannathan Sundararajan (Sundar) to JDK8 Reviewer. > > Sundararajan has been with Sun/Oracle from Oct 2000. He has been involved JDK > projects from jdk 1.3.1. In jdk6, he did jsr223 (javax.script) and Rhino

Re: Review request: JDK8 b85 source with GPL header errors

2013-04-12 Thread Mike Duigou
The JDK and root repo changes look fine to me. On Apr 12 2013, at 09:06 , David Katleman wrote: > Below are corrections to GPL headers found in JDK8 b85: > >http://cr.openjdk.java.net/~katleman/8012048/webrev.hotspot.01/ >http://cr.openjdk.java.net/~katleman/8012048/webrev.jdk.01/ >h

Re: CFV: New OpenJDK8 Reviewer: Omair Majid

2013-04-09 Thread Mike Duigou
Vote: YES On Apr 8 2013, at 13:56 , Andrew Hughes wrote: > I hereby nominate Omair Majid for the position of OpenJDK 8 reviewer. > > Omair has been working on OpenJDK since his internship at Red Hat in May 2008, > and has continued doing so after obtaining full-time employment in June 2010. > In

Re: CFV: New jdk8 Reviewer: Erik Joelsson

2013-03-22 Thread Mike Duigou
Vote: Yes On Mar 22 2013, at 08:48 , Alan Bateman wrote: > > I hereby nominate Erik Joelsson to jdk8 Reviewer. > > Erik has Committer role on the jdk8 and build-infra projects. He is the > author of more than 70 changes pushed to the jdk8 forest over the last 9 > months. He has also been rev

Re: RFR : JDK-8009162: "make test" target change

2013-03-06 Thread Mike Duigou
I will update the patch as you suggest: - rename current "test" target to "test-only". - add "test" target dependent upon "images" "test-only" Good suggestion! Thanks! Mike On Mar 6 2013, at 00:37 , Erik Joelsson wrote: > On 2013-03-05 22:1

Re: RFR : JDK-8009162: "make test" target change

2013-03-05 Thread Mike Duigou
We could certainly make test depend upon images. I considered but did not implement this because I imagined that doing so would result in inevitable complaints about overhead and/or unwanted building. On my system an images target rebuild with no work takes only 1 second. Probably more on a non

RFR : JDK-8009162: "make test" target change

2013-03-04 Thread Mike Duigou
Hello all; Sorry for the wide broadcast but this change, though very small, affects many different teams. Currently the JDK8 root repo "make test" target runs against the jdk pre-image. ie. the compiled jdk classes. Many tests regression tests expect to be run against a full jdk image and fail.

Re: CFV: New JDK8 Committer: David Buck

2013-01-11 Thread Mike Duigou
Vote : Yes On Jan 11 2013, at 05:15 , Alexander Potochkin wrote: > I hereby nominate David Buck to jdk8 Committer. > > Buck has been a member of the Java SE sustaining team for two years now. > He has spent most of that time working on JRockit, > but is also responsible for working on client and

Re: CFV: New jdk8 Committer: Dan Xu

2013-01-10 Thread Mike Duigou
Vote: Yes

Re: CFV: New JDK8 Committer: Erik Joelsson

2012-11-13 Thread Mike Duigou
Vote: Yes On Nov 13 2012, at 10:21 , Kelly O'Hair wrote: > > I hereby nominate Erik Joelsson to JDK8 Committer. > > Erik works in the Build-Infra project, and has already contributed many > change sets to the build-infra repositories, > and most of those have been committed to the jdk8/build r

Re: CFV: New JDK8 Committer: Robert Field

2012-10-05 Thread Mike Duigou
Vote: Yes On Oct 5 2012, at 02:21 , Maurizio Cimadamore wrote: > I hereby nominate Robert Field to JDK8 Committer. > > Robert works in the Langtools team at Oracle, and has already contributed > several change sets to the Lambda repository. Robert will > be contributing to the integration eff

Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-22 Thread Mike Duigou
Dear OpenJDK CoreLibs community, A significant enhancement to the Java SE hashing-based Map implementations in planned for inclusion in Java SE 7u6. All of the hashing based Map implementations: HashMap, Hashtable, LinkedHashMap, WeakHashMap and ConcurrentHashMap will now use an enhanced hashin

Re: Potential StringBuffer to StringBuilder clean-up (where warranted)

2012-05-04 Thread Mike Duigou
Hi Martijn; Stefan as really dived into this project! Thank you for helping him make progress and assisting him with getting his changes ready to commit. As with the warnings changes, because the changes span multiple projects, it will be necessary to break up the webrevs a bit and submit them

Re: CFV: New jdk8 Committer: Kurchi Subhra Hazra

2012-02-02 Thread Mike Duigou
Vote: Yes - Mike On Feb 2 2012, at 06:15 , Alan Bateman wrote: > > I hereby nominate Kurchi Subhra Hazra to jdk8 Committer. > > Kurchi graduated from the University of Illinois, Urbana Champaign with a > M.Sc. in Computer Science last summer, joining Oracle in July 2011 to work on > the JDK

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread Mike Duigou
> Is there a bug id/reference for Remi's patch? Happy to try and help > review (not that I'm an experienced OpenJDK person by any stretch of > the imagination). > > Cheers, > Martijn There is not bug # yet but here is the current webrev/patch: http://cr.openjdk.java.net/~forax/WarningDay1/web

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread Mike Duigou
ssion >>>>> with >>>>> Mike on core-libs-dev about this. I don't think it has been pushed yet >>>>> but I >>>>> assume will be soon. >>>>> >>>> For me, the patch is ready, Mike can push it when he wants :) >

Re: Collections.enumeration() WAS Warning Cleanup Day

2011-12-03 Thread Mike Duigou
a.util.PropertyPermission >>> because java.util.Collections.enumeration is wrongly typed. >>> >> Rémi - you might want to sync up with Mike Duigou as I believe he has been >> working on the java.util area including collections. Also best to move any >> discussions on collections/util area