the numbre of occurances of
mispeled words.
s'marks
On 10/30/13 1:40 PM, Jonathan Gibbons wrote:
find/grep before and after?
-- Jon
On 10/30/2013 01:17 PM, Stuart Marks wrote:
The changes look good.
It looks like "occured" is the most common spelling error. I wonder h
The changes look good.
It looks like "occured" is the most common spelling error. I wonder how many
instances of this misspelling will remain in the codebase after your fixes.
s'marks
On 10/30/13 4:43 AM, sergey malenkov wrote:
Hello,
Could you please review the following fix:
fix:http://cr
Hi Sergey,
Good stuff. I've looked over the RMI and serialization related files and the
changes look fine.
s'marks
On 10/24/13 10:17 AM, sergey malenkov wrote:
Any objections?
SAM
On 23.10.2013 19:05, sergey malenkov wrote:
Could you please review the following huge fix:
fix:http://cr.o
Vote: yes
On 10/24/13 7:33 AM, Chris Hegarty wrote:
I hereby nominate Mark Sheppard (msheppar) to JDK8 Committer.
Mark is currenly an author on the JDK8 project. He has been working on the JDK
for more than a year, and contributing many signifcant changes, in quite
intricate areas of code. Of m
Vote: yes
On 9/26/13 2:18 PM, Mike Duigou wrote:
I hereby nominate Brent Christian to jdk8 Committer.
Brent has been working on the core libraries for a little less than a year but
has tackled some significant problems including the initial re-write of HashMap
in Java 8 to replace alternative
Voting for Attila Szegedi [1] is now closed.
Yes: 24
Veto: 0
Abstain: 0
According to the Bylaws definition of Lazy Consensus, this is
sufficient to approve the nomination.
Congratulations, Attila!
s'marks
[1] http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-September/003109.html
Vote: yes
On 9/4/13 2:38 PM, Stuart Marks wrote:
I hereby nominate Attila Szegedi to JDK 8 Committer.
Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing
other committers' work, he is actively developing Nashorn on daily basis and has
contributed many chang
I hereby nominate Attila Szegedi to JDK 8 Committer.
Attila is a Reviewer on the Nashorn project. In addition to regularly
reviewing other committers' work, he is actively developing Nashorn on
daily basis and has contributed many changesets related to areas of
Nashorn's parser and compiler, i
Hi Joe,
As you might imagine, I'm all for it. Which specific warnings categories
do you envision enabling?
Some work in the makefiles is probably necessary provide default
settings for warnings/errors and to make the settings easily overridable
from the command line. The current variable tha
Vote: yes
On 8/14/13 2:23 PM, Mike Duigou wrote:
I hereby nominate Brian Burkhalter to jdk8 Committer.
Brian joined the Oracle OpenJDK team a couple of months ago and has quickly
become a very active contributor to the long neglected numerics area. In
addition to contributing a number of impo
Vote: yes
On 8/6/13 1:18 PM, Mike Duigou wrote:
I hereby nominate Marcus Lagergren to jdk8 Committer.
Marcus is a Reviewer on the Nashorn project with many contributed changesets
which are now incorporated in the JDK8 repo. He has also completed many reviews
of Nashorn changes by other commit
Vote: yes
On 8/4/13 7:51 PM, Alan Bateman wrote:
I hereby nominate Peter Levart to jdk8 Committer.
Those on core-libs-dev or lambda-dev will know Peter from his regular
contributions and review comments. Peter has contributed or co-contributed more
than 8 significant changes to jdk8 including
Vote: yes
On 7/29/13 2:21 PM, Xueming Shen wrote:
I hereby nominate Roger Riggs to JDK8 Committer.
Roger Riggs has contributed 8 patches to the JDK 8 repositories. Roger
is the co-spec lead of the JSR310 and one of the main code contributors
of jdk8 JSR310 project.
http://hg.openjdk.java.net/
Vote: yes
On 7/12/13 2:45 PM, Mike Duigou wrote:
I hereby nominate Henry Jen (henryjen) to JDK8 Committer.
In addition to providing important contributions to the lambdafication and
streams effort Henry has shepherded a number of changesets for others through
the OpenJDK process and is ably q
Vote: yes
On 1/10/13 6:18 AM, Alan Bateman wrote:
I hereby nominate Dan Xu to jdk8 Committer.
Dan joined the JDK libraries team in Oracle about 6 months ago and has
contributed several changes to jdk8 so far:
http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2be39b27e1c
http://hg.openjdk.java.net/jd
Hi Martijn,
Great to hear that the LJC is continuing this activity. We are as well; I've
updated the warnings page [1] to have the latest statistics including the work
that my colleague Kurchi Hazra has done.
I think the only area that has pending warnings changes are the java.text ones
that
On 3/1/12 7:07 AM, Michael McMahon wrote:
Latest webrev at:
http://cr.openjdk.java.net/~michaelm/7113349/jdk8/webrev.4/
I haven't looked too closely at the changes, but instead I'm trying to build
them. I've pulled the latest JDK 8 TL forest and the patches applied cleanly.
I'm now trying to
On 2/28/12 2:34 AM, Alan Bateman wrote:
On 27/02/2012 23:47, David Holmes wrote:
General meta comment: When this stuff went into 7u my biggest complaint was
that it introduced a mass of new platform-specific stuff in places that
weren't otherwise platform specific. That still seems to be the cas
is Giannakakis
, Jose Llarena,
Abraham Marín Pérez
For all of the remaining code:
Contributed-by: Mani Sarkar, Michael Barker
, Carl Jokl, Dinuk
Weerasinghe, Markus Stoy
, Tom Anderson
Mike.
On Fri, Feb 10, 2012 at 3:11 AM, Stuart Marks wrote:
Hi Mike,
I finally got back to this. These fixes lo
Hi Mike,
I finally got back to this. These fixes look pretty good and knock off 100+
additional warnings! I've filed bug 7143230 [1] to track this. I took a look
through the code and I took the liberty of fixing up a few very minor things:
1. Removed unnecessary casts to ZipEntry in JarVerifi
Michael,
Thanks for splitting up the patches and revising them in response to the review
comments.
I'm not yet entirely sure how to proceed with pushing these changes. I think
Chris assumed that I would push these changes. Since these are in awt,
printing, and beans, the changes might need t
Vote: Yes
s'marks
On 2/2/12 6:15 AM, Alan Bateman wrote:
I hereby nominate Kurchi Subhra Hazra to jdk8 Committer.
Kurchi graduated from the University of Illinois, Urbana Champaign with a M.Sc.
in Computer Science last summer, joining Oracle in July 2011 to work on the JDK
with a focus on net
Good stuff! It looks like others have chimed in already with good advice. I'll
take a look at the portion of the patches posted on core-libs-dev.
s'marks
On 2/2/12 1:05 AM, Michael Barker wrote:
Hi,
Attached is a patch that was a result of our work at the LJC OpenJDK
Hack session on Tuesday.
Ah, it looks like you guys wrapped up while I was taking my lunch break. I hope
your hack session was fun and productive.
There was a question on IRC about the serialization warnings. There's some
additional information I wanted to add, so I'll post it here for everyone's
benefit.
--
The co
On 1/31/12 10:57 AM, Martijn Verburg wrote:
I would encourage anyone who is interested to continue the review of Rémi's
patch. More review is always helpful and there was
at least once case that Rémi identified where he thought the patch could be
improved with additional effort.
TL;DR -- If yo
On 1/31/12 2:02 AM, Martijn Verburg wrote:
On 31/01/2012 00:08, Stuart Marks wrote:
(Crap. I've just realized that I never pushed Deepak Bhole's java.text
patches from December. To avoid conflicts, I'd suggest avoiding changes to
src/share/classes/java/text. Other areas shou
Hi Martijn,
Great to hear that you're doing this!
I don't know if anyone from Oracle will be involved in this. I can try to hang
out on the #openjdk IRC channel, and I can review and push a couple of the
patches if you need help doing so. What time do you guys think you'll be online?
If you
Hi Deepak,
Any update on this? It sounds like it's fairly close to being finished. Just
because Warnings Cleanup Day (Week) is over doesn't mean that we should give up.
s'marks
On 12/6/11 5:26 PM, John Rose wrote:
On Dec 5, 2011, at 12:30 PM, Deepak Bhole wrote:
Since this is an importa
On 12/1/11 3:12 PM, John Rose wrote:
7117167: Misc warnings in java.lang.invoke and sun.invoke.*
http://cr.openjdk.java.net/~jrose/7117167/webrev.00/
Removing build warnings from java.lang.invoke and sun.invoke.*, as part of the
December 2011 cleanup effort.
Hi John,
I'm finally getting ba
Looks good! Please proceed with the push.
thanks.
s'marks
On 12/5/11 11:01 AM, Naoto Sato wrote:
OK here is the revised one:
http://cr.openjdk.java.net/~naoto/7117469/webrev.02/
I hope this is the final :-)
Naoto
On 12/2/11 5:41 PM, Stuart Marks wrote:
The changes you made are
Hi Mandy,
Thanks for the thorough review.
For warnings cleanup, we've been trying to avoid including refactorings like
changing Enumerations to Iterator or to the enhanced-for loop. Changes to use
try-with-resources also fall into this category. But I've been OK with such
changes if the prima
[bcc to jdk8-dev; subsequent reviews/comments should go to core-libs-dev]
Hi Mike, all,
I've collected all the patches together, filed bug 7117249 to cover them, and
have started this new review thread on core-libs-dev for it. I've also posted a
webrev for the collected patches:
http://cr.op
On 12/4/11 7:10 PM, David Schlosnagle wrote:
On Dec 4, 2011, at 7:17 PM, Stuart Marks wrote:
I've been mulling over what to do with these two patches for the past couple days.
Initially I was thinking of merging the patches and generating a new one combining the
best of both. But af
This has turned out to be a rather long day. :-)
Ten changesets have been integrated so far, and 16 (!) changesets are being
reviewed or are awaiting review. There are a couple changesets still being
developed (including one from me; hey, I had to get some coding in myself).
We started at 10,
On 12/2/11 9:00 AM, Omair Majid wrote:
On 12/02/2011 07:18 AM, Alan Bateman wrote:
cc'ing core-libs-dev as that is the place to discuss these changes. I
see on the sign-up sheet [1] that omajid has signed up for java.lang,
maybe you are working together?
Unfortunately, David and I were not wor
35 matches
Mail list logo
