Re: Review request: JDK8 b85 source with GPL header errors

2013-04-12 Thread David Katleman
Thank you to Jon, Iris, Mike, and Alejandro for taking the time to review and approve this change. Dave On 4/12/2013 9:06 AM, David Katleman wrote: Below are corrections to GPL headers found in JDK8 b85: http://cr.openjdk.java.net/~katleman/8012048/webrev.hotspot.01/ http://cr.ope

Re: Review request: JDK8 b85 source with GPL header errors

2013-04-12 Thread David Katleman
On 4/12/2013 10:24 AM, Alejandro E Murillo wrote: minor one, change the year to 2013 on this: http://cr.openjdk.java.net/~katleman/8012048/webrev.hotspot.01/make/bsd/makefiles/fastdebug.make.cdiff.html The files were flagged for their inconsistent format, no analysis was done as to the corr

Re: Review request: JDK8 b85 source with GPL header errors

2013-04-12 Thread Alejandro E Murillo
minor one, change the year to 2013 on this: http://cr.openjdk.java.net/~katleman/8012048/webrev.hotspot.01/make/bsd/makefiles/fastdebug.make.cdiff.html Alejandro On 4/12/2013 10:06 AM, David Katleman wrote: Below are corrections to GPL headers found in JDK8 b85: http://cr.openjdk.java.net/~ka

RE: Review request: JDK8 b85 source with GPL header errors

2013-04-12 Thread Iris Clark
al Message- From: David Katleman Sent: Friday, April 12, 2013 9:07 AM To: jdk8-dev Subject: Review request: JDK8 b85 source with GPL header errors Below are corrections to GPL headers found in JDK8 b85: http://cr.openjdk.java.net/~katleman/8012048/webrev.hotspot.01/ http://cr.openjd

Re: Review request: JDK8 b85 source with GPL header errors

2013-04-12 Thread Mike Duigou
The JDK and root repo changes look fine to me. On Apr 12 2013, at 09:06 , David Katleman wrote: > Below are corrections to GPL headers found in JDK8 b85: > >http://cr.openjdk.java.net/~katleman/8012048/webrev.hotspot.01/ >http://cr.openjdk.java.net/~katleman/8012048/webrev.jdk.01/ >h

Re: Review request: JDK8 b85 source with GPL header errors

2013-04-12 Thread David Katleman
On 4/12/2013 9:34 AM, Jonathan Gibbons wrote: Dave, The fixes for langtools look good to me. Thanks for catching these. Thank you for looking at the langtools changes Jon. Feel free to browse the others as well, as none of these changes are of a technical nature. :-) Dave On 04

Re: Review request: JDK8 b85 source with GPL header errors

2013-04-12 Thread Jonathan Gibbons
Dave, The fixes for langtools look good to me. Thanks for catching these. -- Jon On 04/12/2013 09:06 AM, David Katleman wrote: Below are corrections to GPL headers found in JDK8 b85: http://cr.openjdk.java.net/~katleman/8012048/webrev.hotspot.01/ http://cr.openjdk.java.net/~katleman/8012

Review request: JDK8 b85 source with GPL header errors

2013-04-12 Thread David Katleman
Below are corrections to GPL headers found in JDK8 b85: http://cr.openjdk.java.net/~katleman/8012048/webrev.hotspot.01/ http://cr.openjdk.java.net/~katleman/8012048/webrev.jdk.01/ http://cr.openjdk.java.net/~katleman/8012048/webrev.langtools.01/ http://cr.openjdk.java.net/~katlema