Looks good for me.
-Dmitry
On 2013-05-09 23:45, David Katleman wrote:
>
> On 5/9/2013 12:09 PM, Dmitry Samersoff wrote:
>> David,
>>
>> test/java/lang/CharSequence/DefaultTest.java
>>
>> has a "Classpath exception" but shouldn't.
>
> Good catch.
>
> Scripts just check for correct format of the
On 5/9/2013 12:09 PM, Dmitry Samersoff wrote:
David,
test/java/lang/CharSequence/DefaultTest.java
has a "Classpath exception" but shouldn't.
Good catch.
Scripts just check for correct format of the header, but not whether the
file should have GPL or GPL+classpath.
I've updated the webrev
Hi Dave:
Below are corrections to GPL headers found in JDK8 b89:
http://cr.openjdk.java.net/~katleman/8014289/webrev.jdk.01/
Just 4 files this go around, all are simple punctuation changes,
anyone can review.
Looks good.
Tim
David,
test/java/lang/CharSequence/DefaultTest.java
has a "Classpath exception" but shouldn't.
-Dmitry
On 2013-05-09 22:38, David Katleman wrote:
> Below are corrections to GPL headers found in JDK8 b89:
>
> http://cr.openjdk.java.net/~katleman/8014289/webrev.jdk.01/
>
> Just 4 files thi
On 5/9/2013 12:02 PM, Mike Duigou wrote:
All look good.
Sorry to be the contributor of three of these.
Thank you to Mandy & Mike for reviewing!
That will do it!
Dave
On May 9 2013, at 11:38 , David Katleman wrote:
Below are corrections to GPL headers found in JDK8 b89:
ht
All look good.
Sorry to be the contributor of three of these.
Mike
On May 9 2013, at 11:38 , David Katleman wrote:
> Below are corrections to GPL headers found in JDK8 b89:
>
>http://cr.openjdk.java.net/~katleman/8014289/webrev.jdk.01/
>
> Just 4 files this go around, all are simple punct
Thumbs up.
Mandy
On 5/9/13 11:38 AM, David Katleman wrote:
Below are corrections to GPL headers found in JDK8 b89:
http://cr.openjdk.java.net/~katleman/8014289/webrev.jdk.01/
Just 4 files this go around, all are simple punctuation changes,
anyone can review.
As a veteran of many such h
Below are corrections to GPL headers found in JDK8 b89:
http://cr.openjdk.java.net/~katleman/8014289/webrev.jdk.01/
Just 4 files this go around, all are simple punctuation changes, anyone
can review.
As a veteran of many such header reviews, reviewing the patch link at
the top of the web
