Re: Review request: JDK8 b91 source with GPL header errors

2013-05-29 Thread David Katleman
Thank you Lance and David for the review, and Mike to suggest updating the template to avoid these issues in the first place. Dave On 5/29/2013 3:57 AM, Lance Andersen - Oracle wrote: looks fine Dave -lance On May 28, 2013, at 9:35 PM, David Katleman wrote: Below are corrections to

Re: Review request: JDK8 b91 source with GPL header errors

2013-05-29 Thread David Katleman
On 5/28/2013 8:50 PM, David Holmes wrote: On 29/05/2013 1:33 PM, Mike Duigou wrote: On May 28 2013, at 18:45 , David Holmes wrote: On 29/05/2013 11:35 AM, David Katleman wrote: Below are corrections to GPL headers found in JDK8 b91 http://cr.openjdk.java.net/~katleman/8015525/webrev

Re: Review request: JDK8 b91 source with GPL header errors

2013-05-29 Thread Lance Andersen - Oracle
looks fine Dave -lance On May 28, 2013, at 9:35 PM, David Katleman wrote: > Below are corrections to GPL headers found in JDK8 b91 > >http://cr.openjdk.java.net/~katleman/8015525/webrev > > All are punctuation issues, no code is involved, anyone can review. > > As a veteran of many such he

Re: Review request: JDK8 b91 source with GPL header errors

2013-05-28 Thread David Holmes
On 29/05/2013 1:33 PM, Mike Duigou wrote: On May 28 2013, at 18:45 , David Holmes wrote: On 29/05/2013 11:35 AM, David Katleman wrote: Below are corrections to GPL headers found in JDK8 b91 http://cr.openjdk.java.net/~katleman/8015525/webrev All are punctuation issues, no code is invol

Re: Review request: JDK8 b91 source with GPL header errors

2013-05-28 Thread Mike Duigou
On May 28 2013, at 18:45 , David Holmes wrote: > On 29/05/2013 11:35 AM, David Katleman wrote: >> Below are corrections to GPL headers found in JDK8 b91 >> >> http://cr.openjdk.java.net/~katleman/8015525/webrev >> >> All are punctuation issues, no code is involved, anyone can review. >> >>

Re: Review request: JDK8 b91 source with GPL header errors

2013-05-28 Thread David Holmes
On 29/05/2013 11:35 AM, David Katleman wrote: Below are corrections to GPL headers found in JDK8 b91 http://cr.openjdk.java.net/~katleman/8015525/webrev All are punctuation issues, no code is involved, anyone can review. As a veteran of many such header reviews, reviewing the patch link a

Review request: JDK8 b91 source with GPL header errors

2013-05-28 Thread David Katleman
Below are corrections to GPL headers found in JDK8 b91 http://cr.openjdk.java.net/~katleman/8015525/webrev All are punctuation issues, no code is involved, anyone can review. As a veteran of many such header reviews, reviewing the patch link at the top of the webrev is often easier than ea