Re: [jira] Updated: (JDO-257) Change return type of makePersistent from void to Object

2006-01-01 Thread Craig L Russell
Hi Michael,Looks good. Just one petty comment.CraigIndex: src/java/javax/jdo/listener/AttachCallback.java===--- src/java/javax/jdo/listener/AttachCallback.java (Revision 360481)+++ src/java/javax/jdo/listener/AttachCallback.java (Arbei

[jira] Resolved: (JDO-248) JPOX generates illegal SQL for queries using result class java.util.Map.

2006-01-01 Thread Craig Russell (JIRA)
[ http://issues.apache.org/jira/browse/JDO-248?page=all ] Craig Russell resolved JDO-248: --- Fix Version: JDO 2 beta Resolution: Fixed Assign To: Craig Russell (was: Erik Bengtson) Committed revision 360562. I changed the query to return na

Re: You can now debug tck20!

2006-01-01 Thread Michael Bouschen
Hi Matthew, thanks for adding debug support to maven.xml, this is great! I would like to propose two improvements: - I always get a message "JVM will wait until debugger attaches on port ..." even if I call runtck.jdori. I think the check whether property debugJvmargs is set needs to use the e

[jira] Updated: (JDO-257) Change return type of makePersistent from void to Object

2006-01-01 Thread Michael Bouschen (JIRA)
[ http://issues.apache.org/jira/browse/JDO-257?page=all ] Michael Bouschen updated JDO-257: - Attachment: attachInterfaces.patch Attached you find a patch (attachInterfaces.patch) for review. It removes javadoc references to PM.attachCopy which has been

[jira] Resolved: (JDO-252) JPOX throws JDOFatalInternalException for queries using numeric operators in the result clause.

2006-01-01 Thread Andy Jefferson (JIRA)
[ http://issues.apache.org/jira/browse/JDO-252?page=all ] Andy Jefferson resolved JDO-252: Resolution: Fixed Assign To: Andy Jefferson (was: Erik Bengtson) Fixed in JPOX CVS - builds 02/01/2006 or later. > JPOX throws JDOFatalInternalExceptio

[jira] Resolved: (JDO-253) JPOX generates illegal SQL for queries accessing fields of parameter in the result clause.

2006-01-01 Thread Andy Jefferson (JIRA)
[ http://issues.apache.org/jira/browse/JDO-253?page=all ] Andy Jefferson resolved JDO-253: Resolution: Fixed Assign To: Andy Jefferson (was: Erik Bengtson) Fixed in JPOX CVS - builds 02/01/2006 or later. > JPOX generates illegal SQL for queri

[jira] Commented: (JDO-248) JPOX generates illegal SQL for queries using result class java.util.Map.

2006-01-01 Thread Andy Jefferson (JIRA)
[ http://issues.apache.org/jira/browse/JDO-248?page=comments#action_12361484 ] Andy Jefferson commented on JDO-248: The test has a query "SELECT phoneNumbers FROM FullTimeEmployee INTO java.util.Map where "phoneNumbers" is a Map field. The test seems

Re: svn commit: r360206 - /db/jdo/trunk/tck20/maven.xml

2006-01-01 Thread Craig L Russell
Hi Matthew,This is great. Debugging the TCK with a real debugger. Imagine!CraigOn Dec 30, 2005, at 4:24 PM, [EMAIL PROTECTED] wrote:Author: madamsDate: Fri Dec 30 16:24:19 2005New Revision: 360206URL: http://svn.apache.org/viewcvs?rev=360206&view=revLog:added debugability with goals "debugtck.jdori

Re: [jira] Resolved: (JDO-240) JPOX throws JDOQLQuery$Compiler$ExpressionSyntaxException when DISTINCT is specified inside an aggregate function.

2006-01-01 Thread Craig L Russell
Wohoo! You're really knocking down these bugs!Happy New Year,CraigOn Dec 31, 2005, at 10:14 AM, Andy Jefferson (JIRA) wrote:     [ http://issues.apache.org/jira/browse/JDO-240?page=all ]Andy Jefferson resolved JDO-240:    Resolution: Fixed     Assign To: Andy Jeffers