Re: TCK completeness interface

2006-04-06 Thread Erik Bengtson
Craig, The "null" issue is over. It was a reachability issue where JPOX nullify all fields before deleting from the database. Now there is another issue in the CompletenessTest.test method where it falls the expected object tree back to the concrete classes. It compares a concrete object tree to

Re: TCK completeness interface

2006-04-06 Thread Craig L Russell
Hi Erik, Great news. If you are this far, then you have succeeded in storing and retrieving instances to the database. I'll have a fix for you shortly. Craig On Apr 6, 2006, at 4:06 AM, Erik Bengtson wrote: Craig, The "null" issue is over. It was a reachability issue where JPOX nullif

Re: TCK completeness interface

2006-04-06 Thread Michael Bouschen
Hi Craig, I think this issue appears at two different places: (1) Method compare(Object o1, Object o2) in all company classes delegates to the compareTo method and casts the first argument to the class instead of the interface: public int compare(Object o1, Object o2) { return ((I

Re: TCK completeness interface

2006-04-06 Thread Craig L Russell
Hi Michael, I haven't started on this. If possible, could you file a JIRA and attach your patch to it. Without Erik's changes, I can't test it either. Erik, Is there a way you can make the JPOX jar file available? Thanks, Craig On Apr 6, 2006, at 7:34 AM, Michael Bouschen wrote: Hi Cra

Re: TCK completeness interface

2006-04-06 Thread Erik Bengtson
Hi I have a patch here for some issues. It may be useful or not for you. There are other issues that I'm working on. Index: D:/jdo/trunk/tck20/src/java/org/apache/jdo/tck/pc/company/Department.java === --- D:/jdo/trunk/tck20/src/java

[jira] Commented: (JDO-363) Add links to site to JIRA filters for open and closed issues by release

2006-04-06 Thread Michelle Caisse (JIRA)
[ http://issues.apache.org/jira/browse/JDO-363?page=comments#action_12373515 ] Michelle Caisse commented on JDO-363: - I have created the JIRA filters to which we can link from the JDO web site. Please check them out to see if the search criteria are th

Re: TCK completeness interface

2006-04-06 Thread Craig L Russell
Hi Erik, Thanks for your efforts here in debugging the TCK. We had anticipated the issues you found, but were unable to test our implementation of the comparison methods without an implementation of the interfaces that weren't also implementations of the classes. Michael and I are working

[jira] Created: (JDO-364) Completness tests fail with generated implementation classes for interfaces

2006-04-06 Thread Craig Russell (JIRA)
Completness tests fail with generated implementation classes for interfaces --- Key: JDO-364 URL: http://issues.apache.org/jira/browse/JDO-364 Project: JDO Type: Bug Components: tck20 Ve

[jira] Commented: (JDO-364) Completness tests fail with generated implementation classes for interfaces

2006-04-06 Thread Craig Russell (JIRA)
[ http://issues.apache.org/jira/browse/JDO-364?page=comments#action_12373529 ] Craig Russell commented on JDO-364: --- The implementation of the static compare methods in each class might delegate to a common static method in EqualityHelper to do the compari

[jira] Updated: (JDO-364) Completness tests fail with generated implementation classes for interfaces

2006-04-06 Thread Michael Bouschen (JIRA)
[ http://issues.apache.org/jira/browse/JDO-364?page=all ] Michael Bouschen updated JDO-364: - Attachment: JDO-364.patch Attached you find a patch (JDO-364.patch) implementing the proposed compare changes. I added the static compare helper method to the E

JDO TCK Conference Call Friday, Apr 7, 9 am PST

2006-04-06 Thread Michelle Caisse
Hi, We will have our regular meeting Friday, April 7 at 9 am PST to discuss JDO TCK issues and status. Dial-in numbers are: 866 230-6968 294-0479# International: +1 865 544-7856 Agenda: 1. The last issues - JDO-327, JDO-364 (Craig, Michael, Erik) 2. Web site tasks (Michelle, Craig) 3. Step

Re: TCK completeness interface

2006-04-06 Thread Michael Bouschen
Hi Craig, Hi Erik, Thanks for your efforts here in debugging the TCK. We had anticipated the issues you found, but were unable to test our implementation of the comparison methods without an implementation of the interfaces that weren't also implementations of the classes. Michael and I are

[jira] Commented: (JDO-364) Completness tests fail with generated implementation classes for interfaces

2006-04-06 Thread Craig Russell (JIRA)
[ http://issues.apache.org/jira/browse/JDO-364?page=comments#action_12373551 ] Craig Russell commented on JDO-364: --- Nice. Just one comment. The javadoc for the static compare methods have the description appropriate for compareTo, not compare. +/**