Re: [VOTE]: Should FetchPlan.getGroups return a copy or a reference?

[X] Require the jdo implementation to return a read-only copy of the underlying Set of groups as it exists at the time of the call. FetchPlan.getGroups() should be a state investigation, keeping the state read-only with no more change from either inside or outside. --- Craig L Russell <[EMAIL PRO

Re: [VOTE]: Should FetchPlan.getGroups return a copy or a reference?

[X] Require the jdo implementation to return a read-only reference to the underlying implementation that will continue to track modifications made to the Set of groups. + requires the Set to be the same reference after clearGroups() Quoting Craig L Russell <[EMAIL PROTECTED]>: > Javadogs, > > Du

Re: [VOTE]: Should FetchPlan.getGroups return a copy or a reference?

Personally I prefer: [] Require the jdo implementation to return a read-only copy of the underlying Set of groups as it exists at the time of the call. But anything else is also acceptable, except: [ ] Require the jdo implementation to return a read-only reference to the underlying imple

[jira] Updated: (JDO-394) org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManager.test() and org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerForUser.test() don't c

[ http://issues.apache.org/jira/browse/JDO-394?page=all ] Michael Bouschen updated JDO-394: - Attachment: JDO-394.patch Attached you find a patch (JDO-394.patch) adding pmf.close to the finally block and does some more code cleanup. I found a similar i

[jira] Resolved: (JDO-400) IsTransactionalFalse - Should work with optimistic transactions?

[ http://issues.apache.org/jira/browse/JDO-400?page=all ] Craig Russell resolved JDO-400. --- Resolution: Fixed svn commit -m "JDO-400 Set transaction type to datastore explicitly so instance read becomes transactional" src/java/org/apache/jdo/tck/api/jdohe

[jira] Assigned: (JDO-394) org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManager.test() and org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerForUser.test() don't

[ http://issues.apache.org/jira/browse/JDO-394?page=all ] Michael Bouschen reassigned JDO-394: Assignee: Michael Bouschen > org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManager.test() > and > org.apache.jdo.tck.api.persistencemana

[VOTE]: Should FetchPlan.getGroups return a copy or a reference?

Javadogs,During testing of FetchPlan, Ilan Kirsh discovered that the jdo specification doesn't specify whether getGroups returns a read-only copy of the set of fetch groups or can return a read-only reference to the actual set of fetch groups. [The specification does require returning a read-only S

[jira] Commented: (JDO-400) IsTransactionalFalse - Should work with optimistic transactions?

[ http://issues.apache.org/jira/browse/JDO-400?page=comments#action_12424420 ] Michael Bouschen commented on JDO-400: -- The patch looks good! > IsTransactionalFalse - Should work with optimistic transactions? > --

[jira] Commented: (JDO-402) checkRemoveGroup - removeGroup should be before getGroups

[ http://issues.apache.org/jira/browse/JDO-402?page=comments#action_12424399 ] Andy Jefferson commented on JDO-402: The spec isnt totally silent (12.7.5 comment line in the code for getGroups). Erik asked the question on the mailing list on

[jira] Commented: (JDO-402) checkRemoveGroup - removeGroup should be before getGroups

[ http://issues.apache.org/jira/browse/JDO-402?page=comments#action_12424397 ] Craig Russell commented on JDO-402: --- The spec is silent on whether the return can be a "live" object. I had assumed that it was not shared but copied (all other "va