[GitHub] [db-jdo] clr-apache merged pull request #73: Update PropertyUtils.java

2023-04-04 Thread via GitHub
clr-apache merged PR #73: URL: https://github.com/apache/db-jdo/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [db-jdo] 01/01: Update PropertyUtils.java

2023-04-04 Thread Michael Bouschen
Hi Craig, you need to login into github in order to see the error messages Tobias mentioned. Checking the code formatting is a separate task from running the TCK with Java 8, Java 11 and Java 17. The code formatting check task uses Java 11 to run the code formatter. So this action never runs

[GitHub] [db-jdo] sonarcloud[bot] commented on pull request #73: Update PropertyUtils.java

2023-04-04 Thread via GitHub
sonarcloud[bot] commented on PR #73: URL: https://github.com/apache/db-jdo/pull/73#issuecomment-1496338683 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [db-jdo] sonarcloud[bot] commented on pull request #73: Update PropertyUtils.java

2023-04-04 Thread via GitHub
sonarcloud[bot] commented on PR #73: URL: https://github.com/apache/db-jdo/pull/73#issuecomment-1496268741 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [db-jdo] 01/01: Update PropertyUtils.java

2023-04-04 Thread Tobias Bouschen
Hi Craig, I am not sure what you mean. When I look at the GitHub action, the formatting job fails as expected. It tells you which fails are formatted incorrectly. Here is the excerpt from the GitHub action logs for your PR: Error: Found 1 non-complying files, failing build Error: To fix

Re: [db-jdo] 01/01: Update PropertyUtils.java

2023-04-04 Thread Craig Russell
Hi Michael, > On Apr 4, 2023, at 01:50, Michael Bouschen wrote: > > Hi Craig, > > the maven plugin running the formatter requires Java 11 or higher: > Detected JDK Version: 1.8.0-331 is not in the allowed range [11,) > > So if you want to check the formatting or want to reformat the code

Re: [db-jdo] 01/01: Update PropertyUtils.java

2023-04-04 Thread Michael Bouschen
Hi Craig, the maven plugin running the formatter requires Java 11 or higher:   Detected JDK Version: 1.8.0-331 is not in the allowed range [11,) So if you want to check the formatting or want to reformat the code you need to install Java 11. We discussed this (the formatter needs Javav 11 or

Re: [db-jdo] 01/01: Update PropertyUtils.java

2023-04-04 Thread Tilmann Zäschke
I had the same problem (1.8.0-331 is not in the allowed range [11,).) My simple workaround was to use Java 11 (or later) to run the tool. You can also try autoformatting from your IDE, just check that it formats only what you want to be changed. But I agree that we should probably discuss