Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

2023-11-18 Thread via GitHub
sonarcloud[bot] commented on PR #85: URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817586768 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

2023-11-18 Thread via GitHub
mboapache commented on PR #85: URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817585647 1. About the test log output: this is what I have mentioned before, you should print the output using more -R or less -R. If we do not like this output, then we need to find a JUnit

[GH] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

2023-11-18 Thread via GitHub
mboapache commented on code in PR #85: URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398242075 ## tck/src/main/java/org/apache/jdo/tck/util/ResultSummary.java: ## @@ -36,9 +37,14 @@ public class ResultSummary implements Serializable { /** The name of the file to

[GH] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

2023-11-18 Thread via GitHub
mboapache commented on code in PR #85: URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398241937 ## tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java: ## @@ -35,29 +36,23 @@ public class IsDetached extends DetachTest { private static final String

[GH] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

2023-11-18 Thread via GitHub
mboapache commented on code in PR #85: URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398237350 ## tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java: ## @@ -35,29 +36,23 @@ public class IsDetached extends DetachTest { private static final String

[GH] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

2023-11-18 Thread via GitHub
mboapache commented on code in PR #85: URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398237350 ## tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java: ## @@ -35,29 +36,23 @@ public class IsDetached extends DetachTest { private static final String

Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

2023-11-18 Thread via GitHub
tzaeschke commented on PR #85: URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817496798 A failed test looks like this: [app-relationshipAllRelationships-junit.txt](https://github.com/apache/db-jdo/files/13400258/app-relationshipAllRelationships-junit.txt) -- This is an

Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

2023-11-18 Thread via GitHub
tzaeschke commented on PR #85: URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817493730 For me the test log output is scrambled. For example the file `app-company1-1Relationships-junit.txt` looks like this: ``` . '-- JUnit Jupiter

[GH] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

2023-11-18 Thread via GitHub
tzaeschke commented on code in PR #85: URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398193849 ## tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java: ## @@ -35,29 +36,23 @@ public class IsDetached extends DetachTest { private static final String