[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2017-01-06 Thread Craig L Russell (JIRA)
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805064#comment-15805064 ] Craig L Russell commented on JDO-735: - A14.6.7-2 [This method closes all results of execu

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2017-01-06 Thread Craig L Russell (JIRA)
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805058#comment-15805058 ] Craig L Russell commented on JDO-735: - We need assertions for these test cases. So we n

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2016-11-25 Thread Michael Bouschen (JIRA)
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15696378#comment-15696378 ] Michael Bouschen commented on JDO-735: -- Need a tck test for try-with-resources for Exten

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2016-11-04 Thread Craig L Russell (JIRA)
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637513#comment-15637513 ] Craig L Russell commented on JDO-735: - There are several competing interests here: 1. Di

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2016-10-29 Thread Craig L Russell (JIRA)
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15618729#comment-15618729 ] Craig L Russell commented on JDO-735: - Now that PersistenceManager is done, we can resolv

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2016-10-28 Thread JIRA
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616051#comment-15616051 ] Tilmann Zäschke commented on JDO-735: - In theory, I could imagine that a database server

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2016-10-07 Thread Craig L Russell (JIRA)
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1583#comment-1583 ] Craig L Russell commented on JDO-735: - I think the isClosed method only makes sense if th

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2016-08-20 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429359#comment-15429359 ] Andy Jefferson commented on JDO-735: Perhaps Extent should also be AutoCloseable? Perha

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2015-09-11 Thread Michael Bouschen (JIRA)
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741106#comment-14741106 ] Michael Bouschen commented on JDO-735: -- Looks good. Should we keep the test class Close

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2015-08-26 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712782#comment-14712782 ] Andy Jefferson commented on JDO-735: Test now in SVN, along with another for AutoCloseabl

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2015-06-04 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572482#comment-14572482 ] Andy Jefferson commented on JDO-735: Changing the spec will mean the TCK Test org.apache

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2015-05-17 Thread Craig L Russell (JIRA)
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547328#comment-14547328 ] Craig L Russell commented on JDO-735: - "In a non-managed environment, if the current tran

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2015-05-16 Thread JIRA
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547036#comment-14547036 ] Tilmann Zäschke commented on JDO-735: - +1 for rolling back active transactions on close()

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2015-05-15 Thread Craig L Russell (JIRA)
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546158#comment-14546158 ] Craig L Russell commented on JDO-735: - Oops. This is in 12.6: In a non-managed environme

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2015-05-15 Thread Craig L Russell (JIRA)
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545765#comment-14545765 ] Craig L Russell commented on JDO-735: - The specification is silent on the subject of PM.c

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2015-05-11 Thread JIRA
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537966#comment-14537966 ] Tilmann Zäschke commented on JDO-735: - I just realised that auto-close will re-throw the

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2015-05-11 Thread JIRA
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537942#comment-14537942 ] Tilmann Zäschke commented on JDO-735: - Apologies for commenting so late. I see a small pr

[jira] [Commented] (JDO-735) Make PersistenceManager and Query support AutoCloseable (JDK1.7+)

2015-04-30 Thread Andy Jefferson (JIRA)
[ https://issues.apache.org/jira/browse/JDO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521023#comment-14521023 ] Andy Jefferson commented on JDO-735: SVN updated to add AutoCloseable to PersistenceManag