[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15773317#comment-15773317
]
Craig L Russell commented on JDO-751:
-
Looks good. For me, it's good to check in.
> Sup
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755672#comment-15755672
]
Craig L Russell commented on JDO-751:
-
Patch looks good, including the new aggregate tes
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367845#comment-15367845
]
Craig L Russell commented on JDO-751:
-
I'm still not convinced that optionalPC.orElse(any
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367840#comment-15367840
]
Craig L Russell commented on JDO-751:
-
Starting to work on the specification:
Persistent
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346784#comment-15346784
]
Andy Jefferson commented on JDO-751:
1. I said DN equates a transient to null (nothing el
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346743#comment-15346743
]
Tilmann Zäschke commented on JDO-751:
-
1. About not being able to handle transient PCs, w
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339802#comment-15339802
]
Andy Jefferson commented on JDO-751:
1. You use "this.optionalPC.orElse(otherPcParam) ==
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338646#comment-15338646
]
Tilmann Zäschke commented on JDO-751:
-
Thanks for the feedback.
1. Yes, you are right, an
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337814#comment-15337814
]
Andy Jefferson commented on JDO-751:
Comments from cursory scan of the patch
1. You use a
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315498#comment-15315498
]
Tilmann Zäschke commented on JDO-751:
-
As mentioned in the telecon, I found that the quer
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314463#comment-15314463
]
Tilmann Zäschke commented on JDO-751:
-
While writing the unit test, I came up with the fo
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244689#comment-15244689
]
Tilmann Zäschke commented on JDO-751:
-
Interesting. I had tried it with variables, but th
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243188#comment-15243188
]
Craig L Russell commented on JDO-751:
-
Just looked again at the class file metadata avail
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243176#comment-15243176
]
Craig L Russell commented on JDO-751:
-
Tilmann: It might make more sense simply to say th
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224000#comment-15224000
]
Tilmann Zäschke commented on JDO-751:
-
I just realise that throwing an exception during e
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221921#comment-15221921
]
Craig L Russell commented on JDO-751:
-
Regarding Optional>
I think we should throw Stupi
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170485#comment-15170485
]
Tilmann Zäschke commented on JDO-751:
-
The argument or supporting {{orElse()}} would be t
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155124#comment-15155124
]
Renato Garcia commented on JDO-751:
---
{quote}
MemberMetadata.getFieldType should return "Opt
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155121#comment-15155121
]
Renato Garcia commented on JDO-751:
---
{quote}
I also think (as I mentioned earlier) properti
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154475#comment-15154475
]
Craig L Russell commented on JDO-751:
-
I'd like to think how to accommodate object databa
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154457#comment-15154457
]
Craig L Russell commented on JDO-751:
-
Having begun to work with JavaScript over the last
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153925#comment-15153925
]
Tilmann Zäschke commented on JDO-751:
-
{quote}
{{Optional.get}} will never give you back
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153660#comment-15153660
]
Renato Garcia commented on JDO-751:
---
{quote}
I still don't get the difference between empty
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152861#comment-15152861
]
Craig L Russell commented on JDO-751:
-
Here's another try at a solution.
Optional is a
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152197#comment-15152197
]
Tilmann Zäschke commented on JDO-751:
-
@Craig
Sorry, I think overlooked your post.
You ra
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152165#comment-15152165
]
Tilmann Zäschke commented on JDO-751:
-
I still don't get the difference between empty and
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146467#comment-15146467
]
Renato Garcia commented on JDO-751:
---
Treating it just as T on the APIs/query would require
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146400#comment-15146400
]
Renato Garcia commented on JDO-751:
---
[~apacheb...@tkuhn.de]
I've edited to my comment to cl
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146397#comment-15146397
]
Renato Garcia commented on JDO-751:
---
What about the type of the returned field in the JDOQL
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146301#comment-15146301
]
Craig L Russell commented on JDO-751:
-
I'd suggest we consider a field of type Optional t
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145294#comment-15145294
]
Renato Garcia commented on JDO-751:
---
{quote}I think it is related because auto-dereferencin
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145293#comment-15145293
]
Renato Garcia commented on JDO-751:
---
{quote}Fun question (not a likely use-case): How do we
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145027#comment-15145027
]
Tilmann Zäschke commented on JDO-751:
-
Maybe it should also be considered whether JDO may
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144996#comment-15144996
]
Tilmann Zäschke commented on JDO-751:
-
Just to repeat what was send at the end of the tel
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144615#comment-15144615
]
Tilmann Zäschke commented on JDO-751:
-
??How is this related to the "shortcuts" changing
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144601#comment-15144601
]
Tilmann Zäschke commented on JDO-751:
-
I completely agree, that defeats the purpose of {{
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144519#comment-15144519
]
Renato Garcia commented on JDO-751:
---
I don't think Optional can reference null, it's either
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144516#comment-15144516
]
Renato Garcia commented on JDO-751:
---
In case we would like to make it not ambiguous in JDOQ
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144507#comment-15144507
]
Renato Garcia commented on JDO-751:
---
You shouldn't have null references when using Optional
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144485#comment-15144485
]
Tilmann Zäschke commented on JDO-751:
-
I don't think querying for {{null}} is conceptuall
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144474#comment-15144474
]
Tilmann Zäschke commented on JDO-751:
-
I think there still is a problem when writing {{po
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144287#comment-15144287
]
Renato Garcia commented on JDO-751:
---
Regarding "shortcuts", I don't see why they change sem
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144286#comment-15144286
]
Renato Garcia commented on JDO-751:
---
What would be the type of the parameter for a variable
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143012#comment-15143012
]
Craig L Russell commented on JDO-751:
-
I'd like to propose that Optional be strictly a pe
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142722#comment-15142722
]
Tilmann Zäschke commented on JDO-751:
-
??perhaps it should be also true that querying wit
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142108#comment-15142108
]
Renato Garcia commented on JDO-751:
---
{quote}
But what happens in your example if foo is a v
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140715#comment-15140715
]
Tilmann Zäschke commented on JDO-751:
-
But what happens in your example if {{foo}} is a v
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140104#comment-15140104
]
Renato Garcia commented on JDO-751:
---
{quote}
Just to clarify the first question: I see that
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138608#comment-15138608
]
Tilmann Zäschke commented on JDO-751:
-
I completely agree with the answers.
Just to clari
[
https://issues.apache.org/jira/browse/JDO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138522#comment-15138522
]
Andy Jefferson commented on JDO-751:
>From Apache JDO "minutes"
Q. Does it make sense t
50 matches
Mail list logo
