Re: Rename property PersistenceUnitName to Name

2007-06-07 Thread Andy Jefferson
Hi Craig, > This part of the use case was not in mind when I wrote the change > request. The user asks for PMF by name "MyPMF" but then the > PersistenceUnitName in MyPMF refers to a PersistenceUnit in the > persistence.xml. > > Is that what JPOX does with the PersistenceUnitName today? JPOX curr

Re: Rename property PersistenceUnitName to Name

2007-06-06 Thread Craig L Russell
Hi Andy, Thanks for raising these questions. On Jun 5, 2007, at 11:12 PM, Andy Jefferson wrote: On 6 June 2007 07:04, Andy Jefferson wrote: I now believe that the "PersistenceUnit" part of the property name is distracting, and the real property name should be simply "Name". That is, Persi

Re: Rename property PersistenceUnitName to Name

2007-06-05 Thread Andy Jefferson
On 6 June 2007 07:04, Andy Jefferson wrote: > > I now believe that the "PersistenceUnit" part of the property name is > > distracting, and the real property name should be simply "Name". That > > is, PersistenceManagerFactories can have a Name property. The javadoc > > and other documentation can

Re: Rename property PersistenceUnitName to Name

2007-06-05 Thread Andy Jefferson
> I now believe that the "PersistenceUnit" part of the property name is > distracting, and the real property name should be simply "Name". That > is, PersistenceManagerFactories can have a Name property. The javadoc > and other documentation can call out that this name is the same as > the Persiste

Re: Rename property PersistenceUnitName to Name

2007-06-05 Thread Matthew T. Adams
Christian Ernst <[EMAIL PROTECTED]> To: Craig L Russell <[EMAIL PROTECTED]> Cc: JDO Expert Group <[EMAIL PROTECTED]>; Apache JDO project Sent: Tuesday, June 5, 2007 8:50:00 PM Subject: Re: Rename property PersistenceUnitName to Name Craig L Russell wrote: > It seems that

Re: Rename property PersistenceUnitName to Name

2007-06-05 Thread Matthew T. Adams
#x27;ll make a patch? - Original Message From: Craig L Russell <[EMAIL PROTECTED]> To: JDO Expert Group <[EMAIL PROTECTED]>; Apache JDO project Sent: Tuesday, June 5, 2007 5:46:19 PM Subject: Rename property PersistenceUnitName to Name It seems that we added PersistenceUnitName to

Re: Rename property PersistenceUnitName to Name

2007-06-05 Thread Christian Ernst
Craig L Russell wrote: It seems that we added PersistenceUnitName to the PersistenceManagerFactory before completely understanding the usage, which primarily is to assign a name when configuring the PMF via jdoconfig. I now believe that the "PersistenceUnit" part of the property name is dist

Rename property PersistenceUnitName to Name

2007-06-05 Thread Craig L Russell
It seems that we added PersistenceUnitName to the PersistenceManagerFactory before completely understanding the usage, which primarily is to assign a name when configuring the PMF via jdoconfig. I now believe that the "PersistenceUnit" part of the property name is distracting, and the rea