tzaeschke commented on PR #61:
URL: https://github.com/apache/db-jdo/pull/61#issuecomment-1407688135
I filed a ticket for the Datanucleus reference implementation:
https://github.com/datanucleus/datanucleus-api-jdo/issues/127
--
This is an automated message from the Apache Git Service.
To
sonarcloud[bot] commented on PR #68:
URL: https://github.com/apache/db-jdo/pull/68#issuecomment-1414114735
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #68:
URL: https://github.com/apache/db-jdo/pull/68#issuecomment-1414328038
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
mboapache merged PR #68:
URL: https://github.com/apache/db-jdo/pull/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
tzaeschke opened a new pull request, #69:
URL: https://github.com/apache/db-jdo/pull/69
Remove code smells of type: nested try-catch.
See https://issues.apache.org/jira/browse/JDO-823.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
sonarcloud[bot] commented on PR #69:
URL: https://github.com/apache/db-jdo/pull/69#issuecomment-1450884853
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #69:
URL: https://github.com/apache/db-jdo/pull/69#issuecomment-1450889770
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
mboapache commented on PR #69:
URL: https://github.com/apache/db-jdo/pull/69#issuecomment-1454827446
The PR looks good, I just added a minor comment above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
sonarcloud[bot] commented on PR #70:
URL: https://github.com/apache/db-jdo/pull/70#issuecomment-1455192676
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #69:
URL: https://github.com/apache/db-jdo/pull/69#issuecomment-1462627621
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
mboapache merged PR #70:
URL: https://github.com/apache/db-jdo/pull/70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
tzaeschke merged PR #69:
URL: https://github.com/apache/db-jdo/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
sonarcloud[bot] commented on PR #71:
URL: https://github.com/apache/db-jdo/pull/71#issuecomment-1462682826
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
tzaeschke merged PR #71:
URL: https://github.com/apache/db-jdo/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
tzaeschke opened a new pull request, #72:
URL: https://github.com/apache/db-jdo/pull/72
Remove unused local variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
sonarcloud[bot] commented on PR #72:
URL: https://github.com/apache/db-jdo/pull/72#issuecomment-1490850995
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #72:
URL: https://github.com/apache/db-jdo/pull/72#issuecomment-1490859079
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
clr-apache opened a new pull request, #73:
URL: https://github.com/apache/db-jdo/pull/73
JDO-819 Fix code smells
Use "Arrays.copyOf", "Arrays.asList", "Collections.addAll" or
"System.arraycopy" instead.
--
This is an automated message from the Apache Git Service.
To respond to the mess
sonarcloud[bot] commented on PR #73:
URL: https://github.com/apache/db-jdo/pull/73#issuecomment-1493455267
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #73:
URL: https://github.com/apache/db-jdo/pull/73#issuecomment-1495138879
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #73:
URL: https://github.com/apache/db-jdo/pull/73#issuecomment-1496268741
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #73:
URL: https://github.com/apache/db-jdo/pull/73#issuecomment-1496338683
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
clr-apache merged PR #73:
URL: https://github.com/apache/db-jdo/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.or
tzaeschke merged PR #72:
URL: https://github.com/apache/db-jdo/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
tzaeschke opened a new pull request, #74:
URL: https://github.com/apache/db-jdo/pull/74
Remove claim that @Convert can be put on types. See
https://issues.apache.org/jira/browse/JDO-826.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
sonarcloud[bot] commented on PR #74:
URL: https://github.com/apache/db-jdo/pull/74#issuecomment-1500862018
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
tobous opened a new pull request, #75:
URL: https://github.com/apache/db-jdo/pull/75
This PR changes the behavior of `toString()` and `printStackTrace(...)`.
To avoid duplication in the `printStackTrace()`, the nested exceptions are
no longer printed as part of the `toString()`.
sonarcloud[bot] commented on PR #75:
URL: https://github.com/apache/db-jdo/pull/75#issuecomment-1513918820
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
tobous closed pull request #75: JDO-823 - Make JDOException immutable
URL: https://github.com/apache/db-jdo/pull/75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
tobous commented on PR #75:
URL: https://github.com/apache/db-jdo/pull/75#issuecomment-1516770471
Rejected. Old behavior is preferred. `JDOException` being mutable is too low
of an issue for the larger rework necessary to replicate the old behavior while
keeping the class immutable.
--
T
tzaeschke merged PR #74:
URL: https://github.com/apache/db-jdo/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
tobous opened a new pull request, #76:
URL: https://github.com/apache/db-jdo/pull/76
Make all fields in JDOException final. Explicitly excludes
'inPrintStackTrace' as it is needed for some state tracking. Makes it
'transient' instead.
--
This is an automated message from the Apache Git S
sonarcloud[bot] commented on PR #76:
URL: https://github.com/apache/db-jdo/pull/76#issuecomment-1516777040
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
tzaeschke merged PR #76:
URL: https://github.com/apache/db-jdo/pull/76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
sonarcloud[bot] commented on PR #77:
URL: https://github.com/apache/db-jdo/pull/77#issuecomment-1542764187
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #77:
URL: https://github.com/apache/db-jdo/pull/77#issuecomment-1542766426
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
mboapache merged PR #77:
URL: https://github.com/apache/db-jdo/pull/77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
tobous opened a new pull request, #78:
URL: https://github.com/apache/db-jdo/pull/78
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jd
tobous opened a new pull request, #47:
URL: https://github.com/apache/db-jdo-site/pull/47
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
sonarcloud[bot] commented on PR #78:
URL: https://github.com/apache/db-jdo/pull/78#issuecomment-1575656329
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
tobous opened a new pull request, #48:
URL: https://github.com/apache/db-jdo-site/pull/48
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
tobous opened a new pull request, #79:
URL: https://github.com/apache/db-jdo/pull/79
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jd
sonarcloud[bot] commented on PR #79:
URL: https://github.com/apache/db-jdo/pull/79#issuecomment-1575670686
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
clr-apache commented on PR #47:
URL: https://github.com/apache/db-jdo-site/pull/47#issuecomment-1575812666
Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
clr-apache commented on PR #48:
URL: https://github.com/apache/db-jdo-site/pull/48#issuecomment-1575823651
I can't say I understand this, but have no objections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
tzaeschke commented on PR #48:
URL: https://github.com/apache/db-jdo-site/pull/48#issuecomment-1576280938
LGTM
> I can't say I understand this, but have no objections.
More about removal of deprecated commands:
https://github.blog/changelog/2022-10-11-github-actions-deprecat
tzaeschke commented on PR #47:
URL: https://github.com/apache/db-jdo-site/pull/47#issuecomment-1576281468
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
tobous merged PR #78:
URL: https://github.com/apache/db-jdo/pull/78
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
F
tobous merged PR #47:
URL: https://github.com/apache/db-jdo-site/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.o
tobous merged PR #79:
URL: https://github.com/apache/db-jdo/pull/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
F
tobous merged PR #48:
URL: https://github.com/apache/db-jdo-site/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.o
mboapache opened a new pull request, #80:
URL: https://github.com/apache/db-jdo/pull/80
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #80:
URL: https://github.com/apache/db-jdo/pull/80#issuecomment-1611870703
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #81:
URL: https://github.com/apache/db-jdo/pull/81#issuecomment-1613252562
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #81:
URL: https://github.com/apache/db-jdo/pull/81#issuecomment-1613254212
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #81:
URL: https://github.com/apache/db-jdo/pull/81#issuecomment-1613262742
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #81:
URL: https://github.com/apache/db-jdo/pull/81#issuecomment-1613470334
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #80:
URL: https://github.com/apache/db-jdo/pull/80#issuecomment-1613674570
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
tzaeschke commented on code in PR #80:
URL: https://github.com/apache/db-jdo/pull/80#discussion_r1247017440
##
api/src/test/java/javax/jdo/PMFMapMapTest.java:
##
@@ -40,18 +41,14 @@ public class PMFMapMapTest extends AbstractJDOConfigTest {
private static final String PMF_SER
sonarcloud[bot] commented on PR #80:
URL: https://github.com/apache/db-jdo/pull/80#issuecomment-1613683840
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #81:
URL: https://github.com/apache/db-jdo/pull/81#issuecomment-1614404589
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #81:
URL: https://github.com/apache/db-jdo/pull/81#issuecomment-1614490566
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
mboapache merged PR #80:
URL: https://github.com/apache/db-jdo/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
sonarcloud[bot] commented on PR #81:
URL: https://github.com/apache/db-jdo/pull/81#issuecomment-1624146331
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
tzaeschke merged PR #81:
URL: https://github.com/apache/db-jdo/pull/81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
mboapache opened a new pull request, #82:
URL: https://github.com/apache/db-jdo/pull/82
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #82:
URL: https://github.com/apache/db-jdo/pull/82#issuecomment-1627466461
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
tzaeschke opened a new pull request, #83:
URL: https://github.com/apache/db-jdo/pull/83
As part of https://issues.apache.org/jira/browse/JDO-823, this PR attempt to
clean up code issues in the `Enhancer`.
Specifically:
- [x] Reduce code complexity of `execute()`. Done.
- [ ] ~~Fix p
sonarcloud[bot] commented on PR #83:
URL: https://github.com/apache/db-jdo/pull/83#issuecomment-1628800957
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #83:
URL: https://github.com/apache/db-jdo/pull/83#issuecomment-1628806607
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
mboapache merged PR #82:
URL: https://github.com/apache/db-jdo/pull/82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
sonarcloud[bot] commented on PR #83:
URL: https://github.com/apache/db-jdo/pull/83#issuecomment-1637032727
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #83:
URL: https://github.com/apache/db-jdo/pull/83#issuecomment-1637037832
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
fa
sonarcloud[bot] commented on PR #83:
URL: https://github.com/apache/db-jdo/pull/83#issuecomment-1644423598
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #83:
URL: https://github.com/apache/db-jdo/pull/83#issuecomment-167685
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
tzaeschke merged PR #83:
URL: https://github.com/apache/db-jdo/pull/83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
tobous opened a new pull request, #84:
URL: https://github.com/apache/db-jdo/pull/84
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jd
sonarcloud[bot] commented on PR #84:
URL: https://github.com/apache/db-jdo/pull/84#issuecomment-1777490176
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
clr-apache commented on PR #84:
URL: https://github.com/apache/db-jdo/pull/84#issuecomment-1778204772
Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
tobous merged PR #84:
URL: https://github.com/apache/db-jdo/pull/84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
F
mboapache opened a new pull request, #85:
URL: https://github.com/apache/db-jdo/pull/85
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1794402762
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
tzaeschke commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1383891081
##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -140,37 +141,178 @@ private String getTrimmedPropertyValue(Properties props,
String key) {
return
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387168344
##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -140,37 +141,178 @@ private String getTrimmedPropertyValue(Properties props,
String key) {
return
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387172217
##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -263,231 +396,261 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
}
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387252360
##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -263,231 +396,261 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
}
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387254461
##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -528,13 +693,14 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
sonarcloud[bot] commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1804648411
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
tzaeschke commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398193849
##
tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java:
##
@@ -35,29 +36,23 @@ public class IsDetached extends DetachTest {
private static final String A
tzaeschke commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817493730
For me the test log output is scrambled. For example the file
`app-company1-1Relationships-junit.txt` looks like this:
```
[36m.[0m
[36m'--[0m [36mJUnit Jupiter[0m [32m[OK
tzaeschke commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817496798
A failed test looks like this:
[app-relationshipAllRelationships-junit.txt](https://github.com/apache/db-jdo/files/13400258/app-relationshipAllRelationships-junit.txt)
--
This is an au
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398237350
##
tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java:
##
@@ -35,29 +36,23 @@ public class IsDetached extends DetachTest {
private static final String A
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398237350
##
tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java:
##
@@ -35,29 +36,23 @@ public class IsDetached extends DetachTest {
private static final String A
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398241937
##
tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java:
##
@@ -35,29 +36,23 @@ public class IsDetached extends DetachTest {
private static final String A
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398242075
##
tck/src/main/java/org/apache/jdo/tck/util/ResultSummary.java:
##
@@ -36,9 +37,14 @@ public class ResultSummary implements Serializable {
/** The name of the file to
mboapache commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817585647
1. About the test log output: this is what I have mentioned before, you
should print the output using more -R or less -R.
If we do not like this output, then we need to find a JUnit launc
sonarcloud[bot] commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817586768
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817963484
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
mboapache commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817966299
I found the problem of issues 2. and 3. from above: now the datanucleus
output is store in the -jdori.txt file and the logger output of the TCK test
classes go into the -tck.txt files. Fix i
tobous opened a new pull request, #86:
URL: https://github.com/apache/db-jdo/pull/86
Exports the logs of the different matrix builds as separate artifacts in
case the corresponding build fails.
Adjusts the matrix build to keep running if one of the builds fails.
Adjusts the mav
1 - 100 of 148 matches
Mail list logo