Branch: refs/heads/master
Home: https://github.com/jenkinsci/jobConfigHistory-plugin
Commit: 145c9d59bf61711c28e4158ace4695f37efaabad
https://github.com/jenkinsci/jobConfigHistory-plugin/commit/145c9d59bf61711c28e4158ace4695f37efaabad
Author: Mykola Nikishov <m...@mn.com.ua>
Date: 2019-02-05 (Tue, 05 Feb 2019)
Changed paths:
M
src/main/java/hudson/plugins/jobConfigHistory/ComputerConfigHistoryAction.java
M
src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryBaseAction.java
M
src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction.java
M
src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryRootAction.java
A src/main/resources/hudson/plugins/jobConfigHistory/xslt/sort.xslt
Log Message:
-----------
[JENKINS-41177] Reduce noise when showing diff between configs (#80)
* Extract method to build diff between two config files
There is no reason to duplicate the same steps to build list of diff
lines for two config files. Instead, extract this logic into a
separate method, pull it up to JobConfigHistoryBaseAction and let
three children of JobConfigHistoryBaseAction reuse it.
Signed-off-by: Mykola Nikishov <m...@mn.com.ua>
* [JENKINS-41177] Reduce noise when showing diff between configs
Instead of relying on core to store XML configs in a deterministic
way, Job Config History plugin adds an intermediate step before
converting XML to string representation and computing textual diff:
- sort XML elements and attributes alphabetically
- remove empty XML elements and attributes
This way list of changed lines is deterministic and contains minimal
semantically useless changes.
Signed-off-by: Mykola Nikishov <m...@mn.com.ua>
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
