Branch: refs/heads/master Home: https://github.com/jenkinsci/git-client-plugin Commit: e773980132742eafbdf9a9c416df46e03febe8b9 https://github.com/jenkinsci/git-client-plugin/commit/e773980132742eafbdf9a9c416df46e03febe8b9 Author: Mark Waite <markwa...@yahoo.com> Date: 2014-02-01 (Sat, 01 Feb 2014)
Changed paths: M pom.xml A src/findbugs/excludesFilter.xml Log Message: ----------- Add optional findbugs report generation Generate findbugs XML report with mvn findbugs:check Includes a findbugs exclude filter file Uses findbugs maven settings as modeled by Stephen Connolly in the literate build plugin. Commit: f150b6a97c34d2cdb4f3c6f17038cf4b47e65cde https://github.com/jenkinsci/git-client-plugin/commit/f150b6a97c34d2cdb4f3c6f17038cf4b47e65cde Author: Mark Waite <markwa...@yahoo.com> Date: 2014-02-01 (Sat, 01 Feb 2014) Changed paths: M src/main/java/hudson/plugins/git/GitAPI.java M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java M src/main/java/org/jenkinsci/plugins/gitclient/JGitAPIImpl.java M src/main/java/org/jenkinsci/plugins/gitclient/RemoteGitImpl.java Log Message: ----------- Use @NonNull annotation of getRepository method Better describes the contract between getRepository and its callers, and reduces findbugs output by declaring that contract. Commit: 8ba56634031fbd14ec0c2a0d0ab6054b69c1b7ff https://github.com/jenkinsci/git-client-plugin/commit/8ba56634031fbd14ec0c2a0d0ab6054b69c1b7ff Author: Mark Waite <markwa...@yahoo.com> Date: 2014-02-01 (Sat, 01 Feb 2014) Changed paths: M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java M src/main/java/org/jenkinsci/plugins/gitclient/JGitAPIImpl.java Log Message: ----------- Check return value of File.delete, log warning if file not deleted Logging a warning if a file is not deleted seems safe and will help locate cases where files are not being properly removed. Commit: 87ae868ecbd207c4703f52fdd186d8f1ae52b68d https://github.com/jenkinsci/git-client-plugin/commit/87ae868ecbd207c4703f52fdd186d8f1ae52b68d Author: Mark Waite <markwa...@yahoo.com> Date: 2014-02-01 (Sat, 01 Feb 2014) Changed paths: M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java M src/main/java/org/jenkinsci/plugins/gitclient/Git.java Log Message: ----------- Make TIMEOUT and USE_CLI final since they are values of properties Commit: ea3f2a25a890e74c37bd12295a12a6ff2e2149ba https://github.com/jenkinsci/git-client-plugin/commit/ea3f2a25a890e74c37bd12295a12a6ff2e2149ba Author: Mark Waite <markwa...@yahoo.com> Date: 2014-02-01 (Sat, 01 Feb 2014) Changed paths: M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java Log Message: ----------- Declare CliGitAPIImpl.launcher transient in case class or subclass is serialized Commit: ac8461d822c91657d82ae3dd89a9de3381f84455 https://github.com/jenkinsci/git-client-plugin/commit/ac8461d822c91657d82ae3dd89a9de3381f84455 Author: Mark Waite <markwa...@yahoo.com> Date: 2014-02-01 (Sat, 01 Feb 2014) Changed paths: M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java Log Message: ----------- Remove uncalled private method getGitCredentialsURL(String, String) Commit: 9202502a63a6b56cdaabf8ce8e1ee7c73376b6f6 https://github.com/jenkinsci/git-client-plugin/commit/9202502a63a6b56cdaabf8ce8e1ee7c73376b6f6 Author: Mark Waite <markwa...@yahoo.com> Date: 2014-02-01 (Sat, 01 Feb 2014) Changed paths: M src/main/java/hudson/plugins/git/GitTool.java M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java Log Message: ----------- Add serialVersionUID to two classes to fix findbugs warnings Commit: c5740efebb39ddb4b140463ac381e3a59509a57b https://github.com/jenkinsci/git-client-plugin/commit/c5740efebb39ddb4b140463ac381e3a59509a57b Author: Mark Waite <markwa...@yahoo.com> Date: 2014-02-01 (Sat, 01 Feb 2014) Changed paths: M src/main/java/org/jenkinsci/plugins/gitclient/ProgressMonitor.java Log Message: ----------- Remove unread field from ProgressMonitor implementation Fix findbugs warning Commit: ab2302a424f67c8ff2a81ff7d5f0e550475a0409 https://github.com/jenkinsci/git-client-plugin/commit/ab2302a424f67c8ff2a81ff7d5f0e550475a0409 Author: Mark Waite <markwa...@yahoo.com> Date: 2014-02-01 (Sat, 01 Feb 2014) Changed paths: M src/findbugs/excludesFilter.xml Log Message: ----------- Filter the JGitAPIImpl load of known null value warning - findbugs is wrong Commit: eee5b5a3d2fad7fd768d34c17eb753b66041c97d https://github.com/jenkinsci/git-client-plugin/commit/eee5b5a3d2fad7fd768d34c17eb753b66041c97d Author: Nicolas De Loof <nicolas.del...@gmail.com> Date: 2014-02-04 (Tue, 04 Feb 2014) Changed paths: M pom.xml A src/findbugs/excludesFilter.xml M src/main/java/hudson/plugins/git/GitAPI.java M src/main/java/hudson/plugins/git/GitTool.java M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java M src/main/java/org/jenkinsci/plugins/gitclient/Git.java M src/main/java/org/jenkinsci/plugins/gitclient/JGitAPIImpl.java M src/main/java/org/jenkinsci/plugins/gitclient/ProgressMonitor.java M src/main/java/org/jenkinsci/plugins/gitclient/RemoteGitImpl.java Log Message: ----------- Merge remote-tracking branch 'mark/master-add-findbugs' Conflicts: src/main/java/org/jenkinsci/plugins/gitclient/JGitAPIImpl.java Compare: https://github.com/jenkinsci/git-client-plugin/compare/177334d627a1...eee5b5a3d2fa -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.