Branch: refs/heads/master
Home: https://github.com/jenkinsci/google-compute-engine-plugin
Commit: e2191d4b53d9ac97cca5d8f3cbff32b5d8cb449d
https://github.com/jenkinsci/google-compute-engine-plugin/commit/e2191d4b53d9ac97cca5d8f3cbff32b5d8cb449d
Author: Stephen Shank <stephensh...@google.com>
Date: 2019-06-04 (Tue, 04 Jun 2019)
Changed paths:
M
src/main/java/com/google/jenkins/plugins/computeengine/ComputeEngineComputerLauncher.java
M
src/main/java/com/google/jenkins/plugins/computeengine/ComputeEngineLinuxLauncher.java
M
src/main/java/com/google/jenkins/plugins/computeengine/ComputeEngineWindowsLauncher.java
Log Message:
-----------
Issue #104: Check java before copying agent jar (#105)
* Refactor to perform launch preparation in common method
* First check java version, then copy agent jar.
* PR feedback: Remove tight coupling by using abstract method instead.
* PR Feedback: Separate concerns for preparing java launch string.
* Make launch methods nearly identical by factoring out connection setup logic.
* Consolidate into one method on the ComputeEngineComputerLauncher.
* PR Feedback: De-duplicate logging methods, various cleanup of duplication and
unused code.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/google-compute-engine-plugin/push/refs/heads/master/ce5761-e2191d%40github.com.
For more options, visit https://groups.google.com/d/optout.
