Branch: refs/heads/master
Home: https://github.com/jenkinsci/pipeline-model-definition-plugin
Commit: 6bfbffd5260ed4f219cba21cdba809b205390e82
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/6bfbffd5260ed4f219cba21cdba809b205390e82
Author: Andrew Bayer <andrew.ba...@gmail.com>
Date: 2016-12-13 (Tue, 13 Dec 2016)
Changed paths:
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTBuildParameter.java
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTJobProperty.java
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTScriptBlock.java
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTTrigger.java
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTWrapper.java
M
pipeline-model-api/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorTest.java
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java
A
pipeline-model-definition/src/test/resources/errors/invalidParameterType.groovy
A
pipeline-model-definition/src/test/resources/errors/invalidPropertiesType.groovy
A
pipeline-model-definition/src/test/resources/errors/invalidTriggerType.groovy
Log Message:
-----------
[FIXED JENKINS-40418] Fix validation for a number of extended types
Turns out we do need validate methods on child classes - the parent
validate method will end up calling
validator.validateElement(ParentClass) which is...not what we
want. So, fixing that in a bunch of places and adding tests.
Also, added an expectError convenience method.
Commit: 1596f6e2f18321e7a79c42e0290b1c74b6a7912e
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/1596f6e2f18321e7a79c42e0290b1c74b6a7912e
Author: Andrew Bayer <andrew.ba...@gmail.com>
Date: 2016-12-14 (Wed, 14 Dec 2016)
Changed paths:
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTBuildParameter.java
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTJobProperty.java
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTScriptBlock.java
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTTrigger.java
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTWrapper.java
M
pipeline-model-api/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorTest.java
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java
A
pipeline-model-definition/src/test/resources/errors/invalidParameterType.groovy
A
pipeline-model-definition/src/test/resources/errors/invalidPropertiesType.groovy
A
pipeline-model-definition/src/test/resources/errors/invalidTriggerType.groovy
Log Message:
-----------
Merge pull request #68 from abayer/add-invalid-trigger-test
[FIXED JENKINS-40418] Fix validation for a number of extended types
Compare:
https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/6f1d9434eed8...1596f6e2f183
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
