Re: Need help designing a fix for JENKINS-50504

2018-04-02 Thread me
Hi Ivan, Thanks for your reply. I'm not exactly sure how my proposed workaround would necessarily cause concurrency issues. Doesn't that depend on how it's implemented? I agree that it's strange that the agent wasn't disconnected and still keeps the old connection to the master, even though new

Re: Discussion: New Custom Jenkins WAR packaging tool

2018-04-02 Thread Raul Arabaolaza
Sorry for being late to this... I agree with the proposed approach, the only thing that concerns me is that it seems you need to build the custom war locally so is installed on your local repo, now what happens with CI jobs that execute the PCT in parallel? All of them would need to locally bui

Re: java.nio.channels.ClosedByInterruptException when I click cancel button from a running job

2018-04-02 Thread Daniel Anechitoaie
I can provide whatever is needed. Would a stripped down version of the plugin with just the absolute minimal amount of code needed to replicate the issue be what is needed? And where should I provide this? I can put it on a new public GitHub repo? On Monday, April 2, 2018 at 8:27:58 PM UTC+3, J

Re: java.nio.channels.ClosedByInterruptException when I click cancel button from a running job

2018-04-02 Thread Jesse Glick
On Mon, Apr 2, 2018 at 12:07 PM, Daniel Anechitoaie wrote: > If I run my plugin just on master (so not inside a > MasterToSlaveCallable) it does get interrupted ok (not instantly but as soon > as zip operation is finished and without errors). > So my understanding is that maybe something in how Ma

Re: HEADSUP: Breaking change for Docker Pipelines coming on ci.jenkins.io

2018-04-02 Thread R. Tyler Croy
(replies inline) On Mon, 02 Apr 2018, Jesse Glick wrote: > On Mon, Apr 2, 2018 at 9:52 AM, R. Tyler Croy wrote: > > If you have a Jenkinsfile in ci.jenkins.io that relies on > > docker.image().inside() or the equivalent in Declarative Pipeline, that > > Pipeline may *break* > > These ought to b

Re: java.nio.channels.ClosedByInterruptException when I click cancel button from a running job

2018-04-02 Thread Daniel Anechitoaie
*>This is a sign that your zip operation is uninterruptible, which is > potentially a problem, though perhaps not your first priority for bug > fixing.* I'm totally ok if it's not interruptible. It's a 3rd party lib and you can't expect all libs to work perfectly. But it should interrupt aft

Re: HEADSUP: Breaking change for Docker Pipelines coming on ci.jenkins.io

2018-04-02 Thread Jesse Glick
On Mon, Apr 2, 2018 at 9:52 AM, R. Tyler Croy wrote: > If you have a Jenkinsfile in ci.jenkins.io that relies on > docker.image().inside() or the equivalent in Declarative Pipeline, that > Pipeline may *break* These ought to be pretty easy to find for an admin on this server—scan the log¹ of the

HEADSUP: Breaking change for Docker Pipelines coming on ci.jenkins.io

2018-04-02 Thread R. Tyler Croy
I have put this off as long as I feel prudent, but later this week I will be upgrading the Docker Pipeline plugin on ci.jenkins.io from 1.14 to 1.15.1 which will break Docker Pipelines which rely on the implicit ENTRYPOINT override behavior which was supposed in 1.14, but removed for 1.15.1 (https

Re: Request access to join the Jenkins CERT team

2018-04-02 Thread Jesse Glick
+1 -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.goo

Re: [Essentials] Error Telemetry logging: how to do it (was: Re: Thoughts on sending error telemetry for Jenkins Essentials)

2018-04-02 Thread Jesse Glick
On Fri, Mar 30, 2018 at 11:15 AM, Baptiste Mathus wrote: > SocketHandler is unusable for real life IMO: any loss of connection will not > be reconnected. > So we need to develop something that *will* reconnect and be more robust for > our usage. You seem to be assuming that you must stream logs

Request access to join the Jenkins CERT team

2018-04-02 Thread Ivan Fernandez Calvo
Hi, I would like to request access to join the Jenkins CERT team. - GitHub 2-factor auth enabled: yes - Signed CLA: https://github.com/jenkinsci/infra-cla/pull/58 - GitHub Username: kuisathaverat - IRC Nickname: kuisathaverat - Jenkins community username: ifernandezcalvo -- You