Re: Regarding integration of Advanced Build Discarder(GSoC Idea) with Multi-Branch Pipeline Plugin

2019-04-05 Thread Nisarg Shah
I have added both the possibilities in implementation of External Workspace Manager. 1. Invoking run deletion assuming that discarding of workspaces is already implemented. 2. And if it is not implemented, then I have given a way for discarding workspaces. I hope this is fine. I have updated my

Re: What happens when you do a FilePath.readToString() on a Master/Slave setup?

2019-04-05 Thread Daniel Anechitoaie
Your "read between the lines" was spot on. Sorry for not being more clear I was not sure how to explain my train of thoughts. It's clear now. Thank you. On Friday, April 5, 2019 at 4:17:49 PM UTC+3, Jesse Glick wrote: > > On Fri, Apr 5, 2019 at 4:11 AM Daniel Anechitoaie > wrote: > > What happe

Re: How to get access to configs/credentials on a UnprotectedRootAction class

2019-04-05 Thread Daniel Anechitoaie
Hah, yah.. makes sense. I generated the getter and setter from IntelliJ (Command + N) and somehow missed the "save()"; I removed the configure method and added save() in the setter. Thank you. On Friday, April 5, 2019 at 4:18:51 PM UTC+3, Jesse Glick wrote: > > On Fri, Apr 5, 2019 at 6:25 AM Dan

Re: `stalled-pr` label vs. JIRA status

2019-04-05 Thread Jesse Glick
On Fri, Apr 5, 2019 at 7:43 AM Daniel Beck wrote: > None of these would apply in all cases. True, but I think the commonality would be that someone who is committed to pushing it forward would not be starting from scratch. The lack of interested reviewers is often due to the original PR being too

Re: How to get access to configs/credentials on a UnprotectedRootAction class

2019-04-05 Thread Jesse Glick
On Fri, Apr 5, 2019 at 6:25 AM Daniel Anechitoaie wrote: > I forgot to implement the configure method. You should not need such a method. You just forgot to call `save()` from your setter. See the archetype. -- You received this message because you are subscribed to the Google Groups "Jenkins

Re: What happens when you do a FilePath.readToString() on a Master/Slave setup?

2019-04-05 Thread Jesse Glick
On Fri, Apr 5, 2019 at 4:11 AM Daniel Anechitoaie wrote: > What happens when you do a FilePath.readToString() on a Master/Slave setup? > Will the master read the contents of the file from the salve and process the > contents locally? I am not sure what you mean by “process” in this context. The

Proposal: Allow to unlock/lock keychain on demand with xcode-plugin

2019-04-05 Thread delrocq . mathieu
Hello, I opened an issue for this point -> https://issues.jenkins-ci.org/browse/JENKINS-56909 I want to know if it is a possible things because I don't have a good knowledge of IOS development and the use of xcode and the keychain... But I can develop this functionnality it if it's ok for you.

Re: `stalled-pr` label vs. JIRA status

2019-04-05 Thread Daniel Beck
> On 5. Apr 2019, at 08:20, Oliver Gondža wrote: > > I am wondering, do we really want to invest so much energy to clearly label > clutter (stalled PRs) in both github and JIRA? The way I look at it is the PR > failed to deliver the fix for the issue in question but there might be others >

Re: How to get access to configs/credentials on a UnprotectedRootAction class

2019-04-05 Thread Daniel Anechitoaie
Found the issue. I forgot to implement the configure method. On Friday, April 5, 2019 at 1:08:53 PM UTC+3, Daniel Anechitoaie wrote: > > One weird thing is that the settings get lost after Jenkins restart. Any > idea what's going on? > > package org.jenkinsci.plugins.osfbuildersuite.githubcheckr

Re: How to get access to configs/credentials on a UnprotectedRootAction class

2019-04-05 Thread Daniel Anechitoaie
One weird thing is that the settings get lost after Jenkins restart. Any idea what's going on? package org.jenkinsci.plugins.osfbuildersuite.githubcheckruns.webhook; import hudson.Extension; import hudson.util.Secret; import jenkins.model.GlobalConfiguration; import org.kohsuke.stapler.DataBound

What happens when you do a FilePath.readToString() on a Master/Slave setup?

2019-04-05 Thread Daniel Anechitoaie
What happens when you do a FilePath.readToString() on a Master/Slave setup? Will the master read the contents of the file from the salve and process the contents locally? Is it better to do a FilePath.act() so that the processing will happen on the slave and then the master will just get the res