Re: Unforking Commons FileUpload

2021-01-12 Thread Basil Crow
On Tue, Jan 12, 2021 at 7:33 PM Jesse Glick wrote: > > sounds like it would break normal usage from Jenkins The status quo is Commons FileUpload 1.3.1-jenkins-2 (patch in my previous message), which _already_ removed serialization from DiskFileItem. Here is the timeline of events upstream: Feb

Re: Unforking Commons FileUpload

2021-01-12 Thread Jesse Glick
https://dist.apache.org/repos/dist/release/commons/fileupload/RELEASE-NOTES.txt says The 1.4 release removes serialization from DiskFileItem for security > reasons, which could be a > breaking change depending upon one's mechanism of consumption of > commons-fileupload. which sounds like it woul

Re: [Plugin Development] API to listen to the end of the execution of a step and to collect its result?

2021-01-12 Thread Jesse Glick
On Mon, Jan 11, 2021 at 8:24 PM 'Cyrille Le Clerc' via Jenkins Developers < jenkinsci-dev@googlegroups.com> wrote: > >- I am not clear on if I should track the `StepEndNode` containing a >`LabelAction` or an `ArgumentsAction` > > Depends on whether you are interested in the close of the bo

Re: Jenkins Governance Meeting on Jan 13, 2020

2021-01-12 Thread 'Gavin Mogan' via Jenkins Developers
I have nothing to add. I'm just happy finally making my first one as a board member On Tue., Jan. 12, 2021, 2:13 p.m. Marky Jackson, wrote: > +1 to the list of topics and I have none to add. > > On Jan 12, 2021, at 2:02 PM, Oleg Nenashev wrote: > > Hi all, > > On Jan 13 we will have a regular J

Re: Jenkins Governance Meeting on Jan 13, 2020

2021-01-12 Thread Marky Jackson
+1 to the list of topics and I have none to add. > On Jan 12, 2021, at 2:02 PM, Oleg Nenashev wrote: > > Hi all, > > On Jan 13 we will have a regular Jenkins Governance meeting. It will happen > at 6PM UTC in Zoom (time to finally start the new poll). There are only a few > agenda items at th

Jenkins Governance Meeting on Jan 13, 2020

2021-01-12 Thread Oleg Nenashev
Hi all, On Jan 13 we will have a regular Jenkins Governance meeting. It will happen at 6PM UTC in Zoom (time to finally start the new poll). There are only a few agenda items at the moment, please feel free suggest your agenda items

Re: Unforking Commons FileUpload

2021-01-12 Thread Jeff Thompson
I'm in favor of unforking, wherever we can. A while back I unforked dom4j. It turned out the forked additions were essentially unused, but it took a long time to validate everything. Since JEP-200, the extra precaution to make DiskFileItem unserializable probably isn't needed, though that needs

Re: [Plugin Development] API to listen to the end of the execution of a step and to collect its result?

2021-01-12 Thread Jeff
I'm the author of the "Job and Stage monitoring plugin" Have you considered extending that plugin? I don't entirely understand what you're trying to accomplish, but to the extent it overlaps with your proposed plugin, it's probably better for the community not to have two similar plugins. Most use

Re: [Plugin Development] API to listen to the end of the execution of a step and to collect its result?

2021-01-12 Thread 'Cyrille Le Clerc' via Jenkins Developers
Many thanks Andrey. It seems to be spot on, I'll look at this as soon as my day job ends. @Mark you are right. I simplified a bit just mentioning the `git`step but I'm interested in instrumenting as many SCM integration as possible. Cyrille On Tuesday, January 12, 2021 at 1:14:03 PM UTC+1 oxyg

Re: [Plugin Development] API to listen to the end of the execution of a step and to collect its result?

2021-01-12 Thread Andrey Babushkin
You can take a look at Job and Stage monitoring plugin (https://github.com/jenkinsci/github-autostatus-plugin). I think it does the thing you're looking for. On Tuesday, January 12, 2021 at 4:50:23 AM UTC+3 Mark Waite wrote: > On Mon, Jan 11, 2021 at 6:24 PM 'Cyrille Le Clerc' via Jenkins Devel

Re: Has anyone implemented OpenTelemetry or similar observability APIs in Jenkins?

2021-01-12 Thread 'Cyrille Le Clerc' via Jenkins Developers
Hello Matt, For Your Information - I'm writing a PoC to instrument Jenkins with OpenTelemetry. - code: https://github.com/cyrille-leclerc/opentelemetry-plugin - My focus for the moment is tracing the execution of jobs with OpenTelemetry distributed traces - I have a glitch f