Re: HTMLUnit DefaultCssErrorHandler

2021-05-10 Thread 'Gavin Mogan' via Jenkins Developers
I vaguely remember when I did the upgrade to htmlunit for crawler that there was a flag to say what version of the browser to act as. I think the default is like Firefox 4 or something. (

Re: HTMLUnit DefaultCssErrorHandler

2021-05-10 Thread Jesse Glick
On Mon, May 10, 2021 at 10:31 AM Michael Tughan wrote: > I'm betting that it hasn't been updated for new CSS3 syntax > If so, it is worth checking if there is an HtmlUnit update which would correct the problem; and if not,

Re: HTMLUnit DefaultCssErrorHandler

2021-05-10 Thread Michael Tughan
No, because they're not actually errors. It's complaining about the property definitions like "--font-family-sans". I'm betting that it hasn't been updated for new CSS3 syntax, especially around properties. Michael On Monday, May 10, 2021 at 8:15:01 a.m. UTC-4 Jesse Glick wrote: > Rather than

Re: HTMLUnit DefaultCssErrorHandler

2021-05-10 Thread Jesse Glick
Rather than silencing the warnings, can the alleged errors be fixed in core? -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: HTMLUnit DefaultCssErrorHandler

2021-05-10 Thread Daniel Beck
My PR specifically adapted the tests to a reorg of the core CSS. Note the messages I ended up suppressing in my example were different ones. These messages are new and look like they're from the color definitions. I don't know this area well enough to confidently dismiss all warnings as

Re: HTMLUnit DefaultCssErrorHandler

2021-05-10 Thread Tim Jacomb
I thought Daniel already did a PR to the test harness for this? He might have selectively turned things off rather than a full silence though https://github.com/jenkinsci/jenkins-test-harness/pull/275 On Mon, 10 May 2021 at 10:47, Angélique Jard wrote: > spam for me, but it could be silenced

Re: HTMLUnit DefaultCssErrorHandler

2021-05-10 Thread Angélique Jard
spam for me, but it could be silenced by default and enabled in specific use case maybe ? On Monday, May 10, 2021 at 11:44:19 AM UTC+2 jn...@cloudbees.com wrote: > Hi all, > > The jenkins-test-harness uses the default HTMLUnit CSS Error handle which > logs two warning for every CSS error it

Re: HTMLUnit DefaultCssErrorHandler

2021-05-10 Thread Oleg Nenashev
+1 for silencing them by default. Would be nice to have a method in WebClient for those methods which really check the web layouts and hence care bout CSS On Monday, May 10, 2021 at 11:44:19 AM UTC+2 jn...@cloudbees.com wrote: > Hi all, > > The jenkins-test-harness uses the default HTMLUnit

HTMLUnit DefaultCssErrorHandler

2021-05-10 Thread jn...@cloudbees.com
Hi all, The jenkins-test-harness uses the default HTMLUnit CSS Error handle which logs two warning for every CSS error it encounters. Does anyone actually care about these errors? I am about to file a PR to silence them, but thought someone may care and may have a use for them? For example