Re: How to consume incrementals?

2019-12-09 Thread Jesse Glick
On Tue, Dec 3, 2019 at 10:09 AM Jesse Glick wrote: > Possibly we could switch to activating this profile […] > using a property set in `pom.xml` rather than relying on > `maven.config`. I cannot recall whether I tried that option during > JEP-305 research. Unfortunately this does not work: https:

Re: How to consume incrementals?

2019-12-03 Thread Jesse Glick
On Mon, Dec 2, 2019 at 12:17 PM Matt Sicker wrote: > change your IntelliJ config to delegate to Maven rather than > using its own build code Probably not sufficient. The issue is that the IDE needs to understand the Maven classpath for use from its editor. In the case of NetBeans, which always ru

Re: How to consume incrementals?

2019-12-02 Thread Matt Sicker
If you change your IntelliJ config to delegate to Maven rather than using its own build code, most of these Maven-specific extensions work fine (I've had to do that with Maven projects that rely heavily on Maven toolchain support for example). On Thu, Nov 28, 2019 at 5:04 PM Joseph P wrote: > > h

Re: How to consume incrementals?

2019-11-28 Thread Joseph P
https://github.com/JetBrains/intellij-community/blob/fecfdd52f426cf1b2770edee7dc9d9ecab692441/plugins/maven/maven3-server-common/src/org/jetbrains/idea/maven/server/Maven3ServerEmbedder.java#L80 So close but no cigar 😅 On Tuesday, November 26, 2019 at 4:26:32 PM UTC+1, Jesse Glick wrote: > > On M

Re: How to consume incrementals?

2019-11-26 Thread Jesse Glick
On Mon, Nov 25, 2019 at 8:45 PM James Nord wrote: >> IntelliJ simply does not read maven.config > > That's a shame. Uh, is it not open source (at least the core part)? I fixed this bug for NetBeans. Granted, I had a head start in that case. -- You received this message because you are subscribe

Re: How to consume incrementals?

2019-11-25 Thread James Nord
> Ok, then IntelliJ simply does not read ‚maven.config‘. That's a shame. I was planning on using that to activate the jenkins-bom profile but I have also found issues in large agregator projects where some modules want it enabled and some do not. I'm wondering if we should generically switch

Re: How to consume incrementals?

2019-11-25 Thread Ullrich Hafner
Ok, then IntelliJ simply does not read ‚maven.config‘. (I found a way to activate the profiles manually in the IntelliJ UI though…) > Am 25.11.2019 um 21:38 schrieb Jesse Glick : > > On Mon, Nov 25, 2019 at 1:59 PM Ullrich Hafner > wrote: >> I see. It would be helpful if the >> >> mvn incr

Re: How to consume incrementals?

2019-11-25 Thread Jesse Glick
On Mon, Nov 25, 2019 at 1:59 PM Ullrich Hafner wrote: > I see. It would be helpful if the > > mvn incrementals:incrementalify > > would do this automatically as well. It does: https://github.com/jenkinsci/incrementals-tools/blob/f6fb2fd644fa0aa7be5c5173506d9368b542dd2d/maven-plugin/src/main/java

Re: How to consume incrementals?

2019-11-25 Thread Ullrich Hafner
I see. It would be helpful if the mvn incrementals:incrementalify would do this automatically as well. > Am 25.11.2019 um 12:20 schrieb James Nord : > > You should just need to enable the "consume-incrementals" profile, rather > than adding extras to the pom > > https://github.com/jenkinsc

Re: How to consume incrementals?

2019-11-25 Thread James Nord
You should just need to enable the "consume-incrementals" profile, rather than adding extras to the pom https://github.com/jenkinsci/plugin-pom/blob/master/pom.xml#L1348-L1369 If you are not using a mirror in your settings.xml then yes, I have always had to bootstrap the repositories section fo

Re: How to consume incrementals?

2019-11-25 Thread Ullrich Hafner
Well, it works perfectly on the console. In order to get everything resolved in IntelliJ I needed to add to my pom: repo.jenkins-ci.org https://repo.jenkins-ci.org/public/ incrementals.jenkins-ci.org https://repo.jenkins-ci.org/incrementals/ Otherwise IntelliJ will no

Re: How to consume incrementals?

2019-11-23 Thread Ullrich Hafner
Thanks, that was exactly the problem! Now it is working as expected. > Am 23.11.2019 um 18:22 schrieb 'Gavin Mogan' via Jenkins Developers > : > > I believe you have to use an incrementals once before it can be updated > > The incrementals docs say: > > Once you have some dependencies on increm

Re: How to consume incrementals?

2019-11-23 Thread 'Gavin Mogan' via Jenkins Developers
I believe you have to use an incrementals once before it can be updated The incrementals docs say: > Once you have some dependencies on incremental versions in your POM, you can So based on https://repo.jenkins-ci.org/incrementals/io/jenkins/plugins/jquery3-api/3.4.1-1-beta2-rc52.da76aa84ddb7/ I

How to consume incrementals?

2019-11-23 Thread Ullrich Hafner
I’m currently enabling incrementals in my plugins. I was quite easy to produce them, e.g. the following PRs successfully deployed a incremental release: https://github.com/jenkinsci/jquery3-api-plugin/pull/12 (in branch release) https://github.com/jenkinsci/popper-api-plugin/pull/12