Re: JGit api changed - Handling removal of methods from an underlying API

2016-07-26 Thread Mark Waite
I've posted a possible alternative as a pull request to the git plugin. The alternative tries to call the JGit 3 implementation. If a NoSuchMethodError exception is raised, it uses reflection to find the close method (from JGit 4), and calls it (if it finds it). Comments are welcomed on https:

Re: JGit api changed - Handling removal of methods from an underlying API

2016-07-06 Thread Mark Waite
Will do. My current goal is to investigate other ways of resolving the issue without requiring that every plugin which depends on JGit must update at the same time. For example, one of the experiments I hope to perform is to see if a dependent plugin could catch the runtime exception due to th

Re: JGit api changed - Handling removal of methods from an underlying API

2016-07-06 Thread Robert Sandell
I have released Gerrit trigger 2.22.0-beta-1, thanks to a helpful contribution, with the needed JGit 4 changes for users to try out. A helpful ping when Git Plugin 3 is released to main update center would be nice, so I can do the same. /B On Wed, Jun 22, 2016 at 7:43 PM, Jesse Glick wrote: >

Re: JGit api changed - Handling removal of methods from an underlying API

2016-06-22 Thread Jesse Glick
On Tue, Jun 21, 2016 at 5:56 PM, Mark Waite wrote: > I could search the plugin tree for JGit references to see the > actual scope of the problem. I would start there, especially if you have a complete list of exhaustive members you could search for usages of. It would be very helpful if someone

Re: JGit api changed - Handling removal of methods from an underlying API

2016-06-22 Thread 'Björn Pedersen' via Jenkins Developers
Am Mittwoch, 22. Juni 2016 11:21:17 UTC+2 schrieb Robert Sandell: > > > > On Wed, Jun 22, 2016 at 11:01 AM, 'Björn Pedersen' via Jenkins Developers > > wrote: > >> At least gerrit-trigger-plugin up to 2.21.1 uses TreeWalk.release. >> > > Really? Where? I found usage of RevWalk but not TreeWalk.

Re: JGit api changed - Handling removal of methods from an underlying API

2016-06-22 Thread Robert Sandell
On Wed, Jun 22, 2016 at 11:01 AM, 'Björn Pedersen' via Jenkins Developers < jenkinsci-dev@googlegroups.com> wrote: > At least gerrit-trigger-plugin up to 2.21.1 uses TreeWalk.release. > Really? Where? I found usage of RevWalk but not TreeWalk. /B > > Am Dienstag, 21. Juni 2016 23:56:08 UTC+2 sch

Re: JGit api changed - Handling removal of methods from an underlying API

2016-06-22 Thread 'Björn Pedersen' via Jenkins Developers
At least gerrit-trigger-plugin up to 2.21.1 uses TreeWalk.release. Am Dienstag, 21. Juni 2016 23:56:08 UTC+2 schrieb Mark Waite: > > The git client plugin 2.0.0 and git plugin 3.0.0 releases will only > support JDK 7 and later. The change to JDK 7 allows code simplifications > (try with resourc

Re: JGit api changed - Handling removal of methods from an underlying API

2016-06-21 Thread Stephen Connolly
OTOH they are OSGi people, so they don't have to worry about that problem On 21 June 2016 at 23:05, Stephen Connolly wrote: > Such a pity that they didn't change the package name when breaking > backwards compatibility... > > On 21 June 2016 at 22:56, Mark Waite wrote: > >> The git client plugi

Re: JGit api changed - Handling removal of methods from an underlying API

2016-06-21 Thread Stephen Connolly
Such a pity that they didn't change the package name when breaking backwards compatibility... On 21 June 2016 at 22:56, Mark Waite wrote: > The git client plugin 2.0.0 and git plugin 3.0.0 releases will only > support JDK 7 and later. The change to JDK 7 allows code simplifications > (try with

JGit api changed - Handling removal of methods from an underlying API

2016-06-21 Thread Mark Waite
The git client plugin 2.0.0 and git plugin 3.0.0 releases will only support JDK 7 and later. The change to JDK 7 allows code simplifications (try with resources, etc.) and are a good opportunity to upgrade from embedding JGit 3 to embedding JGit 4. JGit 4 only supports JDK 7 and later. The AP