Re: Presenting frontend toolchain changes

2020-02-03 Thread Baptiste Mathus
To circle back, FYI everyone the PR to remove JS-Builder got merged towards 2.217. Feel free to reach out to us at the Jenkins UX SiG group if you have any question, or want to help move the initiative faster :) There's now also a WIP PR to modernize the header: https://github.com/jenkinsci/jenki

Re: Presenting frontend toolchain changes

2020-01-10 Thread Felix Queiruga
Quick update: I have created the draft PR with its corresponding JIRA task ( https://github.com/jenkinsci/jenkins/pull/4425) On Friday, January 10, 2020 at 11:52:20 AM UTC+1, Oleg Nenashev wrote: > > +100 for switching from Jenkins JS Builder to a standard Webpack. > According to experiments with

Re: Presenting frontend toolchain changes

2020-01-10 Thread Oleg Nenashev
+100 for switching from Jenkins JS Builder to a standard Webpack. According to experiments with jsbuilder it is pretty difficult to use this tool, especially for those ones who are not Javascript experts. Webpack is at least a standard tool, so it will be more convenient for newcomer Javascript

Re: Presenting frontend toolchain changes

2020-01-10 Thread Felix Queiruga
I'll file the draft PR then. I already had in mind those TODOs that you mentioned. I wanted to get them done before filing the PR. On Thursday, January 9, 2020 at 8:18:31 PM UTC+1, Jesse Glick wrote: > > On Thu, Jan 9, 2020 at 1:10 PM Felix Queiruga > wrote: > > The branch can be found at >

Re: Presenting frontend toolchain changes

2020-01-09 Thread Jesse Glick
On Thu, Jan 9, 2020 at 1:10 PM Felix Queiruga wrote: > The branch can be found at > https://github.com/fqueiruga/jenkins/tree/replace-jsbuilder-with-webpack. > Keep in mind that it is a WIP You may want to file it as a draft PR—get early CI and have a place for early review comments to be place

Re: Presenting frontend toolchain changes

2020-01-09 Thread Felix Queiruga
Redoing my reply as I answered from my mail client. The change will be self contained and limited to the Jenkins core war, Jesse. That said, maybe it requires more explaining and documentation than a normal enhancement PR. The PR will replace js-builder completely. LESS files will also be proc

Re: Presenting frontend toolchain changes

2020-01-09 Thread Felix Queiruga
The change will be self contained and limited to the Jenkins core war, Jesse. That said, maybe it requires more explaining and documentation than a normal enhancement PR. My branch can be found at https://github.com/fqueiruga/jenkins/tree/replace-jsbuilder-with-webpack. Keep in mind that it is a W

Re: Presenting frontend toolchain changes

2020-01-09 Thread 'Gavin Mogan' via Jenkins Developers
I'm super curious about your plans for this. Are you just doing js or doing CSS too? Is your branch public anywhere? On Thu., Jan. 9, 2020, 9:26 a.m. Felix Queiruga, wrote: > Hi everybody, > > I have a working draft for replacing js-builder with webpack on Jenkins > core (not on plugins). The br

Re: Presenting frontend toolchain changes

2020-01-09 Thread Tim Jacomb
Normal jira sounds fine to me, Webpack is a very standard front end tool these days On Thu, 9 Jan 2020 at 17:26, Felix Queiruga wrote: > Hi everybody, > > I have a working draft for replacing js-builder with webpack on Jenkins > core (not on plugins). The branch is a WIP, it's only missing adapt

Re: Presenting frontend toolchain changes

2020-01-09 Thread Jesse Glick
On Thu, Jan 9, 2020 at 12:26 PM Felix Queiruga wrote: > I'd like to know if this toolchain change should be first explained on a JEP > or if a normal JIRA ticket is enough. I do not know of any official policy but my rule of thumb is that you should file a JEP if there would be lots of content t

Presenting frontend toolchain changes

2020-01-09 Thread Felix Queiruga
Hi everybody, I have a working draft for replacing js-builder with webpack on Jenkins core (not on plugins). The branch is a WIP, it's only missing adapting JS unit tests and linter. Before I submit the draft PR, I'd like to know if this toolchain change should be first explained on a JEP or i