Proposal - Adding JCasC tests into Jenkins core test suite

Hi All In an effort to improve JCasC compatibility we would like to add the configuration-as-code-plugin into the Jenkins core test suite This will help us improve te

Re: Proposal - Adding JCasC tests into Jenkins core test suite

Sounds like a great idea to me. My 2-cents Jon -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this di

Re: Proposal - Adding JCasC tests into Jenkins core test suite

On Tue, Jun 4, 2019 at 1:23 PM Joseph P wrote: > we would avoid regressions that are related to configuration-as-code I think that should be handled differently, for example by something like JENKINS-45047, or `plugin-compat-tester`, or `buildPlugin.recommendedConfigurations()`, or Dependabot. Th

Re: Proposal - Adding JCasC tests into Jenkins core test suite

I agree with Jesse. The suite as is is so large already. The plugin-compat-test was made for purposes similar to this I believe, so why not use the tools that are available? On Tue, Jun 4, 2019 at 11:29 AM Jesse Glick wrote: > On Tue, Jun 4, 2019 at 1:23 PM Joseph P wrote: > > we would avoid re

Re: Proposal - Adding JCasC tests into Jenkins core test suite

If it makes sense to use the plugin-compat-test, we should go with this. I wasn't aware of its existence. On Tue, 4 Jun 2019, 22.18 Slide, wrote: > I agree with Jesse. The suite as is is so large already. The > plugin-compat-test was made for purposes similar to this I believe, so why > not use

Re: Proposal - Adding JCasC tests into Jenkins core test suite

Yes, we could use PCT for Jenkins Configuration-as-Code tests. But, if we want to run JCasC integration tests as a part of the core pipeline, we would need to integrate PCT directly into Jenkins Core pipeline. I had a pull request for that ( https://github.com/jenkinsci/jenkins/pull/3438), but i

Re: Proposal - Adding JCasC tests into Jenkins core test suite

On Wed, Jun 5, 2019 at 3:33 AM Oleg Nenashev wrote: > we would need to integrate PCT directly into Jenkins Core pipeline. > I had a pull request for that > (https://github.com/jenkinsci/jenkins/pull/3438), but it was stalled. Maybe > we could revisit it. +1, this would benefit core stability br

Re: Proposal - Adding JCasC tests into Jenkins core test suite

Taking this discussion, what about including *optional* JCasC dependency to Jenkins Test Harness Jenkins Performance Test Framework supports JCasC rules, and we want to make it accessible to users. Her is the ongoing pull request: https://github.com/jenkinsci/jenkins-test-harness/pull/135/files

Re: Proposal - Adding JCasC tests into Jenkins core test suite

On Fri, Jun 7, 2019 at 3:23 AM Oleg Nenashev wrote: > Taking this discussion, what about including *optional* JCasC dependency to > Jenkins Test Harness Seems wrong to include any plugin as a dep of `jenkins-test-harness`. > Jenkins Performance Test Framework supports JCasC rules You can creat

Re: Proposal - Adding JCasC tests into Jenkins core test suite

> > You can create a `tests`-classifier JAR from `configuration-as-code` > which offers specialized test utilities making use of that plugin’s > functionality. It is already there. I want to refactor it out in https://github.com/jenkinsci/configuration-as-code-plugin/issues/917 On Fri, Jun 7, 2