Re: Review needed. Change in core: responsive new job name validation

2016-08-01 Thread Michael Neale
Daniel pointed out an annoyance with the "autocompletion" support with this new way of working in the PR (second from last comment) but the code refactoring looked good. On Monday, August 1, 2016 at 11:46:30 PM UTC+10, Samat Davletshin wrote: > > Hello! > Here I propose to make a change in new

Review needed. Change in core: responsive new job name validation

2016-08-01 Thread Samat Davletshin
Hello! Here I propose to make a change in new job name validation. https://github.com/jenkinsci/jenkins/pull/2416/files Now the GET request to check new job name for invalid characters is sent only on 'blur' jQuery event. That makes a user know about the invalid character only after he entered

Responsive new job name validation

2016-07-29 Thread Samat Davletshin
Hello! Here I propose to make a change in new job name validation. https://github.com/jenkinsci/jenkins/pull/2416/files Now the GET request to check new job name for invalid characters is sent only on 'blur' jQuery event. That makes a user know about the invalid character only after he entered