Re: control of community-contributed localization

2013-11-18 Thread Roman Kagan
2013/11/14 Kohsuke Kawaguchi : > I still don't have good sense on the scope of the problem. I wonder if I > should roll them back, or should try to just fix them one by one? I've found three major issues and a few minor ones; they all have been addressed by Oleg's patch. > On 11/12/2013 11:48 PM,

Re: control of community-contributed localization

2013-11-17 Thread Roman Kagan
2013/11/17 Oleg Nenashev : > I've reviewed changes in > https://github.com/jenkinsci/jenkins/commit/7828dcb46d9a18f88cc8e71046edc9ee91ed95e6 > Pull request with fixes: https://github.com/jenkinsci/jenkins/pull/1022 Thanks for doing this, and sorry for being so slow and leaving the work upon you.

Re: control of community-contributed localization

2013-11-16 Thread Oleg Nenashev
Hello, I've reviewed changes in https://github.com/jenkinsci/jenkins/commit/7828dcb46d9a18f88cc8e71046edc9ee91ed95e6 Pull request with fixes: https://github.com/jenkinsci/jenkins/pull/1022 In my opinion, only about 60% of changes were positive. We definitely need to somehow review changes at lea

Re: control of community-contributed localization

2013-11-14 Thread Oleg Nenashev
Regarding https://github.com/jenkinsci/jenkins/commit/7828dcb46d9a18f88cc8e71046edc9ee91ed95e6, I also propose to revert this commit in master and pick it to another branch (e.g. to translation_ru). I'll have some time to review changes on the next week. Roman, would you like to participate in ver

Re: control of community-contributed localization

2013-11-14 Thread Baptiste Mathus
OK, I quickly checked https://github.com/jenkinsci/jenkins/commit/9c7f83659dcf506e27ddbfb72e354f1f96e6bce0 . My opinion is that the content there is basically not adding much value. IMO most of the time, it's actually replacing existing translation that was already correct. I even saw some contradi

Re: control of community-contributed localization

2013-11-14 Thread Baptiste Mathus
Hi, Sorry should have taken time to look into this earlier. I'll have a look at the french translation tonight to see what was submitted. Baptiste 2013/11/14 Kohsuke Kawaguchi > > > Thank you for looking into this. A similar issue was reported in en_UK > locale, so it's clear that we have to

Re: control of community-contributed localization

2013-11-14 Thread Kohsuke Kawaguchi
Thank you for looking into this. A similar issue was reported in en_UK locale, so it's clear that we have to revisit the process. I still don't have good sense on the scope of the problem. I wonder if I should roll them back, or should try to just fix them one by one? On 11/12/2013 11:48

Re: control of community-contributed localization

2013-11-14 Thread Roman Kagan
2013/11/14 Oleg Nenashev : > I confirm that Russian translation is quite confusing If by "confusing" you imply some items that look literally translated from English as if by machine translation and thus don't sound right in Russian, then yes, such things exist, but that isn't that bad, and it was

Re: control of community-contributed localization

2013-11-14 Thread Oleg Nenashev
Hello, I confirm that Russian translation is quite confusing (we enforce English localization for all users, but...). In my opinion, the approach should be quite simple: All localization changes should be reviewed by people, who know the target language. It would be also useful to have automati

control of community-contributed localization

2013-11-12 Thread Роман Каган
Hi, I've upgraded to 1.539 and discovered that russian localization is seriously spoiled. Some labels contain offensive words (!), some don't match the original, some are plain garbage. They were introduced by commit 7828dcb46d9a18f88cc8e71046edc9ee91ed95e6 Author: Kohsuke Kawaguchi Date: