Re: failed builds on cloudbees-pull-request-builder

2013-03-19 Thread Jesse Glick
On 03/19/2013 05:07 PM, Harald Albers wrote: it's not very likely that someone will accept a failing pull request Evaluators are not robots, we would notice that the failure is spurious. Should I close the request, rebase and resubmit it to a different branch? No, leave it. -- You received

Re: failed builds on cloudbees-pull-request-builder

2013-03-19 Thread Harald Albers
On 19 Mar 2013 at 15:59, Jesse Glick wrote: > The two test failures were already fixed in trunk (rather, suppressed on this > job since the cause of failure is unknown), so it should not affect new PRs > going forward. > > > An amending commit even caused the corresponding build to fail. > > Th

Re: failed builds on cloudbees-pull-request-builder

2013-03-19 Thread Jesse Glick
On 03/19/2013 02:53 PM, Harald Albers wrote: I have an open pull request https://github.com/jenkinsci/jenkins/pull/735 that only contains minor additions to message files. To my surprise, the request got marked as unstable by cloudbees-pull-request-builder. The two test failures were already

Re: failed builds on cloudbees-pull-request-builder

2013-03-19 Thread Martin Ba
On 19.03.2013 19:53, Harald Albers wrote: I have an open pull request https://github.com/jenkinsci/jenkins/pull/735 that only contains minor additions to message files. To my surprise, the request got marked as unstable by cloudbees-pull-request-builder. An amending commit even caused the corresp

failed builds on cloudbees-pull-request-builder

2013-03-19 Thread Harald Albers
I have an open pull request https://github.com/jenkinsci/jenkins/pull/735 that only contains minor additions to message files. To my surprise, the request got marked as unstable by cloudbees-pull-request-builder. An amending commit even caused the corresponding build to fail. Can someone ple