Joe Hansche commented on Bug JENKINS-20636

Kohsuke Kawaguchi, is this an issue with the ruby runtime plugin? Or an issue with how the NodeJS plugin does its set up? The fact that both rbenv and RVM plugins have this issue, and both rely on the ruby runtime. NodeJS modifies the environment from the decorateLauncher() method, injecting the bin dir of the NodeJS installation into the PATH env var from the Launcher#launch(ProcStarter) method:

@Override
    public Launcher decorateLauncher(final AbstractBuild build, Launcher launcher, BuildListener listener) throws IOException, InterruptedException, Run.RunnerAbortedException {
        return new DecoratedLauncher(launcher){
            @Override
            public Proc launch(ProcStarter starter) throws IOException {
...

                // HACK: Avoids issue with invalid separators in EnvVars::override in case of different master/slave
                
                String overriddenPaths = NodeJSInstaller.binFolderOf(nodeJSInstallation, build.getBuiltOn())
                        + pathSeparator
                        + vars.get("PATH");
                vars.override("PATH", overriddenPaths);

                return super.launch(starter.envs(Util.mapToEnv(vars)));
            }

Could it be a threading issue between the NodeJS plugin and the ruby runtime?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to