Re: [Jfs-discussion] [PATCH 15/25] JFS: call attr_kill_to_mode from jfs_setattr

2007-08-07 Thread Dave Kleikamp
On Mon, 2007-08-06 at 09:54 -0400, Jeff Layton wrote: > Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> Acked-by: Dave Kleikamp <[EMAIL PROTECTED]> > --- > fs/jfs/acl.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/fs/jfs/acl.c b/fs/jfs/acl.c > index 4d84bdc..34ca

Re: [Jfs-discussion] [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function

2007-08-07 Thread Christoph Hellwig
> +void attr_kill_to_mode(struct inode *inode, struct iattr *attr) This function badly needs a kerneldoc description. Also I can't say I like the name a lot, but without a clearly better idea I should probably not complain :) We should at least add a generic_ prefix to indicate it's a generic he

Re: [Jfs-discussion] [PATCH 00/25] move handling of setuid/gid bits from VFS into individual setattr functions (RESEND)

2007-08-07 Thread Christoph Hellwig
First thanks a lot for doing this work, it's been long needed. Second please don't send out that many patches. We encourage people to split things into small patches when the changes are logially separated. Which these are not - it's a flag day change (which btw is fine despite the rants soe peo

[Jfs-discussion] 395378

2007-08-07 Thread Alla Sawyer
FA0d84Da - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now