Re: RFR: JDK-8058118: Generate modules.list during the build

2014-09-14 Thread Mandy Chung
On 9/13/2014 1:30 AM, Chris Hegarty wrote: Update jdk part as per Mandy’s comments: http://cr.openjdk.java.net/~chegar/8058118/webrev_jdk.01/webrev/ Looks good. Thanks for the update. As Alan pointed out, it'd be good to add a private no-arg constructor to ModulesXmlReader and ModulesXml

Re: RFR: JDK-8058118: Generate modules.list during the build

2014-09-14 Thread Alan Bateman
On 13/09/2014 09:30, Chris Hegarty wrote: : Update jdk part as per Mandy’s comments: http://cr.openjdk.java.net/~chegar/8058118/webrev_jdk.01/webrev/ I looked through the update and it looks good. A minor comment for both ModulesXmlReader and ModulesXmlWriter is that a private no-arg cons