hg: jigsaw/m2/langtools: Fix typo

2014-12-01 Thread mandy . chung
Changeset: 2b199ffb3f98 Author:mchung Date: 2014-12-01 17:41 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/2b199ffb3f98 Fix typo ! src/jdk.dev/share/classes/com/sun/tools/jdeps/Profile.java

hg: jigsaw/m2/langtools: minor review feedback

2014-12-01 Thread jonathan . gibbons
Changeset: 66b0c80c1c1e Author:jjg Date: 2014-12-01 16:28 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/66b0c80c1c1e minor review feedback ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/ClassFinder.java ! src/jdk.compiler/share/classes/com/sun/tools/javac

Re: RFR [JEP 220] Modular Run-Time Images

2014-12-01 Thread Jan Lahoda
javac changes seem generally OK to me with a few nits below (I am OK if these are handled separately as needed). Jan -ClassFinder, above getSupplementaryFlags: typo "superceded"? -Locations, method systemClasses, in the jimage branch, there is: Collection images = files .filter(f

hg: jigsaw/m2/jdk: linux-ppc builds generate jimage in the wrong native format

2014-12-01 Thread alan . bateman
Changeset: 9de3eba82f89 Author:alanb Date: 2014-12-01 19:01 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/9de3eba82f89 linux-ppc builds generate jimage in the wrong native format ! src/java.base/share/classes/jdk/internal/jimage/BasicImageWriter.java

Re: Support for jrt-fs.jar in JDK 7 would be very helpful in allowing FindBugs to run under Java 9

2014-12-01 Thread mark . reinhold
2014/11/26 11:31 -0800, fo...@univ-mlv.fr: > The problem is that when you expose such API you encode assumptions with it. The proposed symbolic links will expose no information that's not already available in the current jrt filesystem; they'll just expose that information in an alternative form t

hg: jigsaw/m2/jdk: URLConnection::getContentLength should return -1 for resources > MAX_VALUE

2014-12-01 Thread alan . bateman
Changeset: 26a4132a2fa9 Author:alanb Date: 2014-12-01 16:49 + URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/26a4132a2fa9 URLConnection::getContentLength should return -1 for resources > MAX_VALUE ! src/java.base/share/classes/sun/net/www/protocol/jrt/JavaRuntimeURLConnecti

Re: RFR [JEP 220] Modular Run-Time Images

2014-12-01 Thread Paul Sandoz
On Dec 1, 2014, at 5:33 PM, Alan Bateman wrote: > On 01/12/2014 16:11, Paul Sandoz wrote: >> : >> >> >> In src/java.base/share/classes/java/util/jar/Attributes.java >> /** >> * Name object for Implementation-URL >> * manifest attribute used for package versioning. >

Re: RFR [JEP 220] Modular Run-Time Images

2014-12-01 Thread Alan Bateman
On 01/12/2014 16:11, Paul Sandoz wrote: : In src/java.base/share/classes/java/util/jar/Attributes.java /** * Name object for Implementation-URL * manifest attribute used for package versioning. - * @see - * Java Product Versioning Specificati

Re: RFR [JEP 220] Modular Run-Time Images

2014-12-01 Thread Paul Sandoz
On Nov 20, 2014, at 10:41 PM, Chris Hegarty wrote: >> >> Webrevs: >> http://cr.openjdk.java.net/~chegar/8061971/00/ >> Below is a review of JDK code. I did not spot any showstoppers. It's mostly cleanup related with maybe one or two bugs. Paul. In src/java.base/share/classes/java/util/jar