This module contains both pack200 and unpack200 tools although it only
contains the native implementation of unpacker. Naming it as
jdk.unpack200 would give an impression that it contains the unpacker
only which isn't the case.
Like the API java.util.jar.Pack200 class, it's about Pack200 format and
it has both Pack200.Packer and Pack200.Unpacker nested interfaces
jdk.pack200 represents the tools for Pack200 format that sounds fine to me.
Mandy
On 3/10/2015 10:23 AM, Kumar Srinivasan wrote:
The changes look ok to me, however I am wondering if the module
could be called jdk.unpack200 and not jdk.pack200 ? since it
contains only the unpacker, and the bin utilities are pack200 and
unpack200.
Kumar
On 3/4/2015 5:13 PM, Mandy Chung wrote:
As listed in an open issue in JEP 200:
The jdk.dev and jdk.runtime modules contain miscellaneous tools that do
not obviously belong to any other module; these modules will eventually
be either renamed or refactored.
Currently there are jdk.javadoc, jdk.jconsole, jdk.jcmd modules in
the JDK that are organized around its primary tool. Such organization
is easy to name, document and understand. This patch proposes to
move tools from jdk.runtime and jdk.dev to jdk.pack200, jdk.jartool,
jdk.policytool modules.
Overall Webrev that will be convenient to review the build change
and modules.xml change.
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074428%2b8074429%2b8074430/webrev.00/
Separate webrevs for each issue:
1. pack200, unpack200 to jdk.pack200
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074428%2b8074429%2b8074430/8074428/webrev.00/
2. jar, jarsigner to jdk.jartool
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074428%2b8074429%2b8074430/8074429/webrev.00/
3. policytool to jdk.policytool
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074428%2b8074429%2b8074430/8074430/webrev.00/
There are remaining tools in jdk.dev that will be handled separately.
jdk.dev will disappear when all of the remaining tools find its home.
Mandy
