Re: RFR 8047789: auth.login.LoginContext needs to be updated to work with modules

2015-03-20 Thread Mandy Chung
On 3/20/15 7:39 AM, Wang Weijun wrote: Please review the code changes at http://cr.openjdk.java.net/~weijun/8047789/webrev.03/ It looks okay to me. Removing some use of reflection seems a good thing. One observation: invoke(String methodName) now calls the method statically and the imple

Re: RFR 8047789: auth.login.LoginContext needs to be updated to work with modules

2015-03-20 Thread Alan Bateman
On 20/03/2015 14:39, Wang Weijun wrote: Please review the code changes at http://cr.openjdk.java.net/~weijun/8047789/webrev.03/ LoginContext is updated to use ServiceLoader to load configured LoginModules, and fallback to reflection if it cannot find one. Please notice that the fix does n

RFR 8047789: auth.login.LoginContext needs to be updated to work with modules

2015-03-20 Thread Wang Weijun
Please review the code changes at http://cr.openjdk.java.net/~weijun/8047789/webrev.03/ LoginContext is updated to use ServiceLoader to load configured LoginModules, and fallback to reflection if it cannot find one. Please notice that the fix does not include configuration of existing LoginM

Re: Modular soruce code resolving

2015-03-20 Thread Alan Bateman
On 19/03/2015 22:42, Edward Nigma wrote: With introduction of jimage, source archive may contain ambiguous entries (multiple version). If jimage allow distribution of multiple module versions then sources in zip should too. Just on this comment, are you specifically talking about src.zip in the