hg: jigsaw/jake/nashorn: 8139106: ant build/test fails with jigsaw/jake/nashorn

2015-10-08 Thread sundararajan . athijegannathan
Changeset: c350ec3155e1 Author:sundar Date: 2015-10-08 14:49 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/c350ec3155e1 8139106: ant build/test fails with jigsaw/jake/nashorn Reviewed-by: lagergren, mhaupt ! make/build.xml ! make/project.properties -

RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Jaroslav Bachorik
Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-7199353 Webrev: http://cr.openjdk.java.net/~jbachorik/7199353/webrev.00/top http://cr.openjdk.java.net/~jbachorik/7199353/webrev.00/jdk Issue description: "MXBean currently supports model-specific types

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Daniel Fuchs
Hi Jaroslav, I'll look at the code in more details, but doesn't your webrev miss some modifications to modules.xml? oh - I see you have module-info.java - are you planning to push that in jake repo first then? best regards, -- daniel On 08/10/15 13:49, Jaroslav Bachorik wrote: Please,

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Jaroslav Bachorik
On 8.10.2015 14:15, Alan Bateman wrote: On 08/10/2015 12:49, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-7199353 Webrev: http://cr.openjdk.java.net/~jbachorik/7199353/webrev.00/top

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Alan Bateman
On 08/10/2015 13:26, Jaroslav Bachorik wrote: The patch is adding a new exported package to java.management - so it would have to be adjusted to the way jdk9 defines modules right now (eg. modules.xml). And then do this again for jigsaw/jake I would, personally, prefer to do the change

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Alan Bateman
On 08/10/2015 14:15, Daniel Fuchs wrote: : 3. I was told recently that @since 1.9 should now be @since 9 (package-info + new annotation type) JEP 223 isn't in JDK 9 yet. I've no doubt there will be a s/1.9/9/g when it goes in, it will probably need to be done a few times to ensure

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Daniel Fuchs
Hi Jaroslav, 1. I think it would be good to change the synopsis of the issue to match what the proposed change does. It seems to me that something like: Add a new javax.management.annotation.ConstructorProperties annotation would be a better description. 2. I agree with Alan

hg: jigsaw/jake/jdk: 25 new changesets

2015-10-08 Thread jean-francois . denise
Changeset: 1edfa4abd77a Author:psandoz Date: 2015-09-19 15:26 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1edfa4abd77a 8136686: Collectors.counting can use Collectors.summingLong to reduce boxing Reviewed-by: psandoz Contributed-by: Tagir Valeev !

hg: jigsaw/jake/jaxp: 4 new changesets

2015-10-08 Thread jean-francois . denise
Changeset: c10ec627fad5 Author:joehw Date: 2015-09-25 16:42 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/c10ec627fad5 8135283: DOM API update: Element Traversal Specification Reviewed-by: mchung, lancea !

hg: jigsaw/jake: 9 new changesets

2015-10-08 Thread jean-francois . denise
Changeset: 6849581ba4ab Author:ihse Date: 2015-09-21 09:32 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/6849581ba4ab 8136695: Automatic build comparison with COMPARE_BUILD Reviewed-by: erikj ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh !

hg: jigsaw/jake/langtools: 6 new changesets

2015-10-08 Thread jean-francois . denise
Changeset: c8206f440046 Author:alundblad Date: 2015-09-21 11:19 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/c8206f440046 8135131: Enable thin server mode in Sjavac Summary: State tracknig and incremental compilation disabled unless --state-dir is provided.

hg: jigsaw/jake/jaxws: 4 new changesets

2015-10-08 Thread jean-francois . denise
Changeset: bdb954839363 Author:avstepan Date: 2015-09-24 18:26 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/bdb954839363 8133651: replace some tags (obsolete in html5) in core-libs docs Reviewed-by: martin !

hg: jigsaw/jake/hotspot: 32 new changesets

2015-10-08 Thread jean-francois . denise
Changeset: a589f73b79f4 Author:mcberg Date: 2015-09-09 10:34 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/a589f73b79f4 8135028: support for vectorizing double precision sqrt Reviewed-by: kvn, twisti ! src/cpu/x86/vm/assembler_x86.cpp !

RE: Warning: Cannot use jsr199 Javac from jrt-fs.jar"

2015-10-08 Thread Keimpe Bronkhorst
Jon, Users of JDeveloper want to be able to compile and run their code with any JDK on their filesystem, not just compile and run with the JDK JDeveloper is running on. The compile I could make work in JDK8 and before by getting a javax.tools.JavaCompiler from

Re: Warning: Cannot use jsr199 Javac from jrt-fs.jar"

2015-10-08 Thread Jonathan Gibbons
Keimpe, While your use-case is about accessing alternate versions of javac, the underlying mechanism you are looking for is more general and not specific to javac. The ability that you need, and which you're currently missing, is the ability to load code (modules) from an alternate JDK

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Mandy Chung
On 10/08/2015 05:41 AM, Alan Bateman wrote: I'm not sure that I agree with logging a warning when java.beans.ConstructorProperties is used. I would be tempted to leave that out. The idea is that we want users to stop using @j.b.CP for JMX purposes. So we might as well warn them about the

Re: Warning: Cannot use jsr199 Javac from jrt-fs.jar"

2015-10-08 Thread Alan Bateman
On 08/10/2015 20:45, Keimpe Bronkhorst wrote: Alan, If the user's project's JDK has a higher version than the JDK of JDeveloper, the compile is done out-of-process. Otherwise an in-process JSR199 is attempted. Yes, -source/-target/-Xbootclasspath (and now -release) for cross-compiling is

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Mandy Chung
On 10/08/2015 04:49 AM, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-7199353 Webrev: http://cr.openjdk.java.net/~jbachorik/7199353/webrev.00/top http://cr.openjdk.java.net/~jbachorik/7199353/webrev.00/jdk I think #2 in the

Re: Warning: Cannot use jsr199 Javac from jrt-fs.jar"

2015-10-08 Thread Keimpe Bronkhorst
Alan, I'm running JDeveloper with jigsaw build 1.9.0-ea-jigsaw-nightly-h3477-20150929-b83. Compiling in-process using JSR199 with a Javac from JDK8 tools.jar is working fine. Keimpe On 10/8/2015 2:27 PM, Alan Bateman wrote: On 08/10/2015 20:45, Keimpe Bronkhorst wrote: Alan, If the

Re: Warning: Cannot use jsr199 Javac from jrt-fs.jar"

2015-10-08 Thread Jayaprakash Arthanareeswaran
> The ability that you need, and which you're currently missing, is the > ability to load code (modules) from an alternate JDK image. This is what we (the eclipse team) is missing as well and I haven't heard anything along these lines in this mail group. Or did I miss something? Regards,

Re: Warning: Cannot use jsr199 Javac from jrt-fs.jar"

2015-10-08 Thread Alan Bateman
On 08/10/2015 17:47, Keimpe Bronkhorst wrote: Jon, Users of JDeveloper want to be able to compile and run their code with any JDK on their filesystem, not just compile and run with the JDK JDeveloper is running on. I'm curious about this. If JDeveloper is running on JDK 7 for example and

Re: Warning: Cannot use jsr199 Javac from jrt-fs.jar"

2015-10-08 Thread Keimpe Bronkhorst
Alan, If the user's project's JDK has a higher version than the JDK of JDeveloper, the compile is done out-of-process. Otherwise an in-process JSR199 is attempted. Yes, -source/-target/-Xbootclasspath (and now -release) for cross-compiling is another way, but it doesn't use the Javac of the