Re: About 8056174: New APIs for jar signing

This looks okay. We will push this fix once we pull down your changeset to jake. One question: is “altsignerpath” and “altsigner” properties are only for the existing jarsigner -altsigner option to work? Is it the plan to deprecate this -altsigner option? Mandy > On Nov 19, 2015, at 4:40 PM

About 8056174: New APIs for jar signing

I've just push the code change for this enhancement to jdk9/dev: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ce33c780cfbd http://hg.openjdk.java.net/jdk9/dev/rev/882c782d7d5a In order to work with jake, these changes are needed: diff --git a/src/jdk.jartool/share/classes/module-info.java b/

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

jdk.scripting.nashorn is loaded by the extension class loader. Is jdk.dynalink expected to be loaded by the ext. class loader? You need to edit this file to include the new module: jdk/make/src/classes/build/tools/module/ext.modules This is an interim file to map modules to class loader and

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

+1 on all changes. -Sundar On 11/20/2015 12:15 AM, Attila Szegedi wrote: Please review JDK-8141338 "Move jdk.internal.dynalink package to jdk.dynalink" for . This is basically the implementation step for integrating JEP 276. This changeset wil

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

I reviewed the top repo change. modules.xml looks fine. jdk.dynalink should be in MAIN_MODULES since it has exported APIs. jdk.scripting.nashorn should be moved too. They are not sole service providers. Since you are on this file, can you move jdk.scripting.nashorn to MAIN_MODULES as well?

Re: About 8056174: New APIs for jar signing

> On Nov 20, 2015, at 9:46 AM, Mandy Chung wrote: > > This looks okay. We will push this fix once we pull down your changeset to > jake. > > One question: is “altsignerpath” and “altsigner” properties are only for the > existing jarsigner -altsigner option to work? Yes, because jarsigner

Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

Please review JDK-8141338 "Move jdk.internal.dynalink package to jdk.dynalink" for . This is basically the implementation step for integrating JEP 276. This changeset will introduce a new public API that has CCC approval (request 8075866), and is

hg: jigsaw/jake/jdk: 2 new changesets

Changeset: e6921b23f45b Author:mchung Date: 2015-11-19 14:03 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e6921b23f45b ClassLoader::loadLocalClass should call findClass only if not loaded ! src/java.base/share/classes/java/lang/ClassLoader.java Changeset: f1fff0daf868

Re: RFR: 8139430

On 19/11/2015 16:40, Alexandre (Shura) Iline wrote: Yes, sorry. Since the methods do not have any work to complete before interrupting and also methods are not used anywhere currently, I assume re-throwing the InterruptedException is a better choice. http://cr.openjdk.java.net/~shurailine/8

Re: RFR: 8139430

Yes, sorry. Since the methods do not have any work to complete before interrupting and also methods are not used anywhere currently, I assume re-throwing the InterruptedException is a better choice. http://cr.openjdk.java.net/~shurailine/8139430/webrev.07/test/lib/testlibrary/jdk/testlibrary/ma

Re: [jake] RFR JDK-8132672: DGCDeadLock test needs to be updated to wok with update setAccessible

On 19/11/2015 14:03, Amy Lu wrote: java/rmi/transport/dgcDeadLock/DGCDeadLock.java is a white-box test that needs to access internal objects by purpose. This patch is to add "-XaddExports" to the test. Please review. This looks okay to me, thanks for taking this one. -Alan.

hg: jigsaw/jake/jdk: 8132672: DGCDeadLock test needs to be updated to wok with modules

Changeset: e8a58d7ea798 Author:amlu Date: 2015-11-19 15:03 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e8a58d7ea798 8132672: DGCDeadLock test needs to be updated to wok with modules ! test/ProblemList.jake.txt ! test/java/rmi/transport/dgcDeadLock/DGCDeadLock.java

[jake] RFR JDK-8132672: DGCDeadLock test needs to be updated to wok with update setAccessible

java/rmi/transport/dgcDeadLock/DGCDeadLock.java is a white-box test that needs to access internal objects by purpose. This patch is to add "-XaddExports" to the test. Please review. bug: https://bugs.openjdk.java.net/browse/JDK-8132672 webrev: http://cr.openjdk.java.net/~amlu/8132672/webrev.00