hg: jigsaw/jake/hotspot: 8142333: Build failure in debugInfoRec.cpp with SS12u4

2015-12-10 Thread mandy . chung
Changeset: 5ef7fe2c05cc Author:never Date: 2015-11-30 15:21 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/5ef7fe2c05cc 8142333: Build failure in debugInfoRec.cpp with SS12u4 Reviewed-by: coleenp, dholmes, erikj, kvn ! src/share/vm/code/debugInfoRec.cpp

Re: MethodHandles.Lookup and modules

2015-12-10 Thread John Rose
On Dec 10, 2015, at 11:20 AM, stanislav lukyanov wrote: > > Alan, > thanks for the comments! > Please see below. > > On 10.12.2015 1:16, Alan Bateman wrote: >> >> On 09/12/2015 14:54, stanislav lukyanov wrote: >>> >>> 1) Lookup.in() javadoc says >>> "If the lookup for this Lookup is in a name

Re: preliminary RFR: 8049365 - Update JDI and JDWP for modules

2015-12-10 Thread serguei.spit...@oracle.com
Alan, Thanks for the comments and suggestions! On 12/10/15 04:04, Alan Bateman wrote: On 10/12/2015 08:03, serguei.spit...@oracle.com wrote: Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/jdk/8049365-Jigsaw-jdk.0/ Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/

Re: preliminary RFR: 8049365 - Update JDI and JDWP for modules

2015-12-10 Thread harold seigel
Hi Serguei, Looks good. Just a few comments. 1. Should jni_GetAllModules() contain the DTrace macros that other JNI entries have? 2. Can you add a similar GetAllModules() function to jniCheck.cpp ? Thanks, Harold On 12/10/2015 7:04 AM, Alan Bateman wrote: On 10/12/2015 08:03, serguei.spi

Re: MethodHandles.Lookup and modules

2015-12-10 Thread stanislav lukyanov
Alan, thanks for the comments! Please see below. On 10.12.2015 1:16, Alan Bateman wrote: On 09/12/2015 14:54, stanislav lukyanov wrote: 1) Lookup.in() javadoc says "If the lookup for this Lookup is in a named module, and the new lookup class is in a different module M, then no members, not e

hg: jigsaw/jake/jdk: 8135008: [TEST_BUG] Part 3: update client tests requiring jake-specific options after changes in setAccessible(true) routine

2015-12-10 Thread alan . bateman
Changeset: 095faeceaa95 Author:yan Date: 2015-12-10 15:43 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/095faeceaa95 8135008: [TEST_BUG] Part 3: update client tests requiring jake-specific options after changes in setAccessible(true) routine Reviewed-by: alanb ! test/j

Re: preliminary RFR: 8049365 - Update JDI and JDWP for modules

2015-12-10 Thread Alan Bateman
On 10/12/2015 08:03, serguei.spit...@oracle.com wrote: Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/jdk/8049365-Jigsaw-jdk.0/ Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8049365-Jigsaw-hs.0/ Summary: It is expected that the JDI and JDWP updat

preliminary RFR: 8049365 - Update JDI and JDWP for modules

2015-12-10 Thread serguei.spit...@oracle.com
Please, review this initial fix for the Jigsaw Bill milestone task: https://bugs.openjdk.java.net/browse/JDK-8049365 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/jdk/8049365-Jigsaw-jdk.0/ Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8049365-Jigsaw-h