Re: Problem using JavaFX Application class

Hi Kevin, Agreed that a little documentation goes a long way. Might it be an idea to support launching a JavaFX application through service binding at a later stage? Sander > On 24 Feb 2016, at 03:07, Kevin Rushforth wrote: > > Actually, I don't see any problem here, other than that we wil

RFR 8078812, Test RMI with client and servers as modules

Hi all, please review the new tests to use RMI in module world. Webrev: http://cr.openjdk.java.net/~xiaofeya/8078812/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8078812

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

Jon and Alan, thanks a lot for this comment. Fixed it in new webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.01/ -Felix > On Feb 23, 2016, at 11:54 PM, Jonathan Gibbons > wrote: > > On 02/23/2016 06:40 AM, Alan Bateman wrote: >> This fails if JDK8_HOME is not defined and I'm sur

Re: Problem using JavaFX Application class

I need a bit more time to think about it, but the fact that JavaFX need to access your application class to construct the instance and call the init, start, etc., methods is not an implementation detail. It is the specified behavior. And no, unlike ServiceProvider, there is no special power tha

Re: Problem using JavaFX Application class

Actually, I don't see any problem here, other than that we will need to document that if you want to launch a modular javafx application, you need to export the package containing your main class. This is an extension of what is needed today, which is that the class be public. If you use FXML,

Re: Problem using JavaFX Application class

Hi David, Thanks for the quick response. Here is a small sample project: https://bitbucket.org/sandermak/javafx-application/src, the compilerun.sh can be used to start the app. I already alluded to the solution you propose in the original post. Indeed, when exporting the class that extends Appl

Re: modulepath and classpath mixture

On 02/23/2016 01:22 PM, Robert Scholte wrote: On Tue, 23 Feb 2016 22:14:32 +0100, Jonathan Gibbons wrote: On 02/23/2016 01:06 PM, Jonathan Gibbons wrote: On 02/23/2016 12:48 PM, Robert Scholte wrote: On Tue, 23 Feb 2016 01:52:50 +0100, Jonathan Gibbons wrote: On 02/22/2016 12:44

Re: Problem using JavaFX Application class

On 2/23/16, 3:37 PM, Sander Mak wrote: Hi, Sander, we may not have tested Jigsaw with the path you are trying to take here. Certainly the common path of a class extending Application will launch properly, and I have been trudging through our test cases working on some odder paths. What I

hg: jigsaw/jake/langtools: recategorize -addmods -limitmods as standard options

Changeset: ca356fc6f111 Author:jjg Date: 2016-02-23 13:31 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ca356fc6f111 recategorize -addmods -limitmods as standard options ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java

Re: modulepath and classpath mixture

On Tue, 23 Feb 2016 22:14:32 +0100, Jonathan Gibbons wrote: On 02/23/2016 01:06 PM, Jonathan Gibbons wrote: On 02/23/2016 12:48 PM, Robert Scholte wrote: On Tue, 23 Feb 2016 01:52:50 +0100, Jonathan Gibbons wrote: On 02/22/2016 12:44 PM, Robert Scholte wrote: Hi, first of all I

Re: modulepath and classpath mixture

On 02/23/2016 01:10 PM, Robert Scholte wrote: And maybe this is the key question: if src/main/java is a module, should we handle src/test/java as a module too or leave it as a classpath based project? thanks, Robert You list 2 choices, but there's 3 possible answers here. If you're wr

Re: modulepath and classpath mixture

On 02/23/2016 01:06 PM, Jonathan Gibbons wrote: On 02/23/2016 12:48 PM, Robert Scholte wrote: On Tue, 23 Feb 2016 01:52:50 +0100, Jonathan Gibbons wrote: On 02/22/2016 12:44 PM, Robert Scholte wrote: Hi, first of all I'd like to say that I'm very pleased with the new -mp options, th

Re: modulepath and classpath mixture

On Tue, 23 Feb 2016 01:30:16 +0100, Alex Buckley wrote: Hi Robert, On 2/22/2016 12:44 PM, Robert Scholte wrote: Here's my use case: I noticed that if I add a module-info to src/main/java and put all compile-scoped dependencies to the module path, all compiles fines. Sounds good. I assum

Re: modulepath and classpath mixture

On Tue, 23 Feb 2016 13:59:13 +0100, Alan Bateman wrote: On 22/02/2016 20:44, Robert Scholte wrote: Hi, first of all I'd like to say that I'm very pleased with the new -mp options, these matches better with the way Apache Maven would like to work with jars and class-folders. Here's my

Re: modulepath and classpath mixture

On 02/23/2016 12:48 PM, Robert Scholte wrote: On Tue, 23 Feb 2016 01:52:50 +0100, Jonathan Gibbons wrote: On 02/22/2016 12:44 PM, Robert Scholte wrote: Hi, first of all I'd like to say that I'm very pleased with the new -mp options, these matches better with the way Apache Maven would

Re: modulepath and classpath mixture

On Tue, 23 Feb 2016 01:52:50 +0100, Jonathan Gibbons wrote: On 02/22/2016 12:44 PM, Robert Scholte wrote: Hi, first of all I'd like to say that I'm very pleased with the new -mp options, these matches better with the way Apache Maven would like to work with jars and class-folders. H

Problem using JavaFX Application class

Hi, When trying to run a module with a main class that extends javafx.application.Application, the following exception is thrown by the VM: Exception in thread "main" java.lang.RuntimeException: Unable to construct Application instance: class javamodularity.easytext.gui.Main at com.sun

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

On 02/23/2016 06:40 AM, Alan Bateman wrote: This fails if JDK8_HOME is not defined and I'm sure will be annoyance for those that run jtreg directly. Should we get the test to just pass if not set? I realize that is not ideal. -Alan. It is relatively common practice for tests that require so

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

On 23/02/2016 03:40, Felix Yang wrote: Please review the following new test. Webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8141609 jdk 9 bundled a "jrt-fs.jar" file which expose the jrt filesystem support. It is critical that a

hg: jigsaw/jake/jdk: 2 new changesets

Changeset: ec373384ff18 Author:alanb Date: 2016-02-23 14:16 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ec373384ff18 Improve jvmstat counters in module system initialization ! src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java Changeset: 73b1fef07d2

hg: jigsaw/jake/jdk: jlink's --saveopts option accepts name of the file into which options are saved

Changeset: d74745c7a27d Author:sundar Date: 2016-02-23 18:35 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d74745c7a27d jlink's --saveopts option accepts name of the file into which options are saved ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java

Re: modulepath and classpath mixture

On 22/02/2016 20:44, Robert Scholte wrote: Hi, first of all I'd like to say that I'm very pleased with the new -mp options, these matches better with the way Apache Maven would like to work with jars and class-folders. Here's my use case: I noticed that if I add a module-info to src/main/j

hg: jigsaw/jake/jdk: 8148261: release file has incorrect properties when targeting different platform

Changeset: ec23613dac0f Author:sundar Date: 2016-02-23 16:14 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ec23613dac0f 8148261: release file has incorrect properties when targeting different platform ! src/jdk.jlink/share/classes/jdk/tools/jlink/Jlink.java ! src/jdk.jl