Re: RFR 8078812, Test RMI with client and servers as modules

2016-02-29 Thread Felix Yang
Ping... -Felix On 2016/2/24 14:06, Felix Yang wrote: Hi all, please review the new tests to use RMI in module world. Webrev: http://cr.openjdk.java.net/~xiaofeya/8078812/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8078812 Thanks, Felix

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-02-29 Thread Felix Yang
Hi Alan, please review the new webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.02/ Major changes: 1. remove checking for 'java.version' in JrtfsTestMain and add new check for 'release' file 2. In order to avoid dup tests with Basic.java, add new BaseTest.java, which is a plain

hg: jigsaw/jake/langtools: Update jdeps to generate dotfile for -s -m option

2016-02-29 Thread mandy . chung
Changeset: f12657c2358d Author:mchung Date: 2016-02-29 20:58 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f12657c2358d Update jdeps to generate dotfile for -s -m option ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java ! src/jdk.jdeps/share/classes

hg: jigsaw/jake/jdk: Missing -ljvm in libinstrument dependency

2016-02-29 Thread mandy . chung
Changeset: 424361a2e9dd Author:mchung Date: 2016-02-29 20:47 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/424361a2e9dd Missing -ljvm in libinstrument dependency ! make/lib/Lib-java.instrument.gmk

hg: jigsaw/jake/jdk: 8150664: Split "provides" lines in module-info.java get ignored

2016-02-29 Thread mandy . chung
Changeset: d8e638c47144 Author:mchung Date: 2016-02-29 16:40 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d8e638c47144 8150664: Split "provides" lines in module-info.java get ignored ! make/src/classes/build/tools/jigsaw/GenGraphs.java ! make/src/classes/build/tools/mo

Re: Round #3: RFR: 8147467 - Add ClassFileTransformer transform method that provide the Module to the agent

2016-02-29 Thread Alan Bateman
On 29/02/2016 20:11, Remi Forax wrote: Hi Alan, hi Sergei, i see two issues with this patch, the first one is that before that change, ClassFileTransformer was a functional interface, it's not a functional interface anymore, so it will break code (note that ClassFileTransformer is not annotated

Re: Round #3: RFR: 8147467 - Add ClassFileTransformer transform method that provide the Module to the agent

2016-02-29 Thread Remi Forax
Hi Alan, hi Sergei, i see two issues with this patch, the first one is that before that change, ClassFileTransformer was a functional interface, it's not a functional interface anymore, so it will break code (note that ClassFileTransformer is not annotated with @FunctionalInterface so it's a kind

Re: Round #3: RFR: 8147467 - Add ClassFileTransformer transform method that provide the Module to the agent

2016-02-29 Thread serguei.spit...@oracle.com
On 2/29/16 04:29, Alan Bateman wrote: On 29/02/2016 08:32, serguei.spit...@oracle.com wrote: : Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-8147467 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8147467-Jigsaw-agents.jdk3/ This looks good and I ca

hg: jigsaw/jake/jdk: More updates to java.lang.instrument javadoc

2016-02-29 Thread alan . bateman
Changeset: d1729f7296a0 Author:alanb Date: 2016-02-29 15:45 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d1729f7296a0 More updates to java.lang.instrument javadoc ! src/java.instrument/share/classes/java/lang/instrument/ClassFileTransformer.java ! src/java.instrument/

Re: Round #3: RFR: 8147467 - Add ClassFileTransformer transform method that provide the Module to the agent

2016-02-29 Thread Alan Bateman
On 29/02/2016 08:32, serguei.spit...@oracle.com wrote: : Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-8147467 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8147467-Jigsaw-agents.jdk3/ This looks good and I can get this into the jake/jdk repo for y

hg: jigsaw/jake/jdk: 2 new changesets

2016-02-29 Thread alan . bateman
Changeset: 2baaae447e8c Author:sspitsyn Date: 2016-02-29 11:20 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/2baaae447e8c Add ClassFileTransformer transform method that provides the Module to the agent ! src/java.instrument/share/classes/java/lang/instrument/ClassFileT

hg: jigsaw/jake/langtools: 8150030: Fix Elements.get{Type,Package}Element/JavaCompiler.resolveIdent on uninitialized javac; ...

2016-02-29 Thread jan . lahoda
Changeset: 4f320a94d1df Author:jlahoda Date: 2016-02-29 12:07 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4f320a94d1df 8150030: Fix Elements.get{Type,Package}Element/JavaCompiler.resolveIdent on uninitialized javac 8150031: Fix tools/javac/importscope/dependenci

Re: Round #3: RFR: 8147467 - Add ClassFileTransformer transform method that provide the Module to the agent

2016-02-29 Thread serguei.spit...@oracle.com
Forgot to include the jigsaw-dev mailing list. On 2/29/16 00:29, serguei.spit...@oracle.com wrote: Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-8147467 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8147467-Jigsaw-agents.jdk3/ Summary: This ver

hg: jigsaw/jake/jdk: 3 new changesets

2016-02-29 Thread alan . bateman
Changeset: 37e319f5d549 Author:alanb Date: 2016-02-29 07:58 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/37e319f5d549 Clean-up of Layer API/javadoc ! src/java.base/share/classes/java/lang/reflect/Layer.java ! src/java.base/share/classes/java/lang/reflect/Module.java !