[9-jake] Review request: 8151320: Remove unnecessary addReads from JavaFX

2016-03-05 Thread Kevin Rushforth
Please review the following: https://bugs.openjdk.java.net/browse/JDK-8151320 http://cr.openjdk.java.net/~kcr/8151320/webrev.00/ Now that addReads are no longer necessary in cases where we use core reflection [1] we will eliminate these unneeded calls in the FX jake repo. -- Kevin [1] http:

Re: [9-dev] RfR: JDK-8132743: Move netscape.javascript package from jdk.plugin to new module

2016-03-05 Thread Kevin Rushforth
Looks good. -- Kevin David DeHaven wrote: I've updated the webrev, hopefully one last time with feedback from Joe Darcy. http://cr.openjdk.java.net/~ddehaven/8132743/webrev.2/ - Relocated package Javadoc to above the package declaration in package-info.java - Reworded the Javadoc on the defa

Re: [9-dev] RfR: JDK-8132743: Move netscape.javascript package from jdk.plugin to new module

2016-03-05 Thread Mandy Chung
On Mar 5, 2016, at 10:54 AM, David DeHaven wrote: > > > I've updated the webrev, hopefully one last time with feedback from Joe Darcy. > http://cr.openjdk.java.net/~ddehaven/8132743/webrev.2/ > > - Relocated package Javadoc to above the package declaration in > package-info.java > - Reworded

Re: jlink and automatic modules

2016-03-05 Thread forax
- Mail original - > De: "Alan Bateman" > À: "Remi Forax" > Cc: "Sander Mak" , "jigsaw-dev" > > Envoyé: Samedi 5 Mars 2016 10:21:49 > Objet: Re: jlink and automatic modules > > > On 05/03/2016 09:00, Remi Forax wrote: > > IMO, the real question is "should automatic modules see classe

Re: [9-dev] RfR: JDK-8132743: Move netscape.javascript package from jdk.plugin to new module

2016-03-05 Thread David DeHaven
I've updated the webrev, hopefully one last time with feedback from Joe Darcy. http://cr.openjdk.java.net/~ddehaven/8132743/webrev.2/ - Relocated package Javadoc to above the package declaration in package-info.java - Reworded the Javadoc on the default JSObject ctor A point was brought up that

hg: jigsaw/jake/jdk: 4 new changesets

2016-03-05 Thread alan . bateman
Changeset: cc21247fa902 Author:alanb Date: 2016-03-05 10:29 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/cc21247fa902 Change -Xpatch to emit warning if module-info.class found in patch ! src/java.base/share/classes/jdk/internal/module/ModulePatcher.java Changeset: 8ca

hg: jigsaw/jake/langtools: 2 new changesets

2016-03-05 Thread alan . bateman
Changeset: 7d58ddf15811 Author:alanb Date: 2016-03-05 15:12 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7d58ddf15811 Rename ModuleFinder.ofInstalled to ofSystem ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/ModuleWrappers.java ! src/jdk.jdeps/share/c

hg: jigsaw/jake/jdk: Add support for early VMStart event

2016-03-05 Thread alan . bateman
Changeset: 64e1d96b83a4 Author:sspitsyn Date: 2016-03-05 14:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/64e1d96b83a4 Add support for early VMStart event ! src/java.base/share/native/include/jvmti.h

hg: jigsaw/jake/hotspot: Add support for early VMStart event

2016-03-05 Thread alan . bateman
Changeset: eb282913bc35 Author:sspitsyn Date: 2016-03-05 14:10 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/eb282913bc35 Add support for early VMStart event ! src/share/vm/prims/jvmti.xml ! src/share/vm/prims/jvmti.xsl ! src/share/vm/prims/jvmtiEnter.xsl ! src/shar

Re: jlink and automatic modules

2016-03-05 Thread Alan Bateman
On 05/03/2016 09:00, Remi Forax wrote: IMO, the real question is "should automatic modules see classes from the classpath" ? Automatic modules are for bridging to the class path so they have to read the unnamed module (or more specifically, they read all unnamed modules). -Alan.

hg: jigsaw/jake/jdk: javax/sound/sampled/spi/AudioFileReader/RecognizeWaveExtensible.java failing

2016-03-05 Thread alan . bateman
Changeset: 5f757f33fe00 Author:serb Date: 2016-03-05 08:45 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/5f757f33fe00 javax/sound/sampled/spi/AudioFileReader/RecognizeWaveExtensible.java failing ! src/java.desktop/share/classes/module-info.java

Re: jlink and automatic modules

2016-03-05 Thread Remi Forax
IMO, the real question is "should automatic modules see classes from the classpath" ? if the answer is yes, then they can not be used with jlink. Rémi - Mail original - > De: "Alan Bateman" > À: "Sander Mak" , "jigsaw-dev" > > Envoyé: Vendredi 4 Mars 2016 09:10:58 > Objet: Re: jlink