Changeset: 3218d2a00785
Author:hannesw
Date: 2016-03-07 13:28 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/3218d2a00785
8148148: Remove pluggable CodeStore API
Reviewed-by: attila, mhaupt
!
src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/CodeS
On 08/03/2016 07:45, Volker Simonis wrote:
:
OK, that would be fine. This problem isn't very urgent but it would be
good if we could resolve it before the big jake integration into
jdk9-dev.
In order, then my preferences for resolving this are:
1. Compete the tool separation, meaning JDK-805
Changeset: a9f1485296c7
Author:alanb
Date: 2016-03-08 11:19 +
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a9f1485296c7
pack200 review comments
! src/java.base/share/classes/com/sun/java/util/jar/pack/intrinsic.properties
! test/tools/pack200/ModuleAttributes.java
Chang
On Tue, Mar 8, 2016 at 3:08 PM, Alan Bateman wrote:
>
> On 08/03/2016 07:45, Volker Simonis wrote:
>>
>> :
>> OK, that would be fine. This problem isn't very urgent but it would be
>> good if we could resolve it before the big jake integration into
>> jdk9-dev.
>>
>>
> In order, then my preference
I've refreshed the webrevs here:
http://cr.openjdk.java.net/~alanb/8142968/1
so that we have a snapshot of what is currently in the jigsaw/jake
forest. The webrves are against jdk-9+108.
I plan to send mail to jdk9-dev soon proposing that we integrate a
snapshot into JDK 9 before the end o
Changeset: ceb8dfa70331
Author:jlahoda
Date: 2016-03-08 17:41 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ceb8dfa70331
Changing ModuleSymbol.visiblePackage from Set to Map, to avoid linear search in
lookupPackage, as noted by mcimadamore.
! src/jdk.compiler/sha
I've posted an update to the State of the Module System document [1].
The main change in this edition is the introduction of material on
compatibility and migration, including automatic modules [2]. This
update also revises the description of reflective readability [3],
reorders the text to impro
Changeset: 64f3ca334b12
Author:sundar
Date: 2016-03-08 22:17 +0530
URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/64f3ca334b12
CodeStoreAndPathTest used to fail with NPE. Fixed and re-enabled the test.
!
src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/codegen
Changeset: cb0ba4c602a8
Author:mchung
Date: 2016-03-08 09:05 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/cb0ba4c602a8
Fix formatting nit
! src/java.management/share/classes/sun/management/TypeVersionMapper.java
Changeset: 5b9dfdb08517
Author:mchung
Date: 201
On 08/03/2016 00:15, Mandy Chung wrote:
:
src/java.management/share/classes/sun/management/ThreadInfoCompositeData.java
197 private static final String[] threadInfoV9Attributes = {
198 DAEMON,
199 PRIORITY,
200 MODULE_NAME,
201 MODULE_VERSION,
Are
Hi,
Review comments for the jimage code in java.base, mostly cleanup but
perhaps a bug or two.
General: inconsistent style and not following guidelines, copyright
dates may need an update.
Use of assert for error checking is not going to catch or help isolate
errors in production builds.
di
Changeset: fc6d7220f074
Author:hseigel
Date: 2016-03-08 12:52 -0500
URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/fc6d7220f074
Remove unused _module_offset
! src/share/vm/runtime/vmStructs.cpp
On Mon, 07 Mar 2016 13:13:38 +0100, Alan Bateman
wrote:
On 06/03/2016 14:01, Robert Scholte wrote:
Hi,
I've asked for some feedback and there seems to be concerns with split
packages when there are two or more modules on the module path that
export the same package.
Unless I misundersta
On Mon, 07 Mar 2016 14:53:28 +0100, Sander Mak
wrote:
I don't think I understand the issue here. Using -Xpatch doesn't change
the module declaration or export. It can be used to override or augment
the module content, it just can't override the module declaration. It
can be used in con
Robert, it's sounds like a chicken-and-egg problem. You need the module
name to compile but don't know it until you have compiled.
Too bad this file isn't XML so that any tool could read the module
information outside of compiling. That's what I advocated for a long time
but that battle has been l
Changeset: 1ae14b475915
Author:hseigel
Date: 2016-03-08 15:34 -0500
URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/1ae14b475915
Add #include from JDK-9 to fix open build
! src/share/vm/trace/traceTypes.xsl
Hello,
I reviewed ResourceBundle code and related locale data changes. Overall
it looks good to me. Here are some minor comments:
java.util.ResourceBundle.java
- In the class description, there are two occurrences of example
explaing service provider type (i.e., basename+"Provider"). It seem
I'm hoping we can bulk up some of the new exception handling. I've put
suggested edits for the jdk repo together in a webrev. No major edits
here but it should help supportability of the code for the future. Will
it be possible to import these in before the bulk push ?
http://cr.openjdk.java.n
The only rational solution to this problem is to completely forego the
JDK's capabilities and generate the file exclusively from the build
tooling. I expect that at some point we'll end up with a series of
tools which construct the exports list from annotated package-infos, the
requires list f
Bikeshed: JDK 9 is supposed to be feature complete 5/26/16 and be RC by
next January. Is this really enough time for EE Application Server projects
and other tools like Maven to vet the capabilities?
Cheers,
Paul
On Tue, Mar 8, 2016 at 4:08 PM, David M. Lloyd
wrote:
> The only rational solution
Changeset: 806170c571fc
Author:jjg
Date: 2016-03-08 14:35 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/806170c571fc
Add missing comments
! src/jdk.compiler/share/classes/com/sun/source/tree/ExportsTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/Mod
Changeset: be44e8eac21b
Author:mchung
Date: 2016-03-08 14:38 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/be44e8eac21b
java.management review comment
! src/java.management/share/classes/sun/management/ThreadInfoCompositeData.java
Changeset: 21b6a9c4195c
Author:mch
> On Mar 8, 2016, at 6:08 AM, Alan Bateman wrote:
>
>
> On 08/03/2016 07:45, Volker Simonis wrote:
>> :
>> OK, that would be fine. This problem isn't very urgent but it would be
>> good if we could resolve it before the big jake integration into
>> jdk9-dev.
>>
>>
> In order, then my preferen
> On Mar 8, 2016, at 1:37 PM, Naoto Sato wrote:
>
> Hello,
>
> I reviewed ResourceBundle code and related locale data changes. Overall it
> looks good to me. Here are some minor comments:
>
> java.util.ResourceBundle.java
>
> - In the class description, there are two occurrences of example e
Changeset: 0cb233626ef4
Author:jjg
Date: 2016-03-08 15:45 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/0cb233626ef4
unexport javap
! src/jdk.jdeps/share/classes/module-info.java
! test/tools/javac/6627362/T6627362.java
! test/tools/javac/ConstFoldTest.java
! test
Changeset: 8d10a22ce763
Author:mchung
Date: 2016-03-08 15:47 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/8d10a22ce763
resource bundle review comment
! src/java.base/share/classes/java/util/ResourceBundle.java
! src/java.base/share/classes/sun/util/resources/LocaleData
Changeset: 66a5d67b0116
Author:mchung
Date: 2016-03-08 16:24 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/rev/66a5d67b0116
Reenable -Xdoclint for jdk.compiler
! make/CompileJavaModules.gmk
Changeset: 8c6b165360cb
Author:jjg
Date: 2016-03-08 17:46 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8c6b165360cb
start converting new code to new diags system
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java
!
src/jdk.compiler/share/clas
Changeset: 653b36207ab2
Author:jjg
Date: 2016-03-08 18:40 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/653b36207ab2
minor source cleanup
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java
Changeset: 4592ca08edb5
Author:jjg
Date: 2016
Changeset: b252701735f4
Author:jjg
Date: 2016-03-08 20:06 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b252701735f4
convert new code to use new diags system
! src/jdk.compiler/share/classes/com/sun/tools/javac/code/ModuleFinder.java
! src/jdk.compiler/share/class
Changeset: b77257de7003
Author:mchung
Date: 2016-03-08 20:43 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b77257de7003
Minor javadoc cleanup
! src/java.base/share/classes/java/lang/Class.java
! src/java.base/share/classes/java/lang/ClassLoader.java
31 matches
Mail list logo
