RFR 8154182: Fix java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java to only use available modules

2016-04-13 Thread Alexandre (Shura) Iline
Hi, Could you be so kind to take a look on this fix: http://cr.openjdk.java.net/~shurailine/8154182/webrev.00/ Thank you. Shura

Re: running Groovy on JDK9

2016-04-13 Thread Alex Buckley
On 4/13/2016 9:05 AM, Jochen Theodorou wrote: What I would prefer though is a proper generic way to call a default method on an interface without having an implementing instance. A MethodHandles.lookup().in(Comperator.class) won't give me access to invokespecial Comperator#reversed, or am I wrong

Re: RFR: 8078820: Test deploying a XML parser as a module

2016-04-13 Thread huizhe wang
On 4/13/2016 5:55 AM, Alan Bateman wrote: On 11/04/2016 02:39, Frank Yuan wrote: Hi Alan and Joe Would you like to have a look at this review http://cr.openjdk.java.net/~fyuan/8078820/webrev.01/ ? I skimmed through the tests and they are testing the right scenarios. I assume you'll work

Re: running Groovy on JDK9

2016-04-13 Thread Jochen Theodorou
On 13.04.2016 14:10, Alan Bateman wrote: On 11/04/2016 16:57, Jochen Theodorou wrote: [...] org.codehaus.groovy.runtime.InterfaceConversionTest > testDefaultInterfaceMethodCallOnProxy FAILED java.lang.AssertionError: java.util.Comparator/2 at java.lang.invoke.MethodHandles$Lookup.

Re: RFR: JDK-8151807 - ImageBufferCache should release buffers when all classes are loaded

2016-04-13 Thread Jim Laskey (Oracle)
javac uses 3 buffers concurrently even without compression. These seem to be legit (allocated and released properly.) > On Apr 13, 2016, at 10:23 AM, Alan Bateman wrote: > > > On 13/04/2016 14:18, Jim Laskey (Oracle) wrote: >> Yes, needed for decompression. >> > So how many are in use-case?

Re: RFR: JDK-8075550 - Error "JavaFX runtime not found" in nashorn when load predefines scripts to import JavaFX packages

2016-04-13 Thread Marcus Lagergren
+1 > On 08 Apr 2016, at 19:05, Jim Laskey (Oracle) wrote: > > The code was reworked to use jrtfs: instead of reading from javafx.jar. > > http://cr.openjdk.java.net/~jlaskey/8075550/webrev/index.html > https://bugs.openjdk.java.net/browse/JDK-8075550 > > >

Re: RFR: JDK-8151807 - ImageBufferCache should release buffers when all classes are loaded

2016-04-13 Thread Alan Bateman
On 13/04/2016 14:18, Jim Laskey (Oracle) wrote: Yes, needed for decompression. So how many are in use-case? I'm just wondering if ImageBufferCache actually needs to cache >1 buffer. -Alan

Re: RFR: JDK-8151807 - ImageBufferCache should release buffers when all classes are loaded

2016-04-13 Thread Sundararajan Athijegannathan
+1 -Sundar On 4/13/2016 6:45 PM, Alan Bateman wrote: > On 11/04/2016 14:37, Jim Laskey (Oracle) wrote: >> http://cr.openjdk.java.net/~jlaskey/8151807/webrev/index.html >> https://bugs.openjdk.java.net/browse/JDK-8151807 > This looks quite although I'm wondering if there are cases where we > need

Re: RFR: JDK-8151807 - ImageBufferCache should release buffers when all classes are loaded

2016-04-13 Thread Jim Laskey (Oracle)
Yes, needed for decompression. > On Apr 13, 2016, at 10:15 AM, Alan Bateman wrote: > > On 11/04/2016 14:37, Jim Laskey (Oracle) wrote: >> http://cr.openjdk.java.net/~jlaskey/8151807/webrev/index.html >> https://bugs.openjdk.java.net/browse/JDK-8151807 > This looks quite although I'm wondering if

Re: RFR: JDK-8151807 - ImageBufferCache should release buffers when all classes are loaded

2016-04-13 Thread Alan Bateman
On 11/04/2016 14:37, Jim Laskey (Oracle) wrote: http://cr.openjdk.java.net/~jlaskey/8151807/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8151807 This looks quite although I'm wondering if there are cases where we need up to 3 buffers. Is it in the decompress code? I'm just wonderin

Re: RFR: 8078820: Test deploying a XML parser as a module

2016-04-13 Thread Alan Bateman
On 11/04/2016 02:39, Frank Yuan wrote: Hi Alan and Joe Would you like to have a look at this review http://cr.openjdk.java.net/~fyuan/8078820/webrev.01/ ? I skimmed through the tests and they are testing the right scenarios. I assume you'll work with Joe to get this into jdk9/dev/jaxp. -A

Re: running Groovy on JDK9

2016-04-13 Thread Alan Bateman
On 11/04/2016 16:57, Jochen Theodorou wrote: : Can it be registered via registerDriver? That actually made me wonder why exactly we require the system loader here in the first place. Part of the problem is DriverManager#getConnection, which is @CallerSensitive. So if I want to get a connecti

hg: jigsaw/jake/corba: Tempoary fix for idlj issue JDK-8153894

2016-04-13 Thread alan . bateman
Changeset: bd25ac71c3b7 Author:alanb Date: 2016-04-13 11:29 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/bd25ac71c3b7 Tempoary fix for idlj issue JDK-8153894 ! src/java.corba/share/classes/com/sun/tools/corba/se/idl/som/cff/FileLocator.java

Re: Accessing Attach API?

2016-04-13 Thread Alan Bateman
On 13/04/2016 10:26, Aleksey Shipilev wrote: : Wait, I confused myself with multiple JDK builds here. This actually works in JDK 9b113: Class vmClass = ClassLoader.getSystemClassLoader() .loadClass("com.sun.tools.attach.VirtualMachine"); Therefore, we are fine at the mo

Re: Accessing Attach API?

2016-04-13 Thread Aleksey Shipilev
On 04/13/2016 12:08 PM, Aleksey Shipilev wrote: > OpenJDK JOL is using Attach API to get the access to Instrumentation > instance without forcing user to -javaagent: the JAR. I think ByteBuddy > is using similar mechanism. > > How is one supposed to use Attach API these post-Jigsaw days? > > Befo

Accessing Attach API?

2016-04-13 Thread Aleksey Shipilev
Hi, OpenJDK JOL is using Attach API to get the access to Instrumentation instance without forcing user to -javaagent: the JAR. I think ByteBuddy is using similar mechanism. How is one supposed to use Attach API these post-Jigsaw days? Before JDK 9, we could poll VirtualMachine from tools.jar, an